| Message ID | 20240226033945.816974-1-jisheng.teoh@starfivetech.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | dt-bindings: pwm: opencores: Add compatible for StarFive JH8100 | expand |
Hello, On Mon, Feb 26, 2024 at 11:39:45AM +0800, Ji Sheng Teoh wrote: > StarFive JH8100 uses the same OpenCores PWM controller as JH7110. > Mark JH8100 as compatible to the OpenCores PWM controller. > > Signed-off-by: Ley Foon Tan <leyfoon.tan@starfivetech.com> > Signed-off-by: Ji Sheng Teoh <jisheng.teoh@starfivetech.com> > > --- > > This patch depends on patch [1] ("dt-bindings: pwm: Add bindings for > OpenCores PWM Controller") in Conor's riscv-dt-for-next branch. > [1] https://git.kernel.org/pub/scm/linux/kernel/git/conor/linux.git/commit/?h=riscv-dt-for-next&id=2529085831b01fcd02ff58ab4e2596d3b31bcf80 I recommend to make use of git format-patch's --base parameter to additionally(!) make this information available to the build bots. Looks fine to me. Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Coner: If you're happy with this patch, please apply it in the same way as the initial OpenCores PWM Controller binding patch. Best regards Uwe
On Mon, Feb 26, 2024 at 09:11:23AM +0100, Uwe Kleine-König wrote: > Hello, > > On Mon, Feb 26, 2024 at 11:39:45AM +0800, Ji Sheng Teoh wrote: > > StarFive JH8100 uses the same OpenCores PWM controller as JH7110. > > Mark JH8100 as compatible to the OpenCores PWM controller. > > > > Signed-off-by: Ley Foon Tan <leyfoon.tan@starfivetech.com> > > Signed-off-by: Ji Sheng Teoh <jisheng.teoh@starfivetech.com> > > > > --- > > > > This patch depends on patch [1] ("dt-bindings: pwm: Add bindings for > > OpenCores PWM Controller") in Conor's riscv-dt-for-next branch. > > [1] https://git.kernel.org/pub/scm/linux/kernel/git/conor/linux.git/commit/?h=riscv-dt-for-next&id=2529085831b01fcd02ff58ab4e2596d3b31bcf80 > > I recommend to make use of git format-patch's --base parameter to > additionally(!) make this information available to the build bots. I like the "additionally" :) > > Looks fine to me. > > Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> > > Coner: If you're happy with this patch, please apply it in the same way > as the initial OpenCores PWM Controller binding patch. Ye, I can do. Although, I suppose this is an example of why the driver maintainers applying the bindings is preferred, even if the driver patch itself isn't ready or there is no driver patch. Cheers, Conor.
On Mon, Feb 26, 2024 at 11:39:45AM +0800, Ji Sheng Teoh wrote: > StarFive JH8100 uses the same OpenCores PWM controller as JH7110. > Mark JH8100 as compatible to the OpenCores PWM controller. > > Signed-off-by: Ley Foon Tan <leyfoon.tan@starfivetech.com> > Signed-off-by: Ji Sheng Teoh <jisheng.teoh@starfivetech.com> > Applied, thanks. This should've been a b4 email, but I don't think the old copy of b4 I had on this machine likes UTF-8 encoding in email addresses as it generated a pile of crap in the to field. I'll have to see if a new version fixes that. Conor.
> On Mon, Feb 26, 2024 at 09:11:23AM +0100, Uwe Kleine-König wrote: > > Hello, > > > > On Mon, Feb 26, 2024 at 11:39:45AM +0800, Ji Sheng Teoh wrote: > > > StarFive JH8100 uses the same OpenCores PWM controller as JH7110. > > > Mark JH8100 as compatible to the OpenCores PWM controller. > > > > > > Signed-off-by: Ley Foon Tan <leyfoon.tan@starfivetech.com> > > > Signed-off-by: Ji Sheng Teoh <jisheng.teoh@starfivetech.com> > > > > > > --- > > > > > > This patch depends on patch [1] ("dt-bindings: pwm: Add bindings for > > > OpenCores PWM Controller") in Conor's riscv-dt-for-next branch. > > > [1] > > > https://git.kernel.org/pub/scm/linux/kernel/git/conor/linux.git/comm > > > it/?h=riscv-dt-for-next&id=2529085831b01fcd02ff58ab4e2596d3b31bcf80 > > > > I recommend to make use of git format-patch's --base parameter to > > additionally(!) make this information available to the build bots. > > I like the "additionally" :) Alright, I will take note of that. Thanks > > > > Looks fine to me. > > > > Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> > > > > Coner: If you're happy with this patch, please apply it in the same > > way as the initial OpenCores PWM Controller binding patch. > > Ye, I can do. Although, I suppose this is an example of why the driver maintainers applying the bindings is preferred, even if the driver > patch itself isn't ready or there is no driver patch. > > Cheers, > Conor.
diff --git a/Documentation/devicetree/bindings/pwm/opencores,pwm.yaml b/Documentation/devicetree/bindings/pwm/opencores,pwm.yaml index 0b85dd861dfd..52a59d245cdb 100644 --- a/Documentation/devicetree/bindings/pwm/opencores,pwm.yaml +++ b/Documentation/devicetree/bindings/pwm/opencores,pwm.yaml @@ -23,6 +23,7 @@ properties: - enum: - starfive,jh7100-pwm - starfive,jh7110-pwm + - starfive,jh8100-pwm - const: opencores,pwm-v1 reg: