| Message ID | 20240212162645.5661-3-tzimmermann@suse.de |
|---|---|
| State | Handled Elsewhere |
| Headers | show |
| Series | backlight: Replace struct fb_info in interfaces | expand |
On Mon, 12 Feb 2024 17:16:35 +0100 Thomas Zimmermann <tzimmermann@suse.de> wrote: > The driver sets struct fb_info.bl_dev to the correct backlight > device. Thus rely on the backlight core code to match backlight > and framebuffer devices, and remove the extra check_fb function > from struct backlight_ops. > > Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de> > Cc: Robin van der Gracht <robin@protonic.nl> > --- > drivers/auxdisplay/ht16k33.c | 8 -------- > 1 file changed, 8 deletions(-) > > diff --git a/drivers/auxdisplay/ht16k33.c b/drivers/auxdisplay/ht16k33.c > index a90430b7d07ba..0a858db32486b 100644 > --- a/drivers/auxdisplay/ht16k33.c > +++ b/drivers/auxdisplay/ht16k33.c > @@ -325,16 +325,8 @@ static int ht16k33_bl_update_status(struct backlight_device *bl) > return ht16k33_brightness_set(priv, brightness); > } > > -static int ht16k33_bl_check_fb(struct backlight_device *bl, struct fb_info *fi) > -{ > - struct ht16k33_priv *priv = bl_get_data(bl); > - > - return (fi == NULL) || (fi->par == priv); > -} > - > static const struct backlight_ops ht16k33_bl_ops = { > .update_status = ht16k33_bl_update_status, > - .check_fb = ht16k33_bl_check_fb, > }; When combined with the previous patch: [01/10] backlight: Match backlight device against struct fb_info.bl_dev (I wasn't in the CC) Acked-By: Robin van der Gracht <robin@protonic.nl>
Thomas Zimmermann <tzimmermann@suse.de> writes: > The driver sets struct fb_info.bl_dev to the correct backlight > device. Thus rely on the backlight core code to match backlight > and framebuffer devices, and remove the extra check_fb function > from struct backlight_ops. > > Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de> > Cc: Robin van der Gracht <robin@protonic.nl> > --- Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>
diff --git a/drivers/auxdisplay/ht16k33.c b/drivers/auxdisplay/ht16k33.c index a90430b7d07ba..0a858db32486b 100644 --- a/drivers/auxdisplay/ht16k33.c +++ b/drivers/auxdisplay/ht16k33.c @@ -325,16 +325,8 @@ static int ht16k33_bl_update_status(struct backlight_device *bl) return ht16k33_brightness_set(priv, brightness); } -static int ht16k33_bl_check_fb(struct backlight_device *bl, struct fb_info *fi) -{ - struct ht16k33_priv *priv = bl_get_data(bl); - - return (fi == NULL) || (fi->par == priv); -} - static const struct backlight_ops ht16k33_bl_ops = { .update_status = ht16k33_bl_update_status, - .check_fb = ht16k33_bl_check_fb, }; /*
The driver sets struct fb_info.bl_dev to the correct backlight device. Thus rely on the backlight core code to match backlight and framebuffer devices, and remove the extra check_fb function from struct backlight_ops. Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de> Cc: Robin van der Gracht <robin@protonic.nl> --- drivers/auxdisplay/ht16k33.c | 8 -------- 1 file changed, 8 deletions(-)