| Message ID | 20231023-display-support-v2-11-33ce8864b227@baylibre.com |
|---|---|
| State | Rejected |
| Headers | show |
| Series | Add display support for the MT8365-EVK board | expand |
Hello, On Tue, Apr 16, 2024 at 05:53:12PM +0200, Alexandre Mergnat wrote: > According to the Mediatek MT8365 datasheet, the display PWM block has > a power domain. > > Signed-off-by: Alexandre Mergnat <amergnat@baylibre.com> I already pointed that out in reply to the cover letter, so just to make it more easily to spot for people considering to apply this patch: This is already fixed in next. Best regards Uwe
On 17/04/2024 10:01, Uwe Kleine-König wrote: > Hello, > > On Tue, Apr 16, 2024 at 05:53:12PM +0200, Alexandre Mergnat wrote: >> According to the Mediatek MT8365 datasheet, the display PWM block has >> a power domain. >> >> Signed-off-by: Alexandre Mergnat <amergnat@baylibre.com> > > I already pointed that out in reply to the cover letter, so just to make > it more easily to spot for people considering to apply this patch: > > This is already fixed in next. > Hello, Sorry I've misunderstood the previous message. I will remove this patch for the next revision and notify it in the cover letter. Thanks > Best regards > Uwe >
Il 16/04/24 17:53, Alexandre Mergnat ha scritto: > According to the Mediatek MT8365 datasheet, the display PWM block has > a power domain. > > Signed-off-by: Alexandre Mergnat <amergnat@baylibre.com> It's the same for at least MT8195, MT8183 and I think MT8192 as well... so not having that from the beginning is actually a mistake. Please add a Fixes tag and resend, after which: Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Hello, On Wed, Apr 17, 2024 at 12:19:19PM +0200, AngeloGioacchino Del Regno wrote: > Il 16/04/24 17:53, Alexandre Mergnat ha scritto: > > According to the Mediatek MT8365 datasheet, the display PWM block has > > a power domain. > > > > Signed-off-by: Alexandre Mergnat <amergnat@baylibre.com> > > It's the same for at least MT8195, MT8183 and I think MT8192 as well... so > not having that from the beginning is actually a mistake. > > Please add a Fixes tag and resend, after which: > > Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> You mean similar to: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=fb7c3d8ba039df877886fd457538d8b24ca9c84b ? It seems someone you know well was quicker :-) Best regards Uwe
Il 17/04/24 15:25, Uwe Kleine-König ha scritto: > Hello, > > On Wed, Apr 17, 2024 at 12:19:19PM +0200, AngeloGioacchino Del Regno wrote: >> Il 16/04/24 17:53, Alexandre Mergnat ha scritto: >>> According to the Mediatek MT8365 datasheet, the display PWM block has >>> a power domain. >>> >>> Signed-off-by: Alexandre Mergnat <amergnat@baylibre.com> >> >> It's the same for at least MT8195, MT8183 and I think MT8192 as well... so >> not having that from the beginning is actually a mistake. >> >> Please add a Fixes tag and resend, after which: >> >> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> > > You mean similar to: > > https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=fb7c3d8ba039df877886fd457538d8b24ca9c84b > > ? It seems someone you know well was quicker :-) > > Best regards > Uwe > LOL! I totally forgot that I fixed that already :-D I need more coffee! Cheers, Angelo
diff --git a/Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml b/Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml index afcdeed4e88a..f8988af05287 100644 --- a/Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml +++ b/Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml @@ -52,6 +52,12 @@ properties: - const: main - const: mm + power-domains: + maxItems: 1 + description: A phandle and PM domain specifier as defined by bindings of + the power controller specified by phandle. See + Documentation/devicetree/bindings/power/power-domain.yaml for details. + required: - compatible - reg
According to the Mediatek MT8365 datasheet, the display PWM block has a power domain. Signed-off-by: Alexandre Mergnat <amergnat@baylibre.com> --- Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml | 6 ++++++ 1 file changed, 6 insertions(+)