| Message ID | 20210412095457.15095-5-billy_tsai@aspeedtech.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | Support pwm driver for aspeed ast26xx | expand |
Hello, On Mon, Apr 12, 2021 at 05:54:57PM +0800, Billy Tsai wrote: > Add support for the pwm controller which can be found at aspeed ast2600 > soc. This driver is part function of multi-funciton of device "pwm-tach > controller". please squash this into patch 3. > Signed-off-by: Billy Tsai <billy_tsai@aspeedtech.com> > --- > drivers/pwm/Kconfig | 6 ++++++ > drivers/pwm/Makefile | 1 + > 2 files changed, 7 insertions(+) > > diff --git a/drivers/pwm/Kconfig b/drivers/pwm/Kconfig > index 63be5362fd3a..947ed642debe 100644 > --- a/drivers/pwm/Kconfig > +++ b/drivers/pwm/Kconfig > @@ -42,6 +42,12 @@ config PWM_DEBUG > It is expected to introduce some runtime overhead and diagnostic > output to the kernel log, so only enable while working on a driver. > > +config PWM_ASPEED_G6 > + tristate "ASPEEDG6 PWM support" No depends? Best regards Uwe
Thanks for your review Best Regards, Billy Tsai On 2021/4/12, 7:14 PM,Uwe Kleine-Königwrote: >Hello, >On Mon, Apr 12, 2021 at 05:54:57PM +0800, Billy Tsai wrote: >> Add support for the pwm controller which can be found at aspeed ast2600 >> soc. This driver is part function of multi-funciton of device "pwm-tach >> controller". >please squash this into patch 3. OK, I will squash it when sending v2. >> Signed-off-by: Billy Tsai <billy_tsai@aspeedtech.com> >> --- >> drivers/pwm/Kconfig | 6 ++++++ >> drivers/pwm/Makefile | 1 + >> 2 files changed, 7 insertions(+) >> >> diff --git a/drivers/pwm/Kconfig b/drivers/pwm/Kconfig >> index 63be5362fd3a..947ed642debe 100644 >> --- a/drivers/pwm/Kconfig >> +++ b/drivers/pwm/Kconfig >> @@ -42,6 +42,12 @@ config PWM_DEBUG >> It is expected to introduce some runtime overhead and diagnostic >> output to the kernel log, so only enable while working on a driver. >> >> +config PWM_ASPEED_G6 >> + tristate "ASPEEDG6 PWM support" >No depends? I will add "depends on (ARCH_ASPEED || COMPILE_TEST)" for this configure. >Best regards >Uwe >-- >Pengutronix e.K. | Uwe Kleine-König | >Industrial Linux Solutions | https://www.pengutronix.de/ |
diff --git a/drivers/pwm/Kconfig b/drivers/pwm/Kconfig index 63be5362fd3a..947ed642debe 100644 --- a/drivers/pwm/Kconfig +++ b/drivers/pwm/Kconfig @@ -42,6 +42,12 @@ config PWM_DEBUG It is expected to introduce some runtime overhead and diagnostic output to the kernel log, so only enable while working on a driver. +config PWM_ASPEED_G6 + tristate "ASPEEDG6 PWM support" + help + This driver provides support for ASPEED G6 PWM controllers. + + config PWM_AB8500 tristate "AB8500 PWM support" depends on AB8500_CORE && ARCH_U8500 diff --git a/drivers/pwm/Makefile b/drivers/pwm/Makefile index cbdcd55d69ee..4a74c68547bf 100644 --- a/drivers/pwm/Makefile +++ b/drivers/pwm/Makefile @@ -1,6 +1,7 @@ # SPDX-License-Identifier: GPL-2.0 obj-$(CONFIG_PWM) += core.o obj-$(CONFIG_PWM_SYSFS) += sysfs.o +obj-$(CONFIG_PWM_ASPEED_G6) += pwm-aspeed-g6.o obj-$(CONFIG_PWM_AB8500) += pwm-ab8500.o obj-$(CONFIG_PWM_ATMEL) += pwm-atmel.o obj-$(CONFIG_PWM_ATMEL_HLCDC_PWM) += pwm-atmel-hlcdc.o
Add support for the pwm controller which can be found at aspeed ast2600 soc. This driver is part function of multi-funciton of device "pwm-tach controller". Signed-off-by: Billy Tsai <billy_tsai@aspeedtech.com> --- drivers/pwm/Kconfig | 6 ++++++ drivers/pwm/Makefile | 1 + 2 files changed, 7 insertions(+)