| Message ID | 20200517190139.740249-11-sam@ravnborg.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | backlight updates | expand |
On Sun, May 17, 2020 at 09:01:33PM +0200, Sam Ravnborg wrote: > No need to put "extern" in front of prototypes. > While touching the prototypes adjust indent to follow > the kernel style. > > Signed-off-by: Sam Ravnborg <sam@ravnborg.org> > Cc: Lee Jones <lee.jones@linaro.org> > Cc: Daniel Thompson <daniel.thompson@linaro.org> > Cc: Jingoo Han <jingoohan1@gmail.com> Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org> > --- > include/linux/backlight.h | 35 +++++++++++++++++++---------------- > 1 file changed, 19 insertions(+), 16 deletions(-) > > diff --git a/include/linux/backlight.h b/include/linux/backlight.h > index eae7a5e66248..308aec67fa4f 100644 > --- a/include/linux/backlight.h > +++ b/include/linux/backlight.h > @@ -444,22 +444,25 @@ static inline bool backlight_is_blank(struct backlight_device *bd) > bd->props.state & (BL_CORE_SUSPENDED | BL_CORE_FBBLANK); > } > > -extern struct backlight_device *backlight_device_register(const char *name, > - struct device *dev, void *devdata, const struct backlight_ops *ops, > - const struct backlight_properties *props); > -extern struct backlight_device *devm_backlight_device_register( > - struct device *dev, const char *name, struct device *parent, > - void *devdata, const struct backlight_ops *ops, > - const struct backlight_properties *props); > -extern void backlight_device_unregister(struct backlight_device *bd); > -extern void devm_backlight_device_unregister(struct device *dev, > - struct backlight_device *bd); > -extern void backlight_force_update(struct backlight_device *bd, > - enum backlight_update_reason reason); > -extern int backlight_register_notifier(struct notifier_block *nb); > -extern int backlight_unregister_notifier(struct notifier_block *nb); > -extern struct backlight_device *backlight_device_get_by_type(enum backlight_type type); > -extern int backlight_device_set_brightness(struct backlight_device *bd, unsigned long brightness); > +struct backlight_device * > +backlight_device_register(const char *name, struct device *dev, void *devdata, > + const struct backlight_ops *ops, > + const struct backlight_properties *props); > +struct backlight_device * > +devm_backlight_device_register(struct device *dev, const char *name, > + struct device *parent, void *devdata, > + const struct backlight_ops *ops, > + const struct backlight_properties *props); > +void backlight_device_unregister(struct backlight_device *bd); > +void devm_backlight_device_unregister(struct device *dev, > + struct backlight_device *bd); > +void backlight_force_update(struct backlight_device *bd, > + enum backlight_update_reason reason); > +int backlight_register_notifier(struct notifier_block *nb); > +int backlight_unregister_notifier(struct notifier_block *nb); > +struct backlight_device *backlight_device_get_by_type(enum backlight_type type); > +int backlight_device_set_brightness(struct backlight_device *bd, > + unsigned long brightness); > > #define to_backlight_device(obj) container_of(obj, struct backlight_device, dev) > > -- > 2.25.1 >
diff --git a/include/linux/backlight.h b/include/linux/backlight.h index eae7a5e66248..308aec67fa4f 100644 --- a/include/linux/backlight.h +++ b/include/linux/backlight.h @@ -444,22 +444,25 @@ static inline bool backlight_is_blank(struct backlight_device *bd) bd->props.state & (BL_CORE_SUSPENDED | BL_CORE_FBBLANK); } -extern struct backlight_device *backlight_device_register(const char *name, - struct device *dev, void *devdata, const struct backlight_ops *ops, - const struct backlight_properties *props); -extern struct backlight_device *devm_backlight_device_register( - struct device *dev, const char *name, struct device *parent, - void *devdata, const struct backlight_ops *ops, - const struct backlight_properties *props); -extern void backlight_device_unregister(struct backlight_device *bd); -extern void devm_backlight_device_unregister(struct device *dev, - struct backlight_device *bd); -extern void backlight_force_update(struct backlight_device *bd, - enum backlight_update_reason reason); -extern int backlight_register_notifier(struct notifier_block *nb); -extern int backlight_unregister_notifier(struct notifier_block *nb); -extern struct backlight_device *backlight_device_get_by_type(enum backlight_type type); -extern int backlight_device_set_brightness(struct backlight_device *bd, unsigned long brightness); +struct backlight_device * +backlight_device_register(const char *name, struct device *dev, void *devdata, + const struct backlight_ops *ops, + const struct backlight_properties *props); +struct backlight_device * +devm_backlight_device_register(struct device *dev, const char *name, + struct device *parent, void *devdata, + const struct backlight_ops *ops, + const struct backlight_properties *props); +void backlight_device_unregister(struct backlight_device *bd); +void devm_backlight_device_unregister(struct device *dev, + struct backlight_device *bd); +void backlight_force_update(struct backlight_device *bd, + enum backlight_update_reason reason); +int backlight_register_notifier(struct notifier_block *nb); +int backlight_unregister_notifier(struct notifier_block *nb); +struct backlight_device *backlight_device_get_by_type(enum backlight_type type); +int backlight_device_set_brightness(struct backlight_device *bd, + unsigned long brightness); #define to_backlight_device(obj) container_of(obj, struct backlight_device, dev)
No need to put "extern" in front of prototypes. While touching the prototypes adjust indent to follow the kernel style. Signed-off-by: Sam Ravnborg <sam@ravnborg.org> Cc: Lee Jones <lee.jones@linaro.org> Cc: Daniel Thompson <daniel.thompson@linaro.org> Cc: Jingoo Han <jingoohan1@gmail.com> --- include/linux/backlight.h | 35 +++++++++++++++++++---------------- 1 file changed, 19 insertions(+), 16 deletions(-)