Message ID | 1575352925-17271-1-git-send-email-peng.fan@nxp.com |
---|---|
State | Not Applicable |
Headers | show |
Series | [1/2] gpio: mvebu: use platform_irq_count | expand |
On Tue, Dec 3, 2019 at 7:04 AM Peng Fan <peng.fan@nxp.com> wrote: > From: Peng Fan <peng.fan@nxp.com> > > Use platform_irq_count to replace of_irq_count > > Signed-off-by: Peng Fan <peng.fan@nxp.com> > --- > > V1: > Code inspection, not tested Patch applied. Yours, Linus Walleij
On Thu, Dec 12, 2019 at 4:29 PM Linus Walleij <linus.walleij@linaro.org> wrote: > > On Tue, Dec 3, 2019 at 7:04 AM Peng Fan <peng.fan@nxp.com> wrote: > > > From: Peng Fan <peng.fan@nxp.com> > > > > Use platform_irq_count to replace of_irq_count > > > > Signed-off-by: Peng Fan <peng.fan@nxp.com> > > --- > > > > V1: > > Code inspection, not tested > > Patch applied. Oops dropped again now that I see there are comments on 2/2 that warrants a v2 of this as well. Yours, Linus Walleij
czw., 12 gru 2019 o 16:31 Linus Walleij <linus.walleij@linaro.org> napisaĆ(a): > > On Thu, Dec 12, 2019 at 4:29 PM Linus Walleij <linus.walleij@linaro.org> wrote: > > > > On Tue, Dec 3, 2019 at 7:04 AM Peng Fan <peng.fan@nxp.com> wrote: > > > > > From: Peng Fan <peng.fan@nxp.com> > > > > > > Use platform_irq_count to replace of_irq_count > > > > > > Signed-off-by: Peng Fan <peng.fan@nxp.com> > > > --- > > > > > > V1: > > > Code inspection, not tested > > > > Patch applied. > > Oops dropped again now that I see there are comments on > 2/2 that warrants a v2 of this as well. > > Yours, > Linus Walleij Linus, FYI I picked up v3 of this series into my tree. Bart
diff --git a/drivers/gpio/gpio-mvebu.c b/drivers/gpio/gpio-mvebu.c index 993bbeb3c006..ecfedcdadc0d 100644 --- a/drivers/gpio/gpio-mvebu.c +++ b/drivers/gpio/gpio-mvebu.c @@ -46,7 +46,6 @@ #include <linux/irqdomain.h> #include <linux/mfd/syscon.h> #include <linux/of_device.h> -#include <linux/of_irq.h> #include <linux/pinctrl/consumer.h> #include <linux/platform_device.h> #include <linux/pwm.h> @@ -1102,7 +1101,7 @@ static int mvebu_gpio_probe(struct platform_device *pdev) soc_variant = MVEBU_GPIO_SOC_VARIANT_ORION; /* Some gpio controllers do not provide irq support */ - have_irqs = of_irq_count(np) != 0; + have_irqs = platform_irq_count(pdev) != 0; mvchip = devm_kzalloc(&pdev->dev, sizeof(struct mvebu_gpio_chip), GFP_KERNEL);