mbox series

[v3,0/6] pwm: pxa: Fixes for enable/disable transitions

Message ID 20221113233639.24244-1-doug@schmorgal.com
Headers show
Series pwm: pxa: Fixes for enable/disable transitions | expand

Message

Doug Brown Nov. 13, 2022, 11:36 p.m. UTC 
I ran into a couple of problems while getting this driver working on the
PXA168. It wouldn't always activate properly when I turned it on, and it
wouldn't always deactivate properly when I turned it off. These patches
fix issues with the clock enable/disable transitions.

With these patches applied, the driver works flawlessly with my use
cases on the PXA168. I don't have any other PXAxxx devices to test with.

Changes in v3:

- Switch to abrupt shutdown mode instead of the delay hack from v2.
- Fix commit message explaining why duty cycle is set to 0.
- Add documentation link and limitations section at top of file.

Changes in v2:

- Remove pxa_pwm_enable and pxa_pwm_disable.
- Reorganize pxa_pwm_apply based on Uwe's suggestions.
- Enable this driver with ARCH_MMP for the PXA168.
- Add delay after clock is disabled (and inhibit brief on/off blips).

Doug Brown (6):
  pwm: pxa: Remove pxa_pwm_enable/disable
  pwm: pxa: Set duty cycle to 0 when disabling PWM
  pwm: pxa: Remove clk enable/disable from pxa_pwm_config
  pwm: pxa: Use abrupt shutdown mode
  pwm: pxa: Add reference manual link and limitations
  pwm: pxa: Enable for MMP platform

 drivers/pwm/Kconfig   |  2 +-
 drivers/pwm/pwm-pxa.c | 58 +++++++++++++++++++------------------------
 2 files changed, 26 insertions(+), 34 deletions(-)