Message ID | 9efd4af2f91e1be2b65d2df93444b35871673e8b.1524062073.git.gustavo.pimentel@synopsys.com |
---|---|
State | Superseded |
Delegated to: | Lorenzo Pieralisi |
Headers | show |
Series | Designware EP support and code clean up | expand |
On Wednesday 18 April 2018 08:16 PM, Gustavo Pimentel wrote: > Adds a seconds entry on the pci_epf_test_ids structure that disables the > linkup_notifier parameter on driver for the designware EP. > > This allows designware EPs that doesn't have linkup notification signal > to work with pcitest. > > Updates the binding documentation accordingly. > > Signed-off-by: Gustavo Pimentel <gustavo.pimentel@synopsys.com> > --- > Change v2->v3: > - Added second entry in pci_epf_test_ids structure. > - Remove test_reg_bar field assignment on second entry. > Changes v3->v4: > - Nothing changed, just to follow the patch set version. > Changes v4->v5: > - Changed pci_epf_test_cfg2 to pci_epf_test_designware. > Changes v5->v6: > - Changed name field from pci_epf_test_designware to pci_epf_test_dw. > > Documentation/PCI/endpoint/function/binding/pci-test.txt | 2 ++ > drivers/pci/endpoint/functions/pci-epf-test.c | 8 ++++++++ > 2 files changed, 10 insertions(+) > > diff --git a/Documentation/PCI/endpoint/function/binding/pci-test.txt b/Documentation/PCI/endpoint/function/binding/pci-test.txt > index 3b68b95..dc39f47 100644 > --- a/Documentation/PCI/endpoint/function/binding/pci-test.txt > +++ b/Documentation/PCI/endpoint/function/binding/pci-test.txt > @@ -1,6 +1,8 @@ > PCI TEST ENDPOINT FUNCTION > > name: Should be "pci_epf_test" to bind to the pci_epf_test driver. > +name: Should be "pci_epf_test_dw" to bind to the pci_epf_test driver > + with a custom configuration for the designware EP. > > Configurable Fields: > vendorid : should be 0x104c > diff --git a/drivers/pci/endpoint/functions/pci-epf-test.c b/drivers/pci/endpoint/functions/pci-epf-test.c > index 7cef851..b7dff87 100644 > --- a/drivers/pci/endpoint/functions/pci-epf-test.c > +++ b/drivers/pci/endpoint/functions/pci-epf-test.c > @@ -459,10 +459,18 @@ static int pci_epf_test_bind(struct pci_epf *epf) > return 0; > } > > +static const struct pci_epf_test_data data_cfg2 = { Would prefer a descriptive name, otherwise Acked-by: Kishon Vijay Abraham I <kishon@ti.com> > + .linkup_notifier = false > +}; > + > static const struct pci_epf_device_id pci_epf_test_ids[] = { > { > .name = "pci_epf_test", > }, > + { > + .name = "pci_epf_test_dw", > + .driver_data = (kernel_ulong_t)&data_cfg2, > + }, > {}, > }; > >
diff --git a/Documentation/PCI/endpoint/function/binding/pci-test.txt b/Documentation/PCI/endpoint/function/binding/pci-test.txt index 3b68b95..dc39f47 100644 --- a/Documentation/PCI/endpoint/function/binding/pci-test.txt +++ b/Documentation/PCI/endpoint/function/binding/pci-test.txt @@ -1,6 +1,8 @@ PCI TEST ENDPOINT FUNCTION name: Should be "pci_epf_test" to bind to the pci_epf_test driver. +name: Should be "pci_epf_test_dw" to bind to the pci_epf_test driver + with a custom configuration for the designware EP. Configurable Fields: vendorid : should be 0x104c diff --git a/drivers/pci/endpoint/functions/pci-epf-test.c b/drivers/pci/endpoint/functions/pci-epf-test.c index 7cef851..b7dff87 100644 --- a/drivers/pci/endpoint/functions/pci-epf-test.c +++ b/drivers/pci/endpoint/functions/pci-epf-test.c @@ -459,10 +459,18 @@ static int pci_epf_test_bind(struct pci_epf *epf) return 0; } +static const struct pci_epf_test_data data_cfg2 = { + .linkup_notifier = false +}; + static const struct pci_epf_device_id pci_epf_test_ids[] = { { .name = "pci_epf_test", }, + { + .name = "pci_epf_test_dw", + .driver_data = (kernel_ulong_t)&data_cfg2, + }, {}, };
Adds a seconds entry on the pci_epf_test_ids structure that disables the linkup_notifier parameter on driver for the designware EP. This allows designware EPs that doesn't have linkup notification signal to work with pcitest. Updates the binding documentation accordingly. Signed-off-by: Gustavo Pimentel <gustavo.pimentel@synopsys.com> --- Change v2->v3: - Added second entry in pci_epf_test_ids structure. - Remove test_reg_bar field assignment on second entry. Changes v3->v4: - Nothing changed, just to follow the patch set version. Changes v4->v5: - Changed pci_epf_test_cfg2 to pci_epf_test_designware. Changes v5->v6: - Changed name field from pci_epf_test_designware to pci_epf_test_dw. Documentation/PCI/endpoint/function/binding/pci-test.txt | 2 ++ drivers/pci/endpoint/functions/pci-epf-test.c | 8 ++++++++ 2 files changed, 10 insertions(+)