| Message ID | b40565c78ff809a9b273a1915ea9be37514f7e2e.1535044690.git.jan.kundrat@cesnet.cz |
|---|---|
| State | Superseded |
| Headers | show |
| Series | i2c: bitbang: make the error message grepable | expand |
Hi Jan, thanks for the patch! On Thu, Aug 23, 2018 at 07:12:00PM +0200, Jan Kundrát wrote: > Yep, I went looking for this one, and I wasn't able to find it easily. > That's worse than a line which is 82-chars long, IMHO. I agree. Having one patch per fixed message seems excessive, though. Would you maybe be interested in fixing the other strings, too? Kind regards, Wolfram
diff --git a/drivers/i2c/algos/i2c-algo-bit.c b/drivers/i2c/algos/i2c-algo-bit.c index 6ec65adaba49..38fe80934f86 100644 --- a/drivers/i2c/algos/i2c-algo-bit.c +++ b/drivers/i2c/algos/i2c-algo-bit.c @@ -442,8 +442,9 @@ static int readbytes(struct i2c_adapter *i2c_adap, struct i2c_msg *msg) if (inval <= 0 || inval > I2C_SMBUS_BLOCK_MAX) { if (!(flags & I2C_M_NO_RD_ACK)) acknak(i2c_adap, 0); - dev_err(&i2c_adap->dev, "readbytes: invalid " - "block length (%d)\n", inval); + dev_err(&i2c_adap->dev, + "readbytes: invalid block length (%d)\n", + inval); return -EPROTO; } /* The original count value accounts for the extra
Yep, I went looking for this one, and I wasn't able to find it easily. That's worse than a line which is 82-chars long, IMHO. Signed-off-by: Jan Kundrát <jan.kundrat@cesnet.cz> --- drivers/i2c/algos/i2c-algo-bit.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)