diff mbox

i2c: fix device_node_continue.cocci warnings

Message ID alpine.DEB.2.10.1609191146130.3203@hadrien
State Not Applicable
Headers show

Commit Message

Julia Lawall Sept. 19, 2016, 9:47 a.m. UTC 
Device node iterators put the previous value of the index variable, so an
 explicit put causes a double put.

Generated by: scripts/coccinelle/iterators/device_node_continue.cocci

Signed-off-by: Julia Lawall <julia.lawall@lip6.fr>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---

Please take the patch only if it's a positive warning. Thanks!

I haven't checked anything more that what is shown in the patch.

julia

 i2c-aspeed.c |    1 -
 1 file changed, 1 deletion(-)

--
To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

--- a/drivers/i2c/busses/i2c-aspeed.c
+++ b/drivers/i2c/busses/i2c-aspeed.c
@@ -862,7 +862,6 @@  static int ast_i2c_probe_controller(stru
 			continue;

 		of_platform_device_create(np, bus_id, &pdev->dev);
-		of_node_put(np);
 	}

 	return 0;