| Message ID | E1c7p12-0000R0-S8@rmk-PC.armlinux.org.uk |
|---|---|
| State | Accepted |
| Headers | show |
On Fri, Nov 18, 2016 at 07:40:04PM +0000, Russell King wrote: > Rather than reporting success for a short transfer due to interrupt > latency, report an error both to the caller, as well as to the kernel > log. > > Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk> Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com> -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 21.11.2016 12:32, Mika Westerberg wrote: > On Fri, Nov 18, 2016 at 07:40:04PM +0000, Russell King wrote: >> Rather than reporting success for a short transfer due to interrupt >> latency, report an error both to the caller, as well as to the kernel >> log. >> >> Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk> > > Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com> > Acked-by: Jarkko Nikula <jarkko.nikula@linux.intel.com> -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, Nov 18, 2016 at 07:40:04PM +0000, Russell King wrote: > Rather than reporting success for a short transfer due to interrupt > latency, report an error both to the caller, as well as to the kernel > log. > > Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk> Applied to for-current, thanks!
diff --git a/drivers/i2c/busses/i2c-designware-core.c b/drivers/i2c/busses/i2c-designware-core.c index 9703fe392543..c53058d6139c 100644 --- a/drivers/i2c/busses/i2c-designware-core.c +++ b/drivers/i2c/busses/i2c-designware-core.c @@ -758,7 +758,7 @@ i2c_dw_xfer(struct i2c_adapter *adap, struct i2c_msg msgs[], int num) } /* no error */ - if (likely(!dev->cmd_err)) { + if (likely(!dev->cmd_err && !dev->status)) { ret = num; goto done; } @@ -768,6 +768,11 @@ i2c_dw_xfer(struct i2c_adapter *adap, struct i2c_msg msgs[], int num) ret = i2c_dw_handle_tx_abort(dev); goto done; } + + if (dev->status) + dev_err(dev->dev, + "transfer terminated early - interrupt latency too high?\n"); + ret = -EIO; done:
Rather than reporting success for a short transfer due to interrupt latency, report an error both to the caller, as well as to the kernel log. Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk> --- drivers/i2c/busses/i2c-designware-core.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-)