diff mbox

[v2] dts: keystone: Use new "ti,keystone-i2c" compatible

Message ID 55F68E36.2030609@nokia.com
State Awaiting Upstream
Headers show

Commit Message

Alexander A Sverdlin Sept. 14, 2015, 9:07 a.m. UTC
Now as "i2c-davinci" driver has special handling for Keystone it's time to switch
the device tree to use new "compatible" property. Old one is left for backwards-
compatibility.

Signed-off-by: Alexander Sverdlin <alexander.sverdlin@nokia.com>
---

Changes in v2:
- As suggested by Mark Rutland, kept the old "compatible" for backwards-
  compatibility

 arch/arm/boot/dts/keystone.dtsi |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

--
To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Wolfram Sang Oct. 20, 2015, 3:06 p.m. UTC | #1
On Mon, Sep 14, 2015 at 11:07:02AM +0200, Alexander Sverdlin wrote:
> Now as "i2c-davinci" driver has special handling for Keystone it's time to switch
> the device tree to use new "compatible" property. Old one is left for backwards-
> compatibility.
> 
> Signed-off-by: Alexander Sverdlin <alexander.sverdlin@nokia.com>

Shall I take this one or shall it go via the davinci tree?
Grygorii Strashko Oct. 20, 2015, 4:10 p.m. UTC | #2
On 10/20/2015 06:06 PM, Wolfram Sang wrote:
> On Mon, Sep 14, 2015 at 11:07:02AM +0200, Alexander Sverdlin wrote:
>> Now as "i2c-davinci" driver has special handling for Keystone it's time to switch
>> the device tree to use new "compatible" property. Old one is left for backwards-
>> compatibility.
>>
>> Signed-off-by: Alexander Sverdlin <alexander.sverdlin@nokia.com>
>
> Shall I take this one or shall it go via the davinci tree?
>

To: Sekhar
Sekhar Nori Oct. 21, 2015, 10:13 a.m. UTC | #3
On Tuesday 20 October 2015 09:40 PM, Grygorii Strashko wrote:
> On 10/20/2015 06:06 PM, Wolfram Sang wrote:
>> On Mon, Sep 14, 2015 at 11:07:02AM +0200, Alexander Sverdlin wrote:
>>> Now as "i2c-davinci" driver has special handling for Keystone it's
>>> time to switch
>>> the device tree to use new "compatible" property. Old one is left for
>>> backwards-
>>> compatibility.
>>>
>>> Signed-off-by: Alexander Sverdlin <alexander.sverdlin@nokia.com>
>>
>> Shall I take this one or shall it go via the davinci tree?

I don't have the patch in my mailbox now. But as I remember this is a
driver only patch and should go via i2c tree.

Thanks,
Sekhar

--
To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Grygorii Strashko Oct. 21, 2015, 10:38 a.m. UTC | #4
On 09/14/2015 12:07 PM, Alexander Sverdlin wrote:
> Now as "i2c-davinci" driver has special handling for Keystone it's time to switch
> the device tree to use new "compatible" property. Old one is left for backwards-
> compatibility.
>
> Signed-off-by: Alexander Sverdlin <alexander.sverdlin@nokia.com>
> ---

To: Santosh
Cc: Murali, Sekhar

Seems this patch is Keystone 2 specific.

>
> Changes in v2:
> - As suggested by Mark Rutland, kept the old "compatible" for backwards-
>    compatibility
>
>   arch/arm/boot/dts/keystone.dtsi |    6 +++---
>   1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm/boot/dts/keystone.dtsi b/arch/arm/boot/dts/keystone.dtsi
> index 72816d6..abd7455 100644
> --- a/arch/arm/boot/dts/keystone.dtsi
> +++ b/arch/arm/boot/dts/keystone.dtsi
> @@ -106,7 +106,7 @@
>   		};
>
>   		i2c0: i2c@2530000 {
> -			compatible = "ti,davinci-i2c";
> +			compatible = "ti,keystone-i2c", "ti,davinci-i2c";
>   			reg = <0x02530000 0x400>;
>   			clock-frequency = <100000>;
>   			clocks = <&clki2c>;
> @@ -116,7 +116,7 @@
>   		};
>
>   		i2c1: i2c@2530400 {
> -			compatible = "ti,davinci-i2c";
> +			compatible = "ti,keystone-i2c", "ti,davinci-i2c";
>   			reg = <0x02530400 0x400>;
>   			clock-frequency = <100000>;
>   			clocks = <&clki2c>;
> @@ -126,7 +126,7 @@
>   		};
>
>   		i2c2: i2c@2530800 {
> -			compatible = "ti,davinci-i2c";
> +			compatible = "ti,keystone-i2c", "ti,davinci-i2c";
>   			reg = <0x02530800 0x400>;
>   			clock-frequency = <100000>;
>   			clocks = <&clki2c>;
>
Alexander A Sverdlin Oct. 21, 2015, 11:33 a.m. UTC | #5
Hi!

On 21/10/15 12:13, EXT Sekhar Nori wrote:
>>>> Now as "i2c-davinci" driver has special handling for Keystone it's
>>>> >>> time to switch
>>>> >>> the device tree to use new "compatible" property. Old one is left for
>>>> >>> backwards-
>>>> >>> compatibility.
>>>> >>>
>>>> >>> Signed-off-by: Alexander Sverdlin <alexander.sverdlin@nokia.com>
>>> >>
>>> >> Shall I take this one or shall it go via the davinci tree?
> I don't have the patch in my mailbox now. But as I remember this is a

You can review it here:
http://patchwork.ozlabs.org/patch/517321/

> driver only patch and should go via i2c tree.

It's a DT change, because we agreed (with Grygorii) that new "compatible" is more
future proof.
Santosh Shilimkar Oct. 21, 2015, 4:42 p.m. UTC | #6
On 10/21/15 3:38 AM, Grygorii Strashko wrote:
> On 09/14/2015 12:07 PM, Alexander Sverdlin wrote:
>> Now as "i2c-davinci" driver has special handling for Keystone it's
>> time to switch
>> the device tree to use new "compatible" property. Old one is left for
>> backwards-
>> compatibility.
>>
>> Signed-off-by: Alexander Sverdlin <alexander.sverdlin@nokia.com>
>> ---
>
Will pick it up. Thanks !!

Regards,
Santosh

--
To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/arch/arm/boot/dts/keystone.dtsi b/arch/arm/boot/dts/keystone.dtsi
index 72816d6..abd7455 100644
--- a/arch/arm/boot/dts/keystone.dtsi
+++ b/arch/arm/boot/dts/keystone.dtsi
@@ -106,7 +106,7 @@ 
 		};
 
 		i2c0: i2c@2530000 {
-			compatible = "ti,davinci-i2c";
+			compatible = "ti,keystone-i2c", "ti,davinci-i2c";
 			reg = <0x02530000 0x400>;
 			clock-frequency = <100000>;
 			clocks = <&clki2c>;
@@ -116,7 +116,7 @@ 
 		};
 
 		i2c1: i2c@2530400 {
-			compatible = "ti,davinci-i2c";
+			compatible = "ti,keystone-i2c", "ti,davinci-i2c";
 			reg = <0x02530400 0x400>;
 			clock-frequency = <100000>;
 			clocks = <&clki2c>;
@@ -126,7 +126,7 @@ 
 		};
 
 		i2c2: i2c@2530800 {
-			compatible = "ti,davinci-i2c";
+			compatible = "ti,keystone-i2c", "ti,davinci-i2c";
 			reg = <0x02530800 0x400>;
 			clock-frequency = <100000>;
 			clocks = <&clki2c>;