| Message ID | 20240305165652.18842-1-harry021633@gmail.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | i2c: remove redundant condition | expand |
Hi Hsin-Yu, On Wed, Mar 06, 2024 at 12:56:52AM +0800, Hsin-Yu.Chen wrote: > I2C_M_RD is defined as 1 and `flag & I2C_M_RD` is one or zero > no need one more condition to get the value this can be written a bit better as: /no need one more/no need for an additional/ > Signed-off-by: Hsin-Yu.Chen <harry021633@gmail.com> anyway: Reviewed-by: Andi Shyti <andi.shyti@kernel.org> Thanks, Andi > --- > include/linux/i2c.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/linux/i2c.h b/include/linux/i2c.h > index 652ecb7abeda..363dde9ef94f 100644 > --- a/include/linux/i2c.h > +++ b/include/linux/i2c.h > @@ -931,7 +931,7 @@ static inline int i2c_adapter_id(struct i2c_adapter *adap) > > static inline u8 i2c_8bit_addr_from_msg(const struct i2c_msg *msg) > { > - return (msg->addr << 1) | (msg->flags & I2C_M_RD ? 1 : 0); > + return (msg->addr << 1) | (msg->flags & I2C_M_RD); > } > > u8 *i2c_get_dma_safe_msg_buf(struct i2c_msg *msg, unsigned int threshold); > -- > 2.38.1 >
diff --git a/include/linux/i2c.h b/include/linux/i2c.h index 652ecb7abeda..363dde9ef94f 100644 --- a/include/linux/i2c.h +++ b/include/linux/i2c.h @@ -931,7 +931,7 @@ static inline int i2c_adapter_id(struct i2c_adapter *adap) static inline u8 i2c_8bit_addr_from_msg(const struct i2c_msg *msg) { - return (msg->addr << 1) | (msg->flags & I2C_M_RD ? 1 : 0); + return (msg->addr << 1) | (msg->flags & I2C_M_RD); } u8 *i2c_get_dma_safe_msg_buf(struct i2c_msg *msg, unsigned int threshold);
I2C_M_RD is defined as 1 and `flag & I2C_M_RD` is one or zero no need one more condition to get the value Signed-off-by: Hsin-Yu.Chen <harry021633@gmail.com> --- include/linux/i2c.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)