| Message ID | 20240224115050.3199-1-harry021633@gmail.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | i2c: remove redundant condition | expand |
On Sat, Feb 24, 2024 at 07:50:50PM +0800, zoanana990 wrote: > I2C_M_RD is defined as 1, "flag & I2C_M_RD" is 1 or 0 > One more condition does not need to be met to obtain the value > > Signed-off-by: zoanana990 <harry021633@gmail.com> From 'Documentation/process/1.Intro.rst': It is imperative that all code contributed to the kernel be legitimately free software. For that reason, code from anonymous (or pseudonymous) contributors will not be accepted. All contributors are required to "sign ... Please sign off with your real name.
diff --git a/include/linux/i2c.h b/include/linux/i2c.h index 652ecb7abeda..363dde9ef94f 100644 --- a/include/linux/i2c.h +++ b/include/linux/i2c.h @@ -931,7 +931,7 @@ static inline int i2c_adapter_id(struct i2c_adapter *adap) static inline u8 i2c_8bit_addr_from_msg(const struct i2c_msg *msg) { - return (msg->addr << 1) | (msg->flags & I2C_M_RD ? 1 : 0); + return (msg->addr << 1) | (msg->flags & I2C_M_RD); } u8 *i2c_get_dma_safe_msg_buf(struct i2c_msg *msg, unsigned int threshold);
I2C_M_RD is defined as 1, "flag & I2C_M_RD" is 1 or 0 One more condition does not need to be met to obtain the value Signed-off-by: zoanana990 <harry021633@gmail.com> --- include/linux/i2c.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)