Message ID | 20220629060952.4749-1-xupengfei@nfschina.com |
---|---|
State | Changes Requested |
Headers | show |
Series | [1/1] drivers: remove unnecessary (void*) conversions. | expand |
On Wed, Jun 29, 2022 at 02:09:52PM +0800, XU pengfei wrote: > remove unnecessary void* type casting. > > Signed-off-by: XU pengfei <xupengfei@nfschina.com> Correct, but $subject really needs to contain the subsystem and the driver. "drivers:" is way too generic. Check 'git log' to see how subsystems prefer their $subjects.
diff --git a/drivers/i2c/busses/i2c-img-scb.c b/drivers/i2c/busses/i2c-img-scb.c index 8e987945ed45..d72211cfda03 100644 --- a/drivers/i2c/busses/i2c-img-scb.c +++ b/drivers/i2c/busses/i2c-img-scb.c @@ -913,7 +913,7 @@ static unsigned int img_i2c_auto(struct img_i2c *i2c, static irqreturn_t img_i2c_isr(int irq, void *dev_id) { - struct img_i2c *i2c = (struct img_i2c *)dev_id; + struct img_i2c *i2c = dev_id; u32 int_status, line_status; /* We handle transaction completion AFTER accessing registers */ unsigned int hret;
remove unnecessary void* type casting. Signed-off-by: XU pengfei <xupengfei@nfschina.com> --- drivers/i2c/busses/i2c-img-scb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)