| Message ID | 20220303191713.2402461-1-nathan@kernel.org |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [-next] i2c: designware: Mark dw_i2c_plat_{suspend,resume}() as __maybe_unused | expand |
Hi, On 3/3/22 20:17, Nathan Chancellor wrote: > When CONFIG_PM is set but CONFIG_PM_SLEEP is not, two compiler warnings > appear: > > drivers/i2c/busses/i2c-designware-platdrv.c:444:12: error: unused function 'dw_i2c_plat_suspend' [-Werror,-Wunused-function] > static int dw_i2c_plat_suspend(struct device *dev) > ^ > drivers/i2c/busses/i2c-designware-platdrv.c:465:12: error: unused function 'dw_i2c_plat_resume' [-Werror,-Wunused-function] > static int dw_i2c_plat_resume(struct device *dev) > ^ > 2 errors generated. > > These functions are only used in SET_LATE_SYSTEM_SLEEP_PM_OPS(), which > is defined as empty when CONFIG_PM_SLEEP is not defined. Mark the > functions as __maybe_unused to make it clear that these functions might > be unused in this configuration. > > Fixes: c57813b8b288 ("i2c: designware: Lock the adapter while setting the suspended flag") > Signed-off-by: Nathan Chancellor <nathan@kernel.org> Thanks, patch looks good to me: Reviewed-by: Hans de Goede <hdegoede@redhat.com> Regards, Hans > --- > drivers/i2c/busses/i2c-designware-platdrv.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/i2c/busses/i2c-designware-platdrv.c b/drivers/i2c/busses/i2c-designware-platdrv.c > index 116a297d1f6b..70ade5306e45 100644 > --- a/drivers/i2c/busses/i2c-designware-platdrv.c > +++ b/drivers/i2c/busses/i2c-designware-platdrv.c > @@ -441,7 +441,7 @@ static int dw_i2c_plat_runtime_suspend(struct device *dev) > return 0; > } > > -static int dw_i2c_plat_suspend(struct device *dev) > +static int __maybe_unused dw_i2c_plat_suspend(struct device *dev) > { > struct dw_i2c_dev *i_dev = dev_get_drvdata(dev); > > @@ -462,7 +462,7 @@ static int dw_i2c_plat_runtime_resume(struct device *dev) > return 0; > } > > -static int dw_i2c_plat_resume(struct device *dev) > +static int __maybe_unused dw_i2c_plat_resume(struct device *dev) > { > struct dw_i2c_dev *i_dev = dev_get_drvdata(dev); > > > base-commit: 1d366c2f9df8279df2adbb60471f86fc40a1c39e
On Thu, Mar 03, 2022 at 12:17:13PM -0700, Nathan Chancellor wrote: > When CONFIG_PM is set but CONFIG_PM_SLEEP is not, two compiler warnings > appear: > > drivers/i2c/busses/i2c-designware-platdrv.c:444:12: error: unused function 'dw_i2c_plat_suspend' [-Werror,-Wunused-function] > static int dw_i2c_plat_suspend(struct device *dev) > ^ > drivers/i2c/busses/i2c-designware-platdrv.c:465:12: error: unused function 'dw_i2c_plat_resume' [-Werror,-Wunused-function] > static int dw_i2c_plat_resume(struct device *dev) > ^ > 2 errors generated. > > These functions are only used in SET_LATE_SYSTEM_SLEEP_PM_OPS(), which > is defined as empty when CONFIG_PM_SLEEP is not defined. Mark the > functions as __maybe_unused to make it clear that these functions might > be unused in this configuration. Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Thanks! > Fixes: c57813b8b288 ("i2c: designware: Lock the adapter while setting the suspended flag") > Signed-off-by: Nathan Chancellor <nathan@kernel.org> > --- > drivers/i2c/busses/i2c-designware-platdrv.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/i2c/busses/i2c-designware-platdrv.c b/drivers/i2c/busses/i2c-designware-platdrv.c > index 116a297d1f6b..70ade5306e45 100644 > --- a/drivers/i2c/busses/i2c-designware-platdrv.c > +++ b/drivers/i2c/busses/i2c-designware-platdrv.c > @@ -441,7 +441,7 @@ static int dw_i2c_plat_runtime_suspend(struct device *dev) > return 0; > } > > -static int dw_i2c_plat_suspend(struct device *dev) > +static int __maybe_unused dw_i2c_plat_suspend(struct device *dev) > { > struct dw_i2c_dev *i_dev = dev_get_drvdata(dev); > > @@ -462,7 +462,7 @@ static int dw_i2c_plat_runtime_resume(struct device *dev) > return 0; > } > > -static int dw_i2c_plat_resume(struct device *dev) > +static int __maybe_unused dw_i2c_plat_resume(struct device *dev) > { > struct dw_i2c_dev *i_dev = dev_get_drvdata(dev); > > > base-commit: 1d366c2f9df8279df2adbb60471f86fc40a1c39e > -- > 2.35.1 >
On 3/4/22 13:46, Hans de Goede wrote: > Hi, > > On 3/3/22 20:17, Nathan Chancellor wrote: >> When CONFIG_PM is set but CONFIG_PM_SLEEP is not, two compiler warnings >> appear: >> >> drivers/i2c/busses/i2c-designware-platdrv.c:444:12: error: unused function 'dw_i2c_plat_suspend' [-Werror,-Wunused-function] >> static int dw_i2c_plat_suspend(struct device *dev) >> ^ >> drivers/i2c/busses/i2c-designware-platdrv.c:465:12: error: unused function 'dw_i2c_plat_resume' [-Werror,-Wunused-function] >> static int dw_i2c_plat_resume(struct device *dev) >> ^ >> 2 errors generated. >> >> These functions are only used in SET_LATE_SYSTEM_SLEEP_PM_OPS(), which >> is defined as empty when CONFIG_PM_SLEEP is not defined. Mark the >> functions as __maybe_unused to make it clear that these functions might >> be unused in this configuration. >> >> Fixes: c57813b8b288 ("i2c: designware: Lock the adapter while setting the suspended flag") >> Signed-off-by: Nathan Chancellor <nathan@kernel.org> > > Thanks, patch looks good to me: > > Reviewed-by: Hans de Goede <hdegoede@redhat.com> > Acked-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
On Thu, 3 Mar 2022, Nathan Chancellor wrote: > When CONFIG_PM is set but CONFIG_PM_SLEEP is not, two compiler warnings > appear: > > drivers/i2c/busses/i2c-designware-platdrv.c:444:12: error: unused function 'dw_i2c_plat_suspend' [-Werror,-Wunused-function] > static int dw_i2c_plat_suspend(struct device *dev) > ^ > drivers/i2c/busses/i2c-designware-platdrv.c:465:12: error: unused function 'dw_i2c_plat_resume' [-Werror,-Wunused-function] > static int dw_i2c_plat_resume(struct device *dev) > ^ > 2 errors generated. > > These functions are only used in SET_LATE_SYSTEM_SLEEP_PM_OPS(), which > is defined as empty when CONFIG_PM_SLEEP is not defined. Mark the > functions as __maybe_unused to make it clear that these functions might > be unused in this configuration. > > Fixes: c57813b8b288 ("i2c: designware: Lock the adapter while setting the suspended flag") > Signed-off-by: Nathan Chancellor <nathan@kernel.org> As I just ran into this myself... Acked-by: Geert Uytterhoeven <geert+renesas@glider.be> Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
On Thu, Mar 03, 2022 at 12:17:13PM -0700, Nathan Chancellor wrote: > When CONFIG_PM is set but CONFIG_PM_SLEEP is not, two compiler warnings > appear: > > drivers/i2c/busses/i2c-designware-platdrv.c:444:12: error: unused function 'dw_i2c_plat_suspend' [-Werror,-Wunused-function] > static int dw_i2c_plat_suspend(struct device *dev) > ^ > drivers/i2c/busses/i2c-designware-platdrv.c:465:12: error: unused function 'dw_i2c_plat_resume' [-Werror,-Wunused-function] > static int dw_i2c_plat_resume(struct device *dev) > ^ > 2 errors generated. > > These functions are only used in SET_LATE_SYSTEM_SLEEP_PM_OPS(), which > is defined as empty when CONFIG_PM_SLEEP is not defined. Mark the > functions as __maybe_unused to make it clear that these functions might > be unused in this configuration. > > Fixes: c57813b8b288 ("i2c: designware: Lock the adapter while setting the suspended flag") > Signed-off-by: Nathan Chancellor <nathan@kernel.org> Applied to for-next, thanks!
diff --git a/drivers/i2c/busses/i2c-designware-platdrv.c b/drivers/i2c/busses/i2c-designware-platdrv.c index 116a297d1f6b..70ade5306e45 100644 --- a/drivers/i2c/busses/i2c-designware-platdrv.c +++ b/drivers/i2c/busses/i2c-designware-platdrv.c @@ -441,7 +441,7 @@ static int dw_i2c_plat_runtime_suspend(struct device *dev) return 0; } -static int dw_i2c_plat_suspend(struct device *dev) +static int __maybe_unused dw_i2c_plat_suspend(struct device *dev) { struct dw_i2c_dev *i_dev = dev_get_drvdata(dev); @@ -462,7 +462,7 @@ static int dw_i2c_plat_runtime_resume(struct device *dev) return 0; } -static int dw_i2c_plat_resume(struct device *dev) +static int __maybe_unused dw_i2c_plat_resume(struct device *dev) { struct dw_i2c_dev *i_dev = dev_get_drvdata(dev);
When CONFIG_PM is set but CONFIG_PM_SLEEP is not, two compiler warnings appear: drivers/i2c/busses/i2c-designware-platdrv.c:444:12: error: unused function 'dw_i2c_plat_suspend' [-Werror,-Wunused-function] static int dw_i2c_plat_suspend(struct device *dev) ^ drivers/i2c/busses/i2c-designware-platdrv.c:465:12: error: unused function 'dw_i2c_plat_resume' [-Werror,-Wunused-function] static int dw_i2c_plat_resume(struct device *dev) ^ 2 errors generated. These functions are only used in SET_LATE_SYSTEM_SLEEP_PM_OPS(), which is defined as empty when CONFIG_PM_SLEEP is not defined. Mark the functions as __maybe_unused to make it clear that these functions might be unused in this configuration. Fixes: c57813b8b288 ("i2c: designware: Lock the adapter while setting the suspended flag") Signed-off-by: Nathan Chancellor <nathan@kernel.org> --- drivers/i2c/busses/i2c-designware-platdrv.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) base-commit: 1d366c2f9df8279df2adbb60471f86fc40a1c39e