| Message ID | 20191121140830.1.Iae79baaa31014e8b1d8177bcfbcd41514af724f9@changeid |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Convert cros-ec-i2c-tunnel to MFD Cell | expand |
Hi, On 21/11/19 22:10, Raul E Rangel wrote: > The I2C bus needs to share the same ACPI node as the tunnel device so > that the I2C bus can be referenced from ACPI. > > Signed-off-by: Raul E Rangel <rrangel@chromium.org> Hmm, isn't this change the same as https://lkml.org/lkml/2019/11/21/208 ? Should I assume this deprecates the one pointed above? Who is the author? Please maintain the Signed-off chain. Thanks, Enric > --- > I would have added a Fixes annotation, but I wasn't able to find the > hash for https://lore.kernel.org/patchwork/patch/1151436/. > > drivers/i2c/busses/i2c-cros-ec-tunnel.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/i2c/busses/i2c-cros-ec-tunnel.c b/drivers/i2c/busses/i2c-cros-ec-tunnel.c > index 958161c71985..ac2412755f0a 100644 > --- a/drivers/i2c/busses/i2c-cros-ec-tunnel.c > +++ b/drivers/i2c/busses/i2c-cros-ec-tunnel.c > @@ -272,6 +272,7 @@ static int ec_i2c_probe(struct platform_device *pdev) > bus->adap.algo_data = bus; > bus->adap.dev.parent = &pdev->dev; > bus->adap.dev.of_node = pdev->dev.of_node; > + ACPI_COMPANION_SET(&bus->adap.dev, ACPI_COMPANION(&pdev->dev)); > bus->adap.retries = I2C_MAX_RETRIES; > > err = i2c_add_adapter(&bus->adap); >
On Mon, Nov 25, 2019 at 9:06 AM Enric Balletbo i Serra <enric.balletbo@collabora.com> wrote: > > Hi, > > On 21/11/19 22:10, Raul E Rangel wrote: > > The I2C bus needs to share the same ACPI node as the tunnel device so > > that the I2C bus can be referenced from ACPI. > > > > Signed-off-by: Raul E Rangel <rrangel@chromium.org> > > Hmm, isn't this change the same as https://lkml.org/lkml/2019/11/21/208 ? > We both found the same problem. I wasn't sure if it would be better to include it as part of this patch set since it was required for the MFD patch, or to reference it. Let's just take Akshu's patch and ignore this one.
On Thu, Nov 21, 2019 at 02:10:50PM -0700, Raul E Rangel wrote: > The I2C bus needs to share the same ACPI node as the tunnel device so > that the I2C bus can be referenced from ACPI. > > Signed-off-by: Raul E Rangel <rrangel@chromium.org> Dropped as requested.
diff --git a/drivers/i2c/busses/i2c-cros-ec-tunnel.c b/drivers/i2c/busses/i2c-cros-ec-tunnel.c index 958161c71985..ac2412755f0a 100644 --- a/drivers/i2c/busses/i2c-cros-ec-tunnel.c +++ b/drivers/i2c/busses/i2c-cros-ec-tunnel.c @@ -272,6 +272,7 @@ static int ec_i2c_probe(struct platform_device *pdev) bus->adap.algo_data = bus; bus->adap.dev.parent = &pdev->dev; bus->adap.dev.of_node = pdev->dev.of_node; + ACPI_COMPANION_SET(&bus->adap.dev, ACPI_COMPANION(&pdev->dev)); bus->adap.retries = I2C_MAX_RETRIES; err = i2c_add_adapter(&bus->adap);
The I2C bus needs to share the same ACPI node as the tunnel device so that the I2C bus can be referenced from ACPI. Signed-off-by: Raul E Rangel <rrangel@chromium.org> --- I would have added a Fixes annotation, but I wasn't able to find the hash for https://lore.kernel.org/patchwork/patch/1151436/. drivers/i2c/busses/i2c-cros-ec-tunnel.c | 1 + 1 file changed, 1 insertion(+)