diff mbox series

[2/2] i2c: sh_mobile: add support for r8a77990 (R-Car E3)

Message ID 20181121120928.25179-3-horms+renesas@verge.net.au
State Accepted
Headers show
Series i2c: sh_mobile: add support for r8a77990 (R-Car E3) | expand

Commit Message

Simon Horman Nov. 21, 2018, 12:09 p.m. UTC
Add support for the IIC code for the r8a77990 (R-Car E3).

It is not considered compatible with existing fallback bindings
due to the documented absence of automatic transmission registers.

These registers are currently not used by the driver and
thus the provides the same behaviour for "renesas,iic-r8a77990" and
"renesas,rcar-gen3-iic". The point of declaring incompatibility is
to allow for automatic transmission register support to be added to
"renesas,iic-r8a77990" and "renesas,rcar-gen3-iic" in future.

Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
---
 drivers/i2c/busses/i2c-sh_mobile.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Geert Uytterhoeven Nov. 23, 2018, 9:22 a.m. UTC | #1
On Wed, Nov 21, 2018 at 1:11 PM Simon Horman <horms+renesas@verge.net.au> wrote:
> Add support for the IIC code for the r8a77990 (R-Car E3).
>
> It is not considered compatible with existing fallback bindings
> due to the documented absence of automatic transmission registers.
>
> These registers are currently not used by the driver and
> thus the provides the same behaviour for "renesas,iic-r8a77990" and
> "renesas,rcar-gen3-iic". The point of declaring incompatibility is
> to allow for automatic transmission register support to be added to
> "renesas,iic-r8a77990" and "renesas,rcar-gen3-iic" in future.
>
> Signed-off-by: Simon Horman <horms+renesas@verge.net.au>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Gr{oetje,eeting}s,

                        Geert
Wolfram Sang Nov. 27, 2018, 12:30 p.m. UTC | #2
On Wed, Nov 21, 2018 at 01:09:28PM +0100, Simon Horman wrote:
> Add support for the IIC code for the r8a77990 (R-Car E3).
> 
> It is not considered compatible with existing fallback bindings
> due to the documented absence of automatic transmission registers.
> 
> These registers are currently not used by the driver and
> thus the provides the same behaviour for "renesas,iic-r8a77990" and
> "renesas,rcar-gen3-iic". The point of declaring incompatibility is
> to allow for automatic transmission register support to be added to
> "renesas,iic-r8a77990" and "renesas,rcar-gen3-iic" in future.
> 
> Signed-off-by: Simon Horman <horms+renesas@verge.net.au>

Applied to for-next, thanks!
diff mbox series

Patch

diff --git a/drivers/i2c/busses/i2c-sh_mobile.c b/drivers/i2c/busses/i2c-sh_mobile.c
index a7a7a9c3bc7c..28db6b59c4ca 100644
--- a/drivers/i2c/busses/i2c-sh_mobile.c
+++ b/drivers/i2c/busses/i2c-sh_mobile.c
@@ -808,6 +808,7 @@  static const struct of_device_id sh_mobile_i2c_dt_ids[] = {
 	{ .compatible = "renesas,rcar-gen2-iic", .data = &fast_clock_dt_config },
 	{ .compatible = "renesas,iic-r8a7795", .data = &fast_clock_dt_config },
 	{ .compatible = "renesas,rcar-gen3-iic", .data = &fast_clock_dt_config },
+	{ .compatible = "renesas,iic-r8a77990", .data = &fast_clock_dt_config },
 	{ .compatible = "renesas,iic-sh73a0", .data = &fast_clock_dt_config },
 	{ .compatible = "renesas,rmobile-iic", .data = &default_dt_config },
 	{},