| Message ID | 1562678049-17581-3-git-send-email-eugen.hristev@microchip.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | i2c: add support for filters | expand |
On Tue, 9 Jul 2019 13:19:33 +0000, <Eugen.Hristev@microchip.com> wrote: > From: Eugen Hristev <eugen.hristev@microchip.com> > > Some i2c controllers have a built-in digital or analog filter. > This is specifically required depending on the hardware PCB/board. > Some controllers also allow specifying the maximum width of the > spikes that can be filtered. The width length can be specified in nanoseconds. > > Signed-off-by: Eugen Hristev <eugen.hristev@microchip.com> > --- > Documentation/devicetree/bindings/i2c/i2c.txt | 11 +++++++++++ > 1 file changed, 11 insertions(+) > Reviewed-by: Rob Herring <robh@kernel.org>
On Tue, Jul 09, 2019 at 01:19:33PM +0000, Eugen.Hristev@microchip.com wrote: > From: Eugen Hristev <eugen.hristev@microchip.com> > > Some i2c controllers have a built-in digital or analog filter. > This is specifically required depending on the hardware PCB/board. > Some controllers also allow specifying the maximum width of the > spikes that can be filtered. The width length can be specified in nanoseconds. > > Signed-off-by: Eugen Hristev <eugen.hristev@microchip.com> > --- > Documentation/devicetree/bindings/i2c/i2c.txt | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/Documentation/devicetree/bindings/i2c/i2c.txt b/Documentation/devicetree/bindings/i2c/i2c.txt > index 44efafd..a2d31aa 100644 > --- a/Documentation/devicetree/bindings/i2c/i2c.txt > +++ b/Documentation/devicetree/bindings/i2c/i2c.txt > @@ -55,6 +55,17 @@ wants to support one of the below features, it should adapt the bindings below. > Number of nanoseconds the SDA signal takes to fall; t(f) in the I2C > specification. > > +- i2c-ana-filter > + Enable analog filter for i2c lines. > + > +- i2c-dig-filter > + Enable digital filter for i2c lines. Would you be OK with writing out 'analog' and 'digital' in full form? The abrreviation doesn't save us much, I'd think, and I didn't find similar wording in existing bindings. > + > +- i2c-filter-width-ns > + Width of spikes which can be filtered by either digital or analog > + filters (i2c-ana-filtr or i2c-dig-filtr). This width is specified > + in nanoseconds. > + > - interrupts > interrupts used by the device. > > -- > 2.7.4 >
diff --git a/Documentation/devicetree/bindings/i2c/i2c.txt b/Documentation/devicetree/bindings/i2c/i2c.txt index 44efafd..a2d31aa 100644 --- a/Documentation/devicetree/bindings/i2c/i2c.txt +++ b/Documentation/devicetree/bindings/i2c/i2c.txt @@ -55,6 +55,17 @@ wants to support one of the below features, it should adapt the bindings below. Number of nanoseconds the SDA signal takes to fall; t(f) in the I2C specification. +- i2c-ana-filter + Enable analog filter for i2c lines. + +- i2c-dig-filter + Enable digital filter for i2c lines. + +- i2c-filter-width-ns + Width of spikes which can be filtered by either digital or analog + filters (i2c-ana-filtr or i2c-dig-filtr). This width is specified + in nanoseconds. + - interrupts interrupts used by the device.