diff mbox series

i2c: i2c-stm32f7: Fix SDADEL minimum formula

Message ID 1551885125-22295-1-git-send-email-bich.hemon@st.com
State Accepted
Headers show
Series i2c: i2c-stm32f7: Fix SDADEL minimum formula | expand

Commit Message

Bich HEMON March 6, 2019, 3:12 p.m. UTC 
From: Nicolas Le Bayon <nicolas.le.bayon@st.com>

It conforms with Reference Manual I2C timing section.

Signed-off-by: Nicolas Le Bayon <nicolas.le.bayon@st.com>
Signed-off-by: Bich Hemon <bich.hemon@st.com>
---
 drivers/i2c/busses/i2c-stm32f7.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Pierre Yves MORDRET March 7, 2019, 8:29 a.m. UTC | #1 
Hi

Reviewed-by: Pierre-Yves MORDRET <pierre-yves.mordret@st.com>

Thanks

On 3/6/19 4:12 PM, Bich HEMON wrote:
> From: Nicolas Le Bayon <nicolas.le.bayon@st.com>
> 
> It conforms with Reference Manual I2C timing section.
> 
> Signed-off-by: Nicolas Le Bayon <nicolas.le.bayon@st.com>
> Signed-off-by: Bich Hemon <bich.hemon@st.com>
> ---
>  drivers/i2c/busses/i2c-stm32f7.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/i2c/busses/i2c-stm32f7.c b/drivers/i2c/busses/i2c-stm32f7.c
> index 13e1213..4284fc9 100644
> --- a/drivers/i2c/busses/i2c-stm32f7.c
> +++ b/drivers/i2c/busses/i2c-stm32f7.c
> @@ -432,7 +432,7 @@ static int stm32f7_i2c_compute_timing(struct stm32f7_i2c_dev *i2c_dev,
>  		 STM32F7_I2C_ANALOG_FILTER_DELAY_MAX : 0);
>  	dnf_delay = setup->dnf * i2cclk;
>  
> -	sdadel_min = setup->fall_time - i2c_specs[setup->speed].hddat_min -
> +	sdadel_min = i2c_specs[setup->speed].hddat_min + setup->fall_time -
>  		af_delay_min - (setup->dnf + 3) * i2cclk;
>  
>  	sdadel_max = i2c_specs[setup->speed].vddat_max - setup->rise_time -
>
Wolfram Sang March 9, 2019, 10:13 a.m. UTC | #2 
On Wed, Mar 06, 2019 at 03:12:16PM +0000, Bich HEMON wrote:
> From: Nicolas Le Bayon <nicolas.le.bayon@st.com>
> 
> It conforms with Reference Manual I2C timing section.
> 
> Signed-off-by: Nicolas Le Bayon <nicolas.le.bayon@st.com>
> Signed-off-by: Bich Hemon <bich.hemon@st.com>

Applied to for-current, thanks!
Wolfram Sang March 9, 2019, 10:50 a.m. UTC | #3 
On Sat, Mar 09, 2019 at 11:13:40AM +0100, Wolfram Sang wrote:
> On Wed, Mar 06, 2019 at 03:12:16PM +0000, Bich HEMON wrote:
> > From: Nicolas Le Bayon <nicolas.le.bayon@st.com>
> > 
> > It conforms with Reference Manual I2C timing section.
> > 
> > Signed-off-by: Nicolas Le Bayon <nicolas.le.bayon@st.com>
> > Signed-off-by: Bich Hemon <bich.hemon@st.com>
> 
> Applied to for-current, thanks!

Do you have a Fixes tag for this?
Bich HEMON March 11, 2019, 9:34 a.m. UTC | #4 
On 3/9/19 11:50 AM, Wolfram Sang wrote:
> On Sat, Mar 09, 2019 at 11:13:40AM +0100, Wolfram Sang wrote:
>> On Wed, Mar 06, 2019 at 03:12:16PM +0000, Bich HEMON wrote:
>>> From: Nicolas Le Bayon <nicolas.le.bayon@st.com>
>>>
>>> It conforms with Reference Manual I2C timing section.
>>>
>>> Signed-off-by: Nicolas Le Bayon <nicolas.le.bayon@st.com>
>>> Signed-off-by: Bich Hemon <bich.hemon@st.com>
>>
>> Applied to for-current, thanks!
> 
> Do you have a Fixes tag for this?
> 
Hi Wolfram,

Fixes: aeb068c57214858b638d5ee627bb4a831f98771e ("i2c: i2c-stm32f7: add 
driver")

Will you change the commit message or do you want me to resend the patch?

BR,

Bich
Wolfram Sang March 12, 2019, 1 p.m. UTC | #5 
> > Do you have a Fixes tag for this?
> > 
> 
> Fixes: aeb068c57214858b638d5ee627bb4a831f98771e ("i2c: i2c-stm32f7: add 
> driver")
> 
> Will you change the commit message or do you want me to resend the patch?

I'll fix it. Thanks for this info!
diff mbox series

Patch

diff --git a/drivers/i2c/busses/i2c-stm32f7.c b/drivers/i2c/busses/i2c-stm32f7.c
index 13e1213..4284fc9 100644
--- a/drivers/i2c/busses/i2c-stm32f7.c
+++ b/drivers/i2c/busses/i2c-stm32f7.c
@@ -432,7 +432,7 @@  static int stm32f7_i2c_compute_timing(struct stm32f7_i2c_dev *i2c_dev,
 		 STM32F7_I2C_ANALOG_FILTER_DELAY_MAX : 0);
 	dnf_delay = setup->dnf * i2cclk;
 
-	sdadel_min = setup->fall_time - i2c_specs[setup->speed].hddat_min -
+	sdadel_min = i2c_specs[setup->speed].hddat_min + setup->fall_time -
 		af_delay_min - (setup->dnf + 3) * i2cclk;
 
 	sdadel_max = i2c_specs[setup->speed].vddat_max - setup->rise_time -