diff mbox series

i2c-tools: decode-dimms: New manufacturer names from JEP106AX

Message ID 1542266581-7695-1-git-send-email-vpalatin@upmem.com
State Superseded
Headers show
Series i2c-tools: decode-dimms: New manufacturer names from JEP106AX | expand

Commit Message

Vincent Palatin Nov. 15, 2018, 7:23 a.m. UTC
Add all the JEDEC-registered manufacturer names added since JEP106AQ.

Signed-off-by: Vincent Palatin <vpalatin@upmem.com>
---
 eeprom/decode-dimms | 82 +++++++++++++++++++++++++++++++++++++++++++++++++++--
 1 file changed, 80 insertions(+), 2 deletions(-)

Comments

Peter Rosin Nov. 15, 2018, 7:54 a.m. UTC | #1
On 2018-11-15 08:23, Vincent Palatin wrote:
> Add all the JEDEC-registered manufacturer names added since JEP106AQ.

This is not a complete description of the change.

> Signed-off-by: Vincent Palatin <vpalatin@upmem.com>
> ---
>  eeprom/decode-dimms | 82 +++++++++++++++++++++++++++++++++++++++++++++++++++--
>  1 file changed, 80 insertions(+), 2 deletions(-)
> 
> diff --git a/eeprom/decode-dimms b/eeprom/decode-dimms
> index ede3ec6..9ead960 100755
> --- a/eeprom/decode-dimms
> +++ b/eeprom/decode-dimms
> @@ -336,8 +336,86 @@ $revision =~ s/ \([^()]*\)//;
>   "AP Memory", "Douqi Technology", "Etron Technology Inc.",
>   "Indie Semiconductor", "Socionext Inc.", "HGST", "EVGA",
>   "Audience Inc.", "EpicGear", "Vitesse Enterprise Co.",
> - "Foxtronn International Corporation", "Bretelon Inc.",
> - "Zbit Semiconductor Inc."]
> + "Foxtronn International Corporation", "Bretelon Inc.", "Graphcore", "Eoplex Inc",

*snip*

> + "Zbit Semiconductor Inc", "Shenzhen Technology Co Ltd", "Signalchip",

"Zbit Semiconductor Inc" has moved (and lost a dot), what's up with that?

Cheers,
Peter
Vincent Palatin Nov. 15, 2018, 8:39 a.m. UTC | #2
On Thu, Nov 15, 2018 at 8:54 AM Peter Rosin <peda@axentia.se> wrote:
>
> On 2018-11-15 08:23, Vincent Palatin wrote:
> > Add all the JEDEC-registered manufacturer names added since JEP106AQ.
>
> This is not a complete description of the change.
>
> > Signed-off-by: Vincent Palatin <vpalatin@upmem.com>
> > ---
> >  eeprom/decode-dimms | 82 +++++++++++++++++++++++++++++++++++++++++++++++++++--
> >  1 file changed, 80 insertions(+), 2 deletions(-)
> >
> > diff --git a/eeprom/decode-dimms b/eeprom/decode-dimms
> > index ede3ec6..9ead960 100755
> > --- a/eeprom/decode-dimms
> > +++ b/eeprom/decode-dimms
> > @@ -336,8 +336,86 @@ $revision =~ s/ \([^()]*\)//;
> >   "AP Memory", "Douqi Technology", "Etron Technology Inc.",
> >   "Indie Semiconductor", "Socionext Inc.", "HGST", "EVGA",
> >   "Audience Inc.", "EpicGear", "Vitesse Enterprise Co.",
> > - "Foxtronn International Corporation", "Bretelon Inc.",
> > - "Zbit Semiconductor Inc."]
> > + "Foxtronn International Corporation", "Bretelon Inc.", "Graphcore", "Eoplex Inc",
>
> *snip*
>
> > + "Zbit Semiconductor Inc", "Shenzhen Technology Co Ltd", "Signalchip",
>
> "Zbit Semiconductor Inc" has moved (and lost a dot), what's up with that?

This is what the JEDEC JEP106AX document says:
"""
The following numbers are all in bank 10:
[...]
94 Zbit Semiconductor Inc
[...]
"""

While where it was in bank 9 for current code, there is definitely
Graphcore at index 95:
"""
92 Vitesse Enterprise Co
93 Foxtronn International Corporation
94 Bretelon Inc
95 Graphcore
"""

Looking at it, the change is not document in the JEP Annex but another
project (OpenOCD) did a similar fixup:
https://repo.or.cz/openocd.git/commitdiff/063253fa89b2d48104b43783c03ff7161c5d1a5a
Maybe there was a mistake in a previous revision of the JEP106 (but
strangely it was silently fixed) or everybody copied the content from
a broken source.

There is no dot in the Standard document, I don't know what the local
convention is in this project.
Jean Delvare Nov. 22, 2018, 2:03 p.m. UTC | #3
Hi Vincent, Peter,

On Thu, 15 Nov 2018 09:39:22 +0100, Vincent Palatin wrote:
> On Thu, Nov 15, 2018 at 8:54 AM Peter Rosin <peda@axentia.se> wrote:
> > On 2018-11-15 08:23, Vincent Palatin wrote:  
> > > Add all the JEDEC-registered manufacturer names added since JEP106AQ.  
> >
> > This is not a complete description of the change.

That's good enough as far as I'm concerned.

> > > Signed-off-by: Vincent Palatin <vpalatin@upmem.com>
> > > ---
> > >  eeprom/decode-dimms | 82 +++++++++++++++++++++++++++++++++++++++++++++++++++--
> > >  1 file changed, 80 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/eeprom/decode-dimms b/eeprom/decode-dimms
> > > index ede3ec6..9ead960 100755
> > > --- a/eeprom/decode-dimms
> > > +++ b/eeprom/decode-dimms
> > > @@ -336,8 +336,86 @@ $revision =~ s/ \([^()]*\)//;
> > >   "AP Memory", "Douqi Technology", "Etron Technology Inc.",
> > >   "Indie Semiconductor", "Socionext Inc.", "HGST", "EVGA",
> > >   "Audience Inc.", "EpicGear", "Vitesse Enterprise Co.",
> > > - "Foxtronn International Corporation", "Bretelon Inc.",
> > > - "Zbit Semiconductor Inc."]
> > > + "Foxtronn International Corporation", "Bretelon Inc.", "Graphcore", "Eoplex Inc",  
> >
> > *snip*
> >  
> > > + "Zbit Semiconductor Inc", "Shenzhen Technology Co Ltd", "Signalchip",  
> >
> > "Zbit Semiconductor Inc" has moved (and lost a dot), what's up with that?  
> 
> This is what the JEDEC JEP106AX document says:
> """
> The following numbers are all in bank 10:
> [...]
> 94 Zbit Semiconductor Inc
> [...]
> """
> 
> While where it was in bank 9 for current code, there is definitely
> Graphcore at index 95:
> """
> 92 Vitesse Enterprise Co
> 93 Foxtronn International Corporation
> 94 Bretelon Inc
> 95 Graphcore
> """

Yes, "Zbit Semiconductor Inc" moved from bank 9 to bank 10 (and lost
its dot) somewhere between JEP106AQ and JEP106AX. That's confusing but
the patch is correct.

> Looking at it, the change is not document in the JEP Annex but another
> project (OpenOCD) did a similar fixup:
> https://repo.or.cz/openocd.git/commitdiff/063253fa89b2d48104b43783c03ff7161c5d1a5a
> Maybe there was a mistake in a previous revision of the JEP106 (but
> strangely it was silently fixed) or everybody copied the content from
> a broken source.
> 
> There is no dot in the Standard document, I don't know what the local
> convention is in this project.

I don't know either ;-) I don't think it really matters to be honest,
so we can just take what the JEDEC specification has.

I'm more worried by the fact that some names are not listed in the same
order in the patch as in the specification. For bank 9, names 104-109
("Boya ..." to "Guangzhou Si Nuo ...") appear in the patch after
"Starsway Technology Limited" which is supposed to be number 126 (and
in a different order too). Vincent, can you please double check?

The rest of the list looks good.
Vincent Palatin Nov. 22, 2018, 5:14 p.m. UTC | #4
On Thu, Nov 22, 2018 at 3:03 PM Jean Delvare <jdelvare@suse.de> wrote:
>
> Hi Vincent, Peter,
>
> On Thu, 15 Nov 2018 09:39:22 +0100, Vincent Palatin wrote:
> > On Thu, Nov 15, 2018 at 8:54 AM Peter Rosin <peda@axentia.se> wrote:
> > > On 2018-11-15 08:23, Vincent Palatin wrote:
> > > > Add all the JEDEC-registered manufacturer names added since JEP106AQ.
> > >
> > > This is not a complete description of the change.
>
> That's good enough as far as I'm concerned.
>
> > > > Signed-off-by: Vincent Palatin <vpalatin@upmem.com>
> > > > ---
> > > >  eeprom/decode-dimms | 82 +++++++++++++++++++++++++++++++++++++++++++++++++++--
> > > >  1 file changed, 80 insertions(+), 2 deletions(-)
> > > >
> > > > diff --git a/eeprom/decode-dimms b/eeprom/decode-dimms
> > > > index ede3ec6..9ead960 100755
> > > > --- a/eeprom/decode-dimms
> > > > +++ b/eeprom/decode-dimms
> > > > @@ -336,8 +336,86 @@ $revision =~ s/ \([^()]*\)//;
> > > >   "AP Memory", "Douqi Technology", "Etron Technology Inc.",
> > > >   "Indie Semiconductor", "Socionext Inc.", "HGST", "EVGA",
> > > >   "Audience Inc.", "EpicGear", "Vitesse Enterprise Co.",
> > > > - "Foxtronn International Corporation", "Bretelon Inc.",
> > > > - "Zbit Semiconductor Inc."]
> > > > + "Foxtronn International Corporation", "Bretelon Inc.", "Graphcore", "Eoplex Inc",
> > >
> > > *snip*
> > >
> > > > + "Zbit Semiconductor Inc", "Shenzhen Technology Co Ltd", "Signalchip",
> > >
> > > "Zbit Semiconductor Inc" has moved (and lost a dot), what's up with that?
> >
> > This is what the JEDEC JEP106AX document says:
> > """
> > The following numbers are all in bank 10:
> > [...]
> > 94 Zbit Semiconductor Inc
> > [...]
> > """
> >
> > While where it was in bank 9 for current code, there is definitely
> > Graphcore at index 95:
> > """
> > 92 Vitesse Enterprise Co
> > 93 Foxtronn International Corporation
> > 94 Bretelon Inc
> > 95 Graphcore
> > """
>
> Yes, "Zbit Semiconductor Inc" moved from bank 9 to bank 10 (and lost
> its dot) somewhere between JEP106AQ and JEP106AX. That's confusing but
> the patch is correct.
>
> > Looking at it, the change is not document in the JEP Annex but another
> > project (OpenOCD) did a similar fixup:
> > https://repo.or.cz/openocd.git/commitdiff/063253fa89b2d48104b43783c03ff7161c5d1a5a
> > Maybe there was a mistake in a previous revision of the JEP106 (but
> > strangely it was silently fixed) or everybody copied the content from
> > a broken source.
> >
> > There is no dot in the Standard document, I don't know what the local
> > convention is in this project.
>
> I don't know either ;-) I don't think it really matters to be honest,
> so we can just take what the JEDEC specification has.
>
> I'm more worried by the fact that some names are not listed in the same
> order in the patch as in the specification. For bank 9, names 104-109
> ("Boya ..." to "Guangzhou Si Nuo ...") appear in the patch after
> "Starsway Technology Limited" which is supposed to be number 126 (and
> in a different order too). Vincent, can you please double check?

Yes, you are right, I fat-fingered this part while processing the text.
Thanks for the careful review !
I will send a V2 patch tomorrow, this time the added list order is
fully matching the spec order.
diff mbox series

Patch

diff --git a/eeprom/decode-dimms b/eeprom/decode-dimms
index ede3ec6..9ead960 100755
--- a/eeprom/decode-dimms
+++ b/eeprom/decode-dimms
@@ -336,8 +336,86 @@  $revision =~ s/ \([^()]*\)//;
  "AP Memory", "Douqi Technology", "Etron Technology Inc.",
  "Indie Semiconductor", "Socionext Inc.", "HGST", "EVGA",
  "Audience Inc.", "EpicGear", "Vitesse Enterprise Co.",
- "Foxtronn International Corporation", "Bretelon Inc.",
- "Zbit Semiconductor Inc."]
+ "Foxtronn International Corporation", "Bretelon Inc.", "Graphcore", "Eoplex Inc",
+ "MaxLinear Inc", "ETA Devices", "LOKI", "IMS Electronics Co Ltd",
+ "Dosilicon Co Ltd", "Dolphin Integration", "Shenzhen Mic Electronics Technolog",
+ "Crocus Technology Inc", "Creative Chips GmbH", "GE Aviation Systems LLC.",
+ "Asgard", "Good Wealth Technology Ltd", "TriCor Technologies", "Nova-Systems GmbH",
+ "JUHOR", "Zhuhai Douke Commerce Co Ltd", "DSL Memory", "Anvo-Systems Dresden GmbH",
+ "Realtek", "AltoBeam", "Wave Computing", "Beijing TrustNet Technology Co Ltd",
+ "Innovium Inc", "Starsway Technology Limited", "Chao Yue Zhuo Computer Business Dept.",
+ "Guangzhou Si Nuo Electronic Technology.", "Boya Microelectronics Inc",
+ "Geniachip (Roche)", "Axign", "Kingred Electronic Technology Ltd"],
+["Weltronics Co LTD", "VMware Inc", "Hewlett Packard Enterprise", "INTENSO",
+ "Puya Semiconductor", "MEMORFI", "MSC Technologies GmbH", "Txrui",
+ "SiFive Inc", "Spreadtrum Communications", "XTX Technology Limited",
+ "UMAX Technology", "Shenzhen Yong Sheng Technology", "SNOAMOO (Shenzhen Kai Zhuo Yue)",
+ "Daten Tecnologia LTDA", "Shenzhen XinRuiYan Electronics", "Eta Compute",
+ "Energous", "Raspberry Pi Trading Ltd", "Shenzhen Chixingzhe Tech Co Ltd",
+ "Silicon Mobility", "IQ-Analog Corporation", "Uhnder Inc", "Impinj",
+ "DEPO Computers", "Nespeed Sysems", "Yangtze Memory Technologies Co Ltd",
+ "MemxPro Inc", "Tammuz Co Ltd", "Allwinner Technology",
+ "Shenzhen City Futian District Qing Xuan Tong Computer Trading Firm", "XMC",
+ "Teclast", "Maxsun", "Haiguang Integrated Circuit Design", "RamCENTER Technology",
+ "Phison Electronics Corporation", "Guizhou Huaxintong Semi-Conductor",
+ "Network Intelligence", "Continental Technology (Holdings)",
+ "Guangzhou Huayan Suning Electronic", "Guangzhou Zhouji Electronic Co Ltd",
+ "Shenzhen Giant Hui Kang Tech Co Ltd", "Shenzhen Yilong Innovative Co Ltd",
+ "Neo Forza", "Lyontek Inc", "Shanghai Kuxin Microelectronics Ltd",
+ "Shenzhen Larix Technology Co Ltd", "Qbit Semiconductor Ltd",
+ "Insignis Technology Corporation", "Lanson Memory Co Ltd",
+ "Shenzhen Superway Electronics Co Ltd", "Canaan-Creative Co Ltd",
+ "Black Diamond Memory", "Shenzhen City Parker Baking Electronics",
+ "Shenzhen Baihong Technology Co Ltd", "GEO Semiconductors", "OCPC", "Artery Technology Co Ltd",
+ "Jinyu", "ShenzhenYing Chi Technology Development", "Shenzhen Pengcheng Xin Technology",
+ "Pegasus Semiconductor (Shanghai) Co", "Mythic Inc", "Elmos Semiconductor AG",
+ "Kllisre", "Shenzhen Winconway Technology", "Shenzhen Xingmem Technology Corp",
+ "Gold Key Technology Co Ltd", "Habana Labs Ltd", "Hoodisk Electronics Co Ltd",
+ "SemsoTai (HK) Technology Co Ltd", "OM Nanotech Pvt. Ltd",
+ "Shenzhen Zhifeng Weiye Technology", "Xinshirui (Shenzhen) Electronics Co",
+ "Guangzhou Zhong Hao Tian Electronic", "Shenzhen Longsys Electronics Co Ltd",
+ "Deciso B.V.", "Puya Semiconductor (Shenzhen)", "Shenzhen Veineda Technology Co Ltd",
+ "Antec Memory", "Cortus SAS", "Dust Leopard", "MyWo AS",
+ "J&A Information Inc", "Shenzhen JIEPEI Technology Co Ltd", "Heidelberg University",
+ "Flexxon PTE Ltd", "Wiliot", "Raysun Electronics International Ltd",
+ "Aquarius Production Company LLC", "MACNICA DHW LTDA", "Intelimem",
+ "Zbit Semiconductor Inc", "Shenzhen Technology Co Ltd", "Signalchip",
+ "Shenzen Recadata Storage Technology", "Hyundai Technology",
+ "Shanghai Fudi Investment Development", "Aixi Technology", "Tecon MT",
+ "Onda Electric Co Ltd", "Jinshen", "Kimtigo Semiconductor (HK) Limited",
+ "IIT Madras", "Shenshan (Shenzhen) Electronic", "Hefei Core Storage Electronic Limited",
+ "Colorful Technology Ltd", "Visenta (Xiamen) Technology Co Ltd", "Roa Logic BV",
+ "NSITEXE Inc", "Hong Kong Hyunion Electronics", "ASK Technology Group Limited",
+ "GIGA-BYTE Technology Co Ltd", "Terabyte Co Ltd", "Hyundai Inc", "EXCELERAM",
+ "PsiKick", "Netac Technology Co Ltd", "PCCOOLER", "Jiangsu Huacun Electronic Technology",
+ "Shenzhen Micro Innovation Industry", "Beijing Tongfang Microelectronics Co",
+ "XZN Storage Technology", "ChipCraft Sp. z.o.o.", "ALLFLASH Technology Limited"],
+["Foerd Technology Co Ltd", "KingSpec", "Codasip Ltd", "SL Link Co Ltd",
+ "Shenzhen Kefu Technology Co Limited", "Shenzhen ZST Electronics Technology",
+ "Kyokuto Electronic Inc", "Warrior Technology", "TRINAMIC Motion Control GmbH & Co",
+ "PixelDisplay Inc", "Shenzhen Futian District Bo Yueda Elec", "Richtek Power",
+ "Shenzhen LianTeng Electronics Co Ltd", "AITC Memory", "UNIC Memory Technology Co Ltd",
+ "Shenzhen Huafeng Science Technology", "Innotron Memory Co Ltd",
+ "Guangzhou Xinyi Heng Computer Trading Firm", "SambaNova Systems", "V-GEN",
+ "Jump Trading", "Ampere Computing", "Shenzhen Zhongshi Technology Co Ltd",
+ "Shenzhen Zhongtian Bozhong Technology", "Tri-Tech International",
+ "Silicon Intergrated Systems Corporation", "Shenzhen HongDingChen Information",
+ "Plexton Holdings Limited", "AMS (Jiangsu Advanced Memory Semi)",
+ "Wuhan Jing Tian Interconnected Tech Co", "Axia Memory Technology",
+ "Chipset Technology Holding Limited", "Shenzhen Xinshida Technology Co Ltd",
+ "Shenzhen Chuangshifeida Technology", "Guangzhou MiaoYuanJi Technology", "ADVAN Inc",
+ "Shenzhen Qianhai Weishengda Electronic Commerce Company Ltd", "Guangzhou Guang Xie Cheng Trading",
+ "StarRam International Co Ltd", "Shen Zhen XinShenHua Tech Co Ltd",
+ "UltraMemory Inc", "New Coastline Global Tech Industry Co", "Sinker", "Diamond",
+ "PUSKILL", "Guangzhou Hao Jia Ye Technology Co", "Ming Xin Limited", "Barefoot Networks",
+ "Biwin Semiconductor (HK) Co Ltd", "UD INFO Corporation", "Trek Technology (S) PTE Ltd",
+ "Xiamen Kingblaze Technology Co Ltd", "Shenzhen Lomica Technology Co Ltd",
+ "Nuclei System Technology Co Ltd", "Wuhan Xun Zhan Electronic Technology",
+ "Shenzhen Ingacom Semiconductor Ltd", "Zotac Technology Ltd", "Foxline",
+ "Shenzhen Farasia Science Technology", "Efinix Inc", "Hua Nan San Xian Technology Co Ltd",
+ "Goldtech Electronics Co Ltd", "Shanghai Han Rong Microelectronics Co",
+ "Shenzhen Zhongguang Yunhe Trading", "Smart Shine(QingDao) Microelectronics",
+ "Thermaltake Technology Co Ltd", "Shenzhen O'Yang Maile Technology Ltd", "UPMEM"]
 );
 
 $use_sysfs = -d '/sys/bus';