| Message ID | 1484648455-5454-1-git-send-email-pandy.gao@nxp.com |
|---|---|
| State | Accepted |
| Headers | show |
On 01/17/2017 12:20 PM, Gao Pan wrote: > When system enters VLLS mode, module power is turned off. As a result, > all registers are reset to HW default value. After exiting VLLS mode, > registers are still in default mode. As a result, the pinctrl settings > are incorrect, which will affect the module function. > > The patch recovers the pinctrl setting when exit VLLS mode. > > Signed-off-by: Gao Pan <pandy.gao@nxp.com> > --- > V2: > -drop "#else branch" and IMX_LPI2C_PM completely > -pm = &imx_lpi2c_pm > > V3: > -remove unnecessary #ifdef > The change looks good, thank you for updates. Reviewed-by: Vladimir Zapolskiy <vz@mleia.com> -- With best wishes, Vladimir -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, Jan 17, 2017 at 06:20:55PM +0800, Gao Pan wrote: > When system enters VLLS mode, module power is turned off. As a result, > all registers are reset to HW default value. After exiting VLLS mode, > registers are still in default mode. As a result, the pinctrl settings > are incorrect, which will affect the module function. > > The patch recovers the pinctrl setting when exit VLLS mode. > > Signed-off-by: Gao Pan <pandy.gao@nxp.com> Applied to for-next, thanks!
On Wed, Jan 25, 2017 at 09:53:06PM +0100, Wolfram Sang wrote: > On Tue, Jan 17, 2017 at 06:20:55PM +0800, Gao Pan wrote: > > When system enters VLLS mode, module power is turned off. As a result, > > all registers are reset to HW default value. After exiting VLLS mode, > > registers are still in default mode. As a result, the pinctrl settings > > are incorrect, which will affect the module function. > > > > The patch recovers the pinctrl setting when exit VLLS mode. > > > > Signed-off-by: Gao Pan <pandy.gao@nxp.com> > > Applied to for-next, thanks! Reconsidered and applied to for-current instead.
diff --git a/drivers/i2c/busses/i2c-imx-lpi2c.c b/drivers/i2c/busses/i2c-imx-lpi2c.c index c62b7cd..5a85c49 100644 --- a/drivers/i2c/busses/i2c-imx-lpi2c.c +++ b/drivers/i2c/busses/i2c-imx-lpi2c.c @@ -636,12 +636,31 @@ static int lpi2c_imx_remove(struct platform_device *pdev) return 0; } +#ifdef CONFIG_PM_SLEEP +static int lpi2c_imx_suspend(struct device *dev) +{ + pinctrl_pm_select_sleep_state(dev); + + return 0; +} + +static int lpi2c_imx_resume(struct device *dev) +{ + pinctrl_pm_select_default_state(dev); + + return 0; +} +#endif + +static SIMPLE_DEV_PM_OPS(imx_lpi2c_pm, lpi2c_imx_suspend, lpi2c_imx_resume); + static struct platform_driver lpi2c_imx_driver = { .probe = lpi2c_imx_probe, .remove = lpi2c_imx_remove, .driver = { .name = DRIVER_NAME, .of_match_table = lpi2c_imx_of_match, + .pm = &imx_lpi2c_pm, }, };
When system enters VLLS mode, module power is turned off. As a result, all registers are reset to HW default value. After exiting VLLS mode, registers are still in default mode. As a result, the pinctrl settings are incorrect, which will affect the module function. The patch recovers the pinctrl setting when exit VLLS mode. Signed-off-by: Gao Pan <pandy.gao@nxp.com> --- V2: -drop "#else branch" and IMX_LPI2C_PM completely -pm = &imx_lpi2c_pm V3: -remove unnecessary #ifdef drivers/i2c/busses/i2c-imx-lpi2c.c | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+)