| Message ID | 1484474381-1064-1-git-send-email-bhumirks@gmail.com |
|---|---|
| State | Accepted |
| Headers | show |
* Bhumika Goyal <bhumirks@gmail.com> [170115 02:00]: > Declare dev_pm_ops structures as const as they are only stored in the pm > field of a device_driver structure. This field is of type const, so > dev_pm_ops structures having similar properties can be declared const > too. > > File size before: drivers/i2c/busses/i2c-omap.o > text data bss dec hex filename > 6814 584 0 7398 1ce6 drivers/i2c/busses/i2c-omap.o > > File size after: drivers/i2c/busses/i2c-omap.o > text data bss dec hex filename > 7006 392 0 7398 1ce6 drivers/i2c/busses/i2c-omap.o > > Signed-off-by: Bhumika Goyal <bhumirks@gmail.com> Acked-by: Tony Lindgren <tony@atomide.com> > --- > drivers/i2c/busses/i2c-omap.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/i2c/busses/i2c-omap.c b/drivers/i2c/busses/i2c-omap.c > index c7da0c4..1ebb5e9 100644 > --- a/drivers/i2c/busses/i2c-omap.c > +++ b/drivers/i2c/busses/i2c-omap.c > @@ -1504,7 +1504,7 @@ static int omap_i2c_runtime_resume(struct device *dev) > return 0; > } > > -static struct dev_pm_ops omap_i2c_pm_ops = { > +static const struct dev_pm_ops omap_i2c_pm_ops = { > SET_RUNTIME_PM_OPS(omap_i2c_runtime_suspend, > omap_i2c_runtime_resume, NULL) > }; > -- > 1.9.1 > -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Sun, Jan 15, 2017 at 03:29:41PM +0530, Bhumika Goyal wrote: > Declare dev_pm_ops structures as const as they are only stored in the pm > field of a device_driver structure. This field is of type const, so > dev_pm_ops structures having similar properties can be declared const > too. > > File size before: drivers/i2c/busses/i2c-omap.o > text data bss dec hex filename > 6814 584 0 7398 1ce6 drivers/i2c/busses/i2c-omap.o > > File size after: drivers/i2c/busses/i2c-omap.o > text data bss dec hex filename > 7006 392 0 7398 1ce6 drivers/i2c/busses/i2c-omap.o > > Signed-off-by: Bhumika Goyal <bhumirks@gmail.com> Applied to for-next, thanks! I dropped the file size table from the commit message, though. For me, it is clear enough without it.
diff --git a/drivers/i2c/busses/i2c-omap.c b/drivers/i2c/busses/i2c-omap.c index c7da0c4..1ebb5e9 100644 --- a/drivers/i2c/busses/i2c-omap.c +++ b/drivers/i2c/busses/i2c-omap.c @@ -1504,7 +1504,7 @@ static int omap_i2c_runtime_resume(struct device *dev) return 0; } -static struct dev_pm_ops omap_i2c_pm_ops = { +static const struct dev_pm_ops omap_i2c_pm_ops = { SET_RUNTIME_PM_OPS(omap_i2c_runtime_suspend, omap_i2c_runtime_resume, NULL) };
Declare dev_pm_ops structures as const as they are only stored in the pm field of a device_driver structure. This field is of type const, so dev_pm_ops structures having similar properties can be declared const too. File size before: drivers/i2c/busses/i2c-omap.o text data bss dec hex filename 6814 584 0 7398 1ce6 drivers/i2c/busses/i2c-omap.o File size after: drivers/i2c/busses/i2c-omap.o text data bss dec hex filename 7006 392 0 7398 1ce6 drivers/i2c/busses/i2c-omap.o Signed-off-by: Bhumika Goyal <bhumirks@gmail.com> --- drivers/i2c/busses/i2c-omap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)