| Message ID | 1463416888-22044-6-git-send-email-pantelis.antoniou@konsulko.com |
|---|---|
| State | Awaiting Upstream |
| Headers | show |
On Mon, May 16, 2016 at 07:41:28PM +0300, Pantelis Antoniou wrote: > The changeset helpers are easier to use, use them instead of > using the static property. > > Signed-off-by: Pantelis Antoniou <pantelis.antoniou@konsulko.com> If you think this is worthwhile, then it's fine with me :) Acked-by: Wolfram Sang <wsa@the-dreams.de> > + adap_np, "status", "okay"); "ok" would be shorter?
diff --git a/drivers/i2c/muxes/i2c-demux-pinctrl.c b/drivers/i2c/muxes/i2c-demux-pinctrl.c index 8de073a..ddaca9e 100644 --- a/drivers/i2c/muxes/i2c-demux-pinctrl.c +++ b/drivers/i2c/muxes/i2c-demux-pinctrl.c @@ -37,8 +37,6 @@ struct i2c_demux_pinctrl_priv { struct i2c_demux_pinctrl_chan chan[]; }; -static struct property status_okay = { .name = "status", .length = 3, .value = "ok" }; - static int i2c_demux_master_xfer(struct i2c_adapter *adap, struct i2c_msg msgs[], int num) { struct i2c_demux_pinctrl_priv *priv = adap->algo_data; @@ -219,7 +217,8 @@ static int i2c_demux_pinctrl_probe(struct platform_device *pdev) priv->chan[i].parent_np = adap_np; of_changeset_init(&priv->chan[i].chgset); - of_changeset_update_property(&priv->chan[i].chgset, adap_np, &status_okay); + of_changeset_update_property_string(&priv->chan[i].chgset, + adap_np, "status", "okay"); } priv->num_chan = num_chan;
The changeset helpers are easier to use, use them instead of using the static property. Signed-off-by: Pantelis Antoniou <pantelis.antoniou@konsulko.com> --- drivers/i2c/muxes/i2c-demux-pinctrl.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)