Message ID | 1434554299-23443-5-git-send-email-shubhraj@xilinx.com |
---|---|
State | Accepted |
Headers | show
Return-Path: <linux-i2c-owner@vger.kernel.org> X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id D8E961401EF for <incoming@patchwork.ozlabs.org>; Thu, 18 Jun 2015 01:18:35 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932320AbbFQPSe (ORCPT <rfc822;incoming@patchwork.ozlabs.org>); Wed, 17 Jun 2015 11:18:34 -0400 Received: from mail-bl2on0067.outbound.protection.outlook.com ([65.55.169.67]:32032 "EHLO na01-bl2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1757097AbbFQPSb (ORCPT <rfc822;linux-i2c@vger.kernel.org>); Wed, 17 Jun 2015 11:18:31 -0400 Received: from BN1AFFO11FD023.protection.gbl (10.58.52.30) by BN1AFFO11HUB031.protection.gbl (10.58.52.141) with Microsoft SMTP Server (TLS) id 15.1.190.9; Wed, 17 Jun 2015 15:18:29 +0000 Authentication-Results: spf=pass (sender IP is 149.199.60.83) smtp.mailfrom=xilinx.com; vger.kernel.org; dkim=none (message not signed) header.d=none; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.60.83 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.60.83; helo=xsj-pvapsmtpgw01; Received: from xsj-pvapsmtpgw01 (149.199.60.83) by BN1AFFO11FD023.mail.protection.outlook.com (10.58.52.83) with Microsoft SMTP Server (TLS) id 15.1.190.9 via Frontend Transport; Wed, 17 Jun 2015 15:18:28 +0000 Received: from unknown-38-66.xilinx.com ([149.199.38.66] helo=xsj-pvapsmtp01) by xsj-pvapsmtpgw01 with esmtp (Exim 4.63) (envelope-from <shubhrajyoti.datta@xilinx.com>) id 1Z5F6i-0005kX-32 for linux-i2c@vger.kernel.org; Wed, 17 Jun 2015 08:18:28 -0700 Received: from [127.0.0.1] (helo=localhost) by xsj-pvapsmtp01 with smtp (Exim 4.63) (envelope-from <shubhrajyoti.datta@xilinx.com>) id 1Z5F6h-0002ER-Tg for linux-i2c@vger.kernel.org; Wed, 17 Jun 2015 08:18:27 -0700 Received: from xsj-pvapsmtp01 (mailhub.xilinx.com [149.199.38.66]) by xsj-smtp-dlp2.xlnx.xilinx.com (8.13.8/8.13.1) with ESMTP id t5HFI4T9022763; Wed, 17 Jun 2015 08:18:04 -0700 Received: from [172.23.146.171] (helo=xhdl3763.xilinx.com) by xsj-pvapsmtp01 with esmtp (Exim 4.63) (envelope-from <shubhraj@xilinx.com>) id 1Z5F6f-0002Dj-Eh; Wed, 17 Jun 2015 08:18:25 -0700 Received: by xhdl3763.xilinx.com (Postfix, from userid 9049) id A542E2CE03D7; Wed, 17 Jun 2015 20:48:24 +0530 (IST) From: Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com> To: <linux-i2c@vger.kernel.org> CC: Shubhrajyoti Datta <shubhraj@xilinx.com> Subject: [PATCHv2 4/9] i2c: xiic: Remove the disabling of interrupts Date: Wed, 17 Jun 2015 20:48:14 +0530 Message-ID: <1434554299-23443-5-git-send-email-shubhraj@xilinx.com> X-Mailer: git-send-email 1.7.4 In-Reply-To: <1434554299-23443-1-git-send-email-shubhraj@xilinx.com> References: <1434554299-23443-1-git-send-email-shubhraj@xilinx.com> X-RCIS-Action: ALLOW X-TM-AS-Product-Ver: IMSS-7.1.0.1224-8.0.0.1202-21618.005 X-TM-AS-User-Approved-Sender: Yes;Yes X-EOPAttributedMessage: 0 X-Microsoft-Exchange-Diagnostics: 1; BN1AFFO11FD023; 1:graAzEVobTLW8Y/0ZFZgtnj+dU049ucSJvLbEc9CAxvNc27W7lR6FZ9qR+G5VR9CJYkqX3ipmxVe/Ddnix23JIlG6iiYlBCTmfCyD4PRtL+ubehwfKnu0yth7NXIVUq9kOhU5E6HTG8R1bfCl9CRTUUBJJhqrZmj0DakpRvsj4JBl/a0F32S7LaWTyY+fFVYrEumGUBWc13DVofzpQLjRRQLp4QfiWYuJt8vC+crgvBeh7tFxZZDmpilkwuCvWPcsigEKw/RkOpAFvlsGrXmeOk37dykdXSv74xkmGnQAZw= X-Forefront-Antispam-Report: CIP:149.199.60.83; CTRY:US; IPV:NLI; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(2980300002)(438002)(199003)(189002)(189998001)(110136002)(62966003)(92566002)(2351001)(63266004)(42186005)(36386004)(229853001)(2950100001)(50226001)(46102003)(36756003)(450100001)(5001960100002)(107886002)(77156002)(19580395003)(86362001)(19580405001)(50466002)(52956003)(87936001)(47776003)(76176999)(48376002)(50986999)(6806004)(45336002)(46386002)(33646002)(106466001)(103686003)(107986001)(4001430100001)(90966001); DIR:OUT; SFP:1101; SCL:1; SRVR:BN1AFFO11HUB031; H:xsj-pvapsmtpgw01; FPR:; SPF:Pass; MLV:ovrnspm; A:1; MX:1; PTR:unknown-60-83.xilinx.com; LANG:en; MIME-Version: 1.0 Content-Type: text/plain X-Microsoft-Exchange-Diagnostics: 1; BN1AFFO11HUB031; 2:gSG8dCfA2ttAZrPR+RDZtHsixIioolIpSA1H81cwlc2JUwoZbgto6hqU+XEf3OX9; 2:BQQ3s6Zs5ydSa9sSPtTXsIYPaetIRi52NNlq4RGVfYO1gOz3IDRo3dPsUljYnuNEV/eX9GYPEEasgZw8/X8nJZilgLHLOT4fL0PCLZPncad5K0dESZDfXRxpUq4DcomYyLlTmnQUVqnt9k/nk0DVLAWg7a+CkrL7/DiwQg3fPkRdfu0OAPG9oZrugYYN7868GHA32wE6XCMaRxLbDW9l3kpIP/w/q4PM42geJdQ48FE=; 6:7e6Ve7B/l6PDIlDCKqm/xdk5CmSwZWjTG2VsbQ7Z4BKCdaDOyPkupgxasB32al8zjMZr0plaLqTiaqrFhZNtQm2SNGdi0HUpe9bdufWudsEftWWKRqGeesdnFnb4GyWxDn620ZPdQo3lzka27N21SEbAcUOcJzbFdijlPv4dbdaqPUoqZL7BRu47/IcM5loSmnPZGb6kQdr5c4j1vTbkbeHpAibBW8HYSIU5/T/XpHU2PG+LDQhymsB9hDS4taL11LF363Ogw2xIonbxMr/+bYf84lVGAJ28WYg7WB7dUOftAIez2zMgz5lxKCIbQBqehLt6qz6SmGlSZCeJoo/nadrVvsU0m6yStHDTQMrlkZUSSjWSTqWRch6Yi1KsjpXuGsqH8laDRouBOIyefsBeDkIFhTLYY7uHZAUYYTc/sM43a8p0/FIUGq+MC5AfnQoxCc0nHOi91JC5PWrBWE7BaiCv3o0gxA2KzfWQymTSrkT/ojSf5I3xK8+meyMlFwVE X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BN1AFFO11HUB031; X-Microsoft-Antispam-PRVS: <BN1AFFO11HUB0316D6C3D4C1112B047DF48EBA60@BN1AFFO11HUB031.protection.gbl> X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(601004)(520003)(5005006)(3002001); SRVR:BN1AFFO11HUB031; BCL:0; PCL:0; RULEID:; SRVR:BN1AFFO11HUB031; X-Microsoft-Exchange-Diagnostics: 1; BN1AFFO11HUB031; 3:01wsAhbfUfBX3qUxzmNGpoo2cx3iLc21LfiUEqo+UUgrTDSgSjtyTWsFqVKNzmyyhDGbaU2ZrxS7TeRk11ixq/NP1BHXdGUH3lcssqYxjpin9egsPKdhRx07WxW7XVwQq3U160Q6Iaj/1sD/THhk3Zpzi2M11xmoj+mu3peDniEHnppwFQMUru1wtFrRCggOpfzYMv6mTHqZN0V8hrQ5yL94dETLu/Z43nugt6YDmQmoL8JFR0ehjmELoYdTNevpNbUYU4/AFKVNIe3b0ozItQgFnMQBcg4jj6VcwCVYElxVxXKCwJFvqyFxAX0P1pSd X-Forefront-PRVS: 0610D16BBE X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BN1AFFO11HUB031; 9:k2bPitpOVGr4I74/GDoxSp1dK+61l+9GhEU5hiV6?= =?us-ascii?Q?O1K2O5EdSNIkPudz4nYoaZvnkMPTF6okr5JJDFBjKwUcaQghpPf6EHcPm7Pv?= =?us-ascii?Q?YfeBZ7wW52SpQf0ArFH66ODKxtInNA3I6Z6/4qCC+9emG1ao5CjAVezcJC3o?= =?us-ascii?Q?hKV4DXJfUWqvnSIZxRJv8+TOqf7vbBm+i+SJM/ClY9MdsxsqfZ+HEkG9IxVz?= =?us-ascii?Q?ZKzHWapGD2b30GEzWrRGgMdolQdeDTNo+ANx9+orxJ5xuz7htDqbM/L1L9xJ?= =?us-ascii?Q?UdfpUB29AXJh/5CHyLJiou7Ebj/LfmtRi+4k5aVitVOSIGx1+lpzNE9+HOq3?= =?us-ascii?Q?G3408QZbC/Mxp4HwOYJOa62QI3zDCC2LPCjafa0Hf7PaEpUE68OTsvHy8gAd?= =?us-ascii?Q?xao7yfEj+UFLNWICEWXnmhYclXOF80NZOuywxzkDCRQMio0lIExIKRaRmL0s?= =?us-ascii?Q?4Iq272iNHGfZaGr+fUMvTSy9gsUyiYRp8zBKAThW3ms+I64v2k5DzHCt/Pk+?= =?us-ascii?Q?2kRS3b8MbMze/5AB7DS9cSiwweOGLzOG96BfxwogwmsyAAhJ1Yr2W71zxyrf?= =?us-ascii?Q?MyIyG2vykWcSuipHpRhrCbPm2Ay/yrDxqpPEQgl4UtNF7odsZBG7GfAJlebp?= =?us-ascii?Q?6Au9T7Ag52O6NTfbP9h0Lt6sHc+wWRixNZDKRKaJB1k9k7Aja7brsthGyYQ2?= =?us-ascii?Q?xihvtROlJo/enp446Z+FXB8t0zCw+iStjFU19g5ki/IjUmxj8C72UtBXSVpC?= =?us-ascii?Q?KKYmiQTDN01Y5Dn/6t8Syhj7gXiQiPYyq5jMIzGWzZSdPHJ4gbKqPf1b++LP?= =?us-ascii?Q?kuw0uAwL1dLq80ND8vmVnnFYNa2+cminQ4wuiCj4HEnD40phCO9JbVz4/rKa?= =?us-ascii?Q?k/Tvs8uhVbotEF1rreKmO0m3uwTDM0B+BXy/n9WnApgWdspXqstc8ML2Y2gS?= =?us-ascii?Q?sO9bZnJVCagKgXGGPFd3R4tbWbgExuRQWXV6fgc0VOpUYnnNrHZ/dZb654za?= =?us-ascii?Q?8CL17gPyTRGKlYmj828sXDeJFn62cdwnFrRmiPZBF4dHWLuGalVnLhHzNx3q?= =?us-ascii?Q?igGgrmE=3D?= X-Microsoft-Exchange-Diagnostics: 1; BN1AFFO11HUB031; 3:eJXZZTW3R9k411R0RBAEr98zY0uMB6hU4tZX6I7+BSc5t09eJIFdssxtOteDqUR+8UTW2M4x9b0AbtbwxmsCOa3FpUGekXHJx7+Qp7PZSQTSjwxZUu96LrcwhE2d40Zhte5tUN0K6HGfbWAIQNyrgA==; 10:MRfR2+hKq5SIF5NV7DOoiJN85oF/mSpWQbSRV46G2tjljxxBVAvYZHWrIHqXXsJ6uZETIlwnr7I63MBcflwn6ZgAWPv7YS2A04j/SjTGoNI= X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Jun 2015 15:18:28.8423 (UTC) X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c; Ip=[149.199.60.83]; Helo=[xsj-pvapsmtpgw01] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN1AFFO11HUB031 Sender: linux-i2c-owner@vger.kernel.org Precedence: bulk List-ID: <linux-i2c.vger.kernel.org> X-Mailing-List: linux-i2c@vger.kernel.org |
diff --git a/drivers/i2c/busses/i2c-xiic.c b/drivers/i2c/busses/i2c-xiic.c index 92ea52a..d9501ab 100644 --- a/drivers/i2c/busses/i2c-xiic.c +++ b/drivers/i2c/busses/i2c-xiic.c @@ -664,15 +664,8 @@ static void __xiic_start_xfer(struct xiic_i2c *i2c) static void xiic_start_xfer(struct xiic_i2c *i2c) { - unsigned long flags; - - spin_lock_irqsave(&i2c->lock, flags); - /* disable interrupts globally */ - xiic_setreg32(i2c, XIIC_DGIER_OFFSET, 0); - spin_unlock_irqrestore(&i2c->lock, flags); __xiic_start_xfer(i2c); - xiic_setreg32(i2c, XIIC_DGIER_OFFSET, XIIC_GINTR_ENABLE_MASK); } static int xiic_xfer(struct i2c_adapter *adap, struct i2c_msg *msgs, int num)
Currently before every transfer the interrupts are disabled. So incase the slave nacks in the middle of the transfer the current transfer is not aborted. Upon enabling the interrupts conditions like NACK , arbitration lost will not be masked. Remove the disabling of the interrupts. Signed-off-by: Shubhrajyoti Datta <shubhraj@xilinx.com> --- drivers/i2c/busses/i2c-xiic.c | 7 ------- 1 files changed, 0 insertions(+), 7 deletions(-)