Message ID | 1434554299-23443-2-git-send-email-shubhraj@xilinx.com |
---|---|
State | Accepted |
Headers | show
Return-Path: <linux-i2c-owner@vger.kernel.org> X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 8C62E1401EF for <incoming@patchwork.ozlabs.org>; Thu, 18 Jun 2015 01:18:39 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932530AbbFQPSi (ORCPT <rfc822;incoming@patchwork.ozlabs.org>); Wed, 17 Jun 2015 11:18:38 -0400 Received: from mail-bn1on0086.outbound.protection.outlook.com ([157.56.110.86]:43523 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932396AbbFQPSh (ORCPT <rfc822;linux-i2c@vger.kernel.org>); Wed, 17 Jun 2015 11:18:37 -0400 Received: from BN1AFFO11HUB018.protection.gbl (10.58.52.128) by BN1AFFO11HUB031.protection.gbl (10.58.52.141) with Microsoft SMTP Server (TLS) id 15.1.190.9; Wed, 17 Jun 2015 15:18:36 +0000 Received: from BN1AFFO11FD050.protection.gbl (10.58.52.31) by BN1AFFO11HUB018.protection.gbl (10.58.52.128) with Microsoft SMTP Server (TLS) id 15.1.190.9; Wed, 17 Jun 2015 15:18:30 +0000 Authentication-Results: spf=temperror (sender IP is 149.199.60.100) smtp.mailfrom=xilinx.com; vger.kernel.org; dkim=none (message not signed) header.d=none; Received-SPF: TempError (protection.outlook.com: error in processing during lookup of xilinx.com: DNS Timeout) Received: from xsj-pvapsmtpgw02 (149.199.60.100) by BN1AFFO11FD050.mail.protection.outlook.com (10.58.53.65) with Microsoft SMTP Server (TLS) id 15.1.190.9 via Frontend Transport; Wed, 17 Jun 2015 15:18:29 +0000 Received: from unknown-38-66.xilinx.com ([149.199.38.66]:35163 helo=xsj-pvapsmtp01) by xsj-pvapsmtpgw02 with esmtp (Exim 4.63) (envelope-from <shubhrajyoti.datta@xilinx.com>) id 1Z5F6i-0000CT-55 for linux-i2c@vger.kernel.org; Wed, 17 Jun 2015 08:18:28 -0700 Received: from [127.0.0.1] (helo=localhost) by xsj-pvapsmtp01 with smtp (Exim 4.63) (envelope-from <shubhrajyoti.datta@xilinx.com>) id 1Z5F6h-0002ER-Vv for linux-i2c@vger.kernel.org; Wed, 17 Jun 2015 08:18:28 -0700 Received: from xsj-pvapsmtp01 (mailman.xilinx.com [149.199.38.66]) by xsj-smtp-dlp2.xlnx.xilinx.com (8.13.8/8.13.1) with ESMTP id t5HFI3A7022757; Wed, 17 Jun 2015 08:18:03 -0700 Received: from [172.23.146.171] (helo=xhdl3763.xilinx.com) by xsj-pvapsmtp01 with esmtp (Exim 4.63) (envelope-from <shubhraj@xilinx.com>) id 1Z5F6e-0002DU-4E; Wed, 17 Jun 2015 08:18:24 -0700 Received: by xhdl3763.xilinx.com (Postfix, from userid 9049) id 510F42CE03D7; Wed, 17 Jun 2015 20:48:23 +0530 (IST) From: Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com> To: <linux-i2c@vger.kernel.org> CC: Shubhrajyoti Datta <shubhraj@xilinx.com> Subject: [PATCHv2 1/9] i2c: xiic: Remove the disabling of interrupts Date: Wed, 17 Jun 2015 20:48:11 +0530 Message-ID: <1434554299-23443-2-git-send-email-shubhraj@xilinx.com> X-Mailer: git-send-email 1.7.4 In-Reply-To: <1434554299-23443-1-git-send-email-shubhraj@xilinx.com> References: <1434554299-23443-1-git-send-email-shubhraj@xilinx.com> X-RCIS-Action: ALLOW X-TM-AS-Product-Ver: IMSS-7.1.0.1224-8.0.0.1202-21618.005 X-TM-AS-User-Approved-Sender: Yes;Yes X-EOPAttributedMessage: 0 X-Microsoft-Exchange-Diagnostics: 1; BN1AFFO11FD050; 1:5I6O3DCZ8Jg27LzMK5oMY84/+z0o/NFgEuDOeQNaCeD6bj5i4suYL6WxzbdYEh2lYWttEu14kxM2HHo9EeBnxNvJQ+wq7Jzh9tYz70nt5Yx1ovH3xGPxS7Tw1nirx9ZnoJSYn5IkR69hNDTrut0EFLXJXwVYZxQJ07+s26hDWbF8UPtMuzYaFZYov5hxA5u/dLrmCNmxhcYNYSLFtjl2YIZS6dZD6PFDBh2nf0Ws3WIoPLiu56vFMMT+HFgfezn6q7jtellfqN4Sg8w+OkeUS+uNBzKmmbGFsdcJ6RPYxvs= X-Forefront-Antispam-Report: CIP:149.199.60.100; CTRY:US; IPV:NLI; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(2980300002)(199003)(189002)(5001960100002)(50466002)(107886002)(110136002)(36386004)(189998001)(48376002)(19580395003)(19580405001)(47776003)(62966003)(450100001)(551934003)(77156002)(92566002)(46102003)(6806004)(45336002)(46386002)(63266004)(36756003)(76176999)(50986999)(103686003)(229853001)(33646002)(2950100001)(106466001)(2351001)(50226001)(42186005)(87936001)(86362001)(52956003)(107986001)(90966001)(4001430100001); DIR:OUT; SFP:1101; SCL:1; SRVR:BN1AFFO11HUB018; H:xsj-pvapsmtpgw02; FPR:; SPF:Pass; MLV:ovrnspm; A:1; MX:1; PTR:xapps1.xilinx.com,unknown-60-100.xilinx.com; LANG:en; MIME-Version: 1.0 Content-Type: text/plain X-Microsoft-Exchange-Diagnostics: 1; BN1AFFO11HUB018; 2:Oy/ZR5kI5JANI9OHO6nZJEVy1MUl7xOmaV8KOSMNvgbm9zonsterbeS8qOvH4FCa; 2:DdB+zoitWUrDNgLEk4zwy/S8YW5s+alP0xocaCbsNyn1Xd6WMkB5rXWOyp+KzgQknMp5lSHIvanVydHXSwjnctgMGsf0ExI8HMTMgjHdSVi6Z3wrv2PcR8jLvzwwen7Bx0J2K/oBvxmg/U4Iim4HbvggrAGF0z7iFKxGmpX9KisfyWUGLuzc7KV4/Pp7qHtwr6PHAvVltoRUzUJs8/sDwoTMbVI3Wl9zu459KeOtAdl4KUFaz2Eb+EB8duM/HCqA; 6:cclBk6zSwWc/3tTSCwRry+kqotRkIS55aXanStaJR7CqM58RZHFySyShcDLRvWA6Mtnc+8gz7sX5C3l1ySyyURbhcHItqrjpdvyNZHbS2/1Z52F4kEX0E5pgbJZAfnElsYZ1OocimPjVd8oD0UNMBZvI8zBPzaBMea50XrStZrgIrFiA3H9etI1h6o+7g9VwHYrN27nDGwzEtze4vtYjEeb5tYX0hyMMFayTdBJmK2t82ofTUY8xAZpw5VMprHsNTdkypINsuRzv7PqvLqRjKldII/NoPSd6YUQuJlbJ5PeLk+tJ1kcWMkcg48lbm9lONU5l8Aafz3Kqler11Qo30NkMXZG6qY/ffqpqzOnHmHEUfF8n3T0UJjncwcrZtd4E18XeUrpel+Rc/ZTptrmVn5hyAt3aqLZDnW9M02YOcahViz++3vAOGeNIlokUjue9nouyUnPeYAH5CrFUbxVVIiQro/bGLC6yui/c221jPD8f48V7+TgItDKgkK8VcTAg X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:; SRVR:BN1AFFO11HUB018; UriScan:; BCL:0; PCL:0; RULEID:; SRVR:BN1AFFO11HUB031; X-Microsoft-Antispam-PRVS: <BN1AFFO11HUB018A6A5BD86E3D228A949D0EBA60@BN1AFFO11HUB018.protection.gbl> X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(601004)(520003)(5005006)(3002001); SRVR:BN1AFFO11HUB018; BCL:0; PCL:0; RULEID:; SRVR:BN1AFFO11HUB018; X-Microsoft-Exchange-Diagnostics: 1; BN1AFFO11HUB018; 3:Eeth+YZSsKd4CTZVnKKH1yvLWAnuaNeStKJwztglu4X0FR2zt0yrkLVY1DBx2TIfGCWEMU0ySlm+gXzptbzqPstOQ/0SFGNVfkhcSXxvyZ8mhqSISRc2Mn8XjmSj7KKXh/tIzmKX5rVSw7+xoiduwPOX8fiQebwK59Jcaj3TFYBWMSffc9lc5uf4BViSodXA2LJoL3ux7VoowZHQuw/J9kUPhdlWr8T+Xvd4o40H2n9HK4BI/yL0x7zsYI/hhPiTwUX1lwcTJx+HABW9bXVyciZaaVOb7KINPdEA6fll3G4IKIQbhNlo0o6BRXBySsb6 X-Forefront-PRVS: 0610D16BBE X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BN1AFFO11HUB018; 9:zNt0PErSVaiiVfbCMhpJqN3mKiYaASoenwa7Jufz?= =?us-ascii?Q?EM+78fyENFqstsQuWoV4+lJxNrli7qg+pItu/qMZlQdJ75reKwqXWSvfgj8O?= =?us-ascii?Q?pvseTXDZwW/AREWnG2aqCv0nmvnrp5P3soTxZ+g58ykcb56bNk3TbUz7M4jy?= =?us-ascii?Q?Txg1whCuT285OvkELFx8/+E0m2u18oOwv3hw1UVh998CTZYZYcXvl8wFReqj?= =?us-ascii?Q?Qzm2F8ArAzjPL2kNN5qmWckHmyBMn21piBVgHonJDjd7PKk1jaGFX2KSrv+P?= =?us-ascii?Q?KAqt+fHJ12dI+Pa/ER7Lusaj01bNCjbCPmGfLIDkGihAF3CT+j06qQpf9Yqd?= =?us-ascii?Q?+O1plzqM5ZKSEiIpT/9YepHFIjY9xm7aFeh9Ytp5JnXofmmgs2iROoylZAKF?= =?us-ascii?Q?SwYCHblLH7kgv4US9sO2ot97ngqI+fuZ+U2ejecyVvGerjd2zYfEgBS2BJYU?= =?us-ascii?Q?9yxEQTecERjosDxPS/GR7QW1qR87pxPGHLpMZLi4vF26PVN6gbOgcT9S1yT3?= =?us-ascii?Q?edj0NdhF3NsZ+o6RZHNSVh11Bkx4x3ng+JnPgNZ0Uclgvh9/KxQlOeUmpldQ?= =?us-ascii?Q?fbc9jAOOslvJfo13s9xS8Fr9pEUrwXAUV96tS6HSp9mDVublkyaDR7jIHzNx?= =?us-ascii?Q?+D+KuueTwp4am/vDk712HEjYUS4JRiCr6gBRncwr28Pu+fM+/dBY4Dc8jIvV?= =?us-ascii?Q?d9zrhQqDRrTtTsXhjNFU43hYYetpaByUNMta887s+6hTQ98371Pm1RDrLkh6?= =?us-ascii?Q?VXLpLY1jOopjvJ/BFgELx/K0a1RBgQg1ZizS9ZmCyiR53mhigZDWFHcmL3rj?= =?us-ascii?Q?FbIsR1aekfI2/rITL4/YvPCGL7Wio2M75/mqjPe6cMob5cud+wFQvo780HCk?= =?us-ascii?Q?18e6pYcoiF5pTMlQdI+c0dT2kbR7p3E5T085RkqfZj/rlR9q2avvzRLwcDpB?= =?us-ascii?Q?knjFehXNuh2ouxIOlYLiWcSAy2RKPo6mQG+3JKPn136WQ9hWM7fOtI24+Inx?= =?us-ascii?Q?7+SWH41T4QLxqEoJik3KXUt13ubnUJzPiq7dzH4Z5pdqWPR15dceh4wHP4ol?= =?us-ascii?Q?29GzoiY=3D?= X-Microsoft-Exchange-Diagnostics: 1; BN1AFFO11HUB018; 3:DmIIIGieu6raW/bcu+zhLZ1pWBcy5XJ4tJQLRYfht2b0BIXeHaHP4++eVpHXzPQD80RFMjDbv4K37K5NdeLtY5L8yqwqcjejamXfB7kSon4XzegpprPCRYPxqJ/rFMoOwh386NtXgUmxLub1ql53Sw==; 10:PF1fusLKhWVeuNYYs250ojU+SX6vwFE9kX7Evz+lkSnpYDTQWLbqGMdidfBxcjXo4wlsS8X28ImcMdNgsJGpyZ7wmSfb1Ckx2MY1Hwpl9Lc= X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Jun 2015 15:18:29.0374 (UTC) X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c; Ip=[149.199.60.100]; Helo=[xsj-pvapsmtpgw02] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN1AFFO11HUB018 X-Microsoft-Exchange-Diagnostics: 1; BN1AFFO11HUB031; 2:RL1pvbL3QNESsDfEzE5+1mgdL+U+wjjMnElw9HK2BKmf9MCLfh7Vb3oT4lDwwTuf; 2:148uHtfj9VgoZdjr3XiMeGu/T2AbaD/Kr1rsxf7c6n6jpakh76e8vl72p+B+cfVUpgEVZsTOb56aMc4hkyeQCOYjuJNyClX4Cmb5RtLJlFZMI2+RwzWCQJI9EzbFAct61EYS6MSL2bIRM2KvQI2YtZbVNJNO7qZX+M6M8ZEhXA4krdFnudFKCyUwc65988S+sKrKLSfl1oz0sy5YuDKN1+xmgN+0AOZpyoH6Rp2vqo58DQ7Nz9rT6OCtbMovKs0X; 9:xxTWVpW2d7XyTFhOSQO7vr6bjyVvFIihqZs0XjWVB61hP1vZAzOXYU205ZfRtZlGht79GHuCCMSCQpBYL93Q6hIRHSKXCtLcGwIx5HtoxMFPyGS6Iq6AV8oSN6zfslPz6CEC5iWN34HUv+FjlDiBhA== X-OriginatorOrg: xilinx.com Sender: linux-i2c-owner@vger.kernel.org Precedence: bulk List-ID: <linux-i2c.vger.kernel.org> X-Mailing-List: linux-i2c@vger.kernel.org |
diff --git a/drivers/i2c/busses/i2c-xiic.c b/drivers/i2c/busses/i2c-xiic.c index 4dda23f..912780a 100644 --- a/drivers/i2c/busses/i2c-xiic.c +++ b/drivers/i2c/busses/i2c-xiic.c @@ -604,14 +604,11 @@ static irqreturn_t xiic_isr(int irq, void *dev_id) struct xiic_i2c *i2c = dev_id; spin_lock(&i2c->lock); - /* disable interrupts globally */ - xiic_setreg32(i2c, XIIC_DGIER_OFFSET, 0); dev_dbg(i2c->adap.dev.parent, "%s entry\n", __func__); xiic_process(i2c); - xiic_setreg32(i2c, XIIC_DGIER_OFFSET, XIIC_GINTR_ENABLE_MASK); spin_unlock(&i2c->lock); return IRQ_HANDLED;
Currently the interrupts are disabled at the start of the isr and enabled at the end of the isr. Remove the same. In case the slave device NACKs the transaction while in the isr the transfer will continue and the NACK interrupt will arrive only after the isr is serviced. Signed-off-by: Shubhrajyoti Datta <shubhraj@xilinx.com> --- drivers/i2c/busses/i2c-xiic.c | 3 --- 1 files changed, 0 insertions(+), 3 deletions(-)