diff mbox

[04/16] i2c: eg20t: remove unnecessary OOM messages

Message ID 018801cf69ab$70a79a30$51f6ce90$%han@samsung.com
State Superseded
Headers show

Commit Message

Jingoo Han May 7, 2014, 4:18 a.m. UTC 
The site-specific OOM messages are unnecessary, because they
duplicate the MM subsystem generic OOM message.

Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
 drivers/i2c/busses/i2c-eg20t.c |    4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

Comments

Jean Delvare May 7, 2014, 7:20 a.m. UTC | #1 
On Wed, 07 May 2014 13:18:46 +0900, Jingoo Han wrote:
> The site-specific OOM messages are unnecessary, because they
> duplicate the MM subsystem generic OOM message.
> 
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> ---
>  drivers/i2c/busses/i2c-eg20t.c |    4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/i2c/busses/i2c-eg20t.c b/drivers/i2c/busses/i2c-eg20t.c
> index ff775ac..a44ea13 100644
> --- a/drivers/i2c/busses/i2c-eg20t.c
> +++ b/drivers/i2c/busses/i2c-eg20t.c
> @@ -751,10 +751,8 @@ static int pch_i2c_probe(struct pci_dev *pdev,
>  	pch_pci_dbg(pdev, "Entered.\n");
>  
>  	adap_info = kzalloc((sizeof(struct adapter_info)), GFP_KERNEL);
> -	if (adap_info == NULL) {
> -		pch_pci_err(pdev, "Memory allocation FAILED\n");
> +	if (adap_info == NULL)
>  		return -ENOMEM;
> -	}
>  
>  	ret = pci_enable_device(pdev);
>  	if (ret) {

Reviewed-by: Jean Delvare <jdelvare@suse.de>
diff mbox

Patch

diff --git a/drivers/i2c/busses/i2c-eg20t.c b/drivers/i2c/busses/i2c-eg20t.c
index ff775ac..a44ea13 100644
--- a/drivers/i2c/busses/i2c-eg20t.c
+++ b/drivers/i2c/busses/i2c-eg20t.c
@@ -751,10 +751,8 @@  static int pch_i2c_probe(struct pci_dev *pdev,
 	pch_pci_dbg(pdev, "Entered.\n");
 
 	adap_info = kzalloc((sizeof(struct adapter_info)), GFP_KERNEL);
-	if (adap_info == NULL) {
-		pch_pci_err(pdev, "Memory allocation FAILED\n");
+	if (adap_info == NULL)
 		return -ENOMEM;
-	}
 
 	ret = pci_enable_device(pdev);
 	if (ret) {