mbox series

[RFC,0/2] Add I2C fwnode lookup/get interfaces

Message ID Y5B3S6KZTrYlIH8g@shell.armlinux.org.uk
Headers show
Series Add I2C fwnode lookup/get interfaces | expand

Message

Russell King (Oracle) Dec. 7, 2022, 11:21 a.m. UTC 
Hi,

This RFC series is not intended for the coming merge window, and we
will need to decide how to merge it as it is split across two
subsystems. These patches have been generated against the net-next,
since patch 2 depends on a recently merged patch in that tree.

Currently, the SFP code attempts to work out what kind of fwnode we
found when looking up the I2C bus for the SFP cage, converts the fwnode
to the appropriate firmware specific representation to then call the
appropriate I2C layer function. This is inefficient, since the device
model provides a way to locate items on a bus_type by fwnode.

In order to reduce this complexity, this series adds fwnode interfaces
to the I2C subsystem to allow I2C adapters to be looked up. I also
accidentally also converted the I2C clients to also be looked up, so
I've left that in patch 1 if people think that could be useful - if
not, I'll remove it.

We could also convert the of_* functions to be inline in i2c.h and
remove the stub of_* functions and exports.

Do we want these to live in i2c-core-fwnode.c ? I don't see a Kconfig
symbol that indicates whether we want fwnode support, and I know there
are people looking to use software nodes to lookup the SFP I2C bus
(which is why the manual firmware-specific code in sfp.c is a problem.)

Thanks!

 drivers/i2c/i2c-core-acpi.c | 13 +-------
 drivers/i2c/i2c-core-base.c | 72 +++++++++++++++++++++++++++++++++++++++++++++
 drivers/i2c/i2c-core-of.c   | 51 ++------------------------------
 drivers/net/phy/sfp.c       | 13 +-------
 include/linux/i2c.h         |  9 ++++++
 5 files changed, 86 insertions(+), 72 deletions(-)