mbox series

[RESEND,v6,0/6] add i2c support for mt8183

Message ID 1554208560-14817-1-git-send-email-qii.wang@mediatek.com
Headers show
Series add i2c support for mt8183 | expand

Message

Qii Wang April 2, 2019, 12:35 p.m. UTC 
This series are based on 5.1-rc1 and the patch
https://patchwork.kernel.org/patch/10856987/(for dts)
We provide six patches to support mt8183 IC.

Main changes compared to v5:
--add i2c controller nodes in mt8183.dtsi
--add a note that old i2c controllers also have I2C_ARB_LOST bit
--add a flag(ltiming_adjust) to avoid unnecessary settings
--add Reviewed-by from Rob Herring, Nicolas and Matthias

Main changes compared to v4:
--modify the commit of arb clock dt-binding
--split a patch(3/3) into three(3/5 4/5 5/5)

Main changes compared to v3:
--remove the patches which have been applied to for-next
--remove i2c fallback for i3c controller 

Main changes compared to v2:
--update commit message
--add Reviewed-by from Rob Herring, Nicolas and Sean

Main changes compared to v1:
--remove useless dt-binding for mt7629
--split a patch into two(2/6 3/6)
--muti-user feature was dropped

Qii Wang (6):
  i2c: mediatek: Add offsets array for new i2c registers
  dt-bindings: i2c: Add Mediatek MT8183 i2c binding
  i2c: mediatek: Add arb clock in i2c driver
  i2c: mediatek: Add i2c and apdma sync in i2c driver
  i2c: mediatek: Add i2c support for MediaTek MT8183
  dts: arm64: mt8183: Add I2C nodes

 Documentation/devicetree/bindings/i2c/i2c-mtk.txt |    4 +-
 arch/arm64/boot/dts/mediatek/mt8183.dtsi          |  192 ++++++++++++++++
 drivers/i2c/busses/i2c-mt65xx.c                   |  255 ++++++++++++++++-----
 3 files changed, 389 insertions(+), 62 deletions(-)

Comments

Wolfram Sang April 4, 2019, 11:09 p.m. UTC | #1 
On Tue, Apr 02, 2019 at 08:35:54PM +0800, Qii Wang wrote:
> This series are based on 5.1-rc1 and the patch
> https://patchwork.kernel.org/patch/10856987/(for dts)
> We provide six patches to support mt8183 IC.
> 
> Main changes compared to v5:
> --add i2c controller nodes in mt8183.dtsi
> --add a note that old i2c controllers also have I2C_ARB_LOST bit
> --add a flag(ltiming_adjust) to avoid unnecessary settings
> --add Reviewed-by from Rob Herring, Nicolas and Matthias

Well, it seems you missed Rob's Rev-by. No need to resend, I can add it.
I just wonder if Matthias wants to have another look at this?
Wolfram Sang April 15, 2019, 11:30 a.m. UTC | #2 
On Fri, Apr 05, 2019 at 01:09:16AM +0200, Wolfram Sang wrote:
> On Tue, Apr 02, 2019 at 08:35:54PM +0800, Qii Wang wrote:
> > This series are based on 5.1-rc1 and the patch
> > https://patchwork.kernel.org/patch/10856987/(for dts)
> > We provide six patches to support mt8183 IC.
> > 
> > Main changes compared to v5:
> > --add i2c controller nodes in mt8183.dtsi
> > --add a note that old i2c controllers also have I2C_ARB_LOST bit
> > --add a flag(ltiming_adjust) to avoid unnecessary settings
> > --add Reviewed-by from Rob Herring, Nicolas and Matthias
> 
> Well, it seems you missed Rob's Rev-by. No need to resend, I can add it.
> I just wonder if Matthias wants to have another look at this?

Thanks Matthias! Patches 1-5 applied to for-next.