| Message ID | bc393b14b1edb86aa873ef43ed81fa6ad7e94fcd.1551966077.git.jan.kundrat@cesnet.cz |
|---|---|
| State | New |
| Headers | show |
| Series | mcp23s08 fixes | expand |
On Thu, Mar 7, 2019 at 2:57 PM Jan Kundrát <jan.kundrat@cesnet.cz> wrote: > It is expected that some of these operations won't work on each and > every HW. Previously, even a simple `cat > /sys/kernel/debug/pinctrl/spi1.1/pinconf-pins` caused excessive dmesg > output. > > Signed-off-by: Jan Kundrát <jan.kundrat@cesnet.cz> > Cc: Phil Reid <preid@electromag.com.au> > Cc: Sebastian Reichel <sebastian.reichel@collabora.co.uk> > Cc: Linus Walleij <linus.walleij@linaro.org> > --- > v2: In the set path, just downgrade to dev_dbg instead of removing the > log altogether based on Phil's and Linus' feedback. Patch applied for fixes. Yours, Linus Walleij
diff --git a/drivers/pinctrl/pinctrl-mcp23s08.c b/drivers/pinctrl/pinctrl-mcp23s08.c index 5d7a8514def9..fd9d6f026d70 100644 --- a/drivers/pinctrl/pinctrl-mcp23s08.c +++ b/drivers/pinctrl/pinctrl-mcp23s08.c @@ -266,7 +266,6 @@ static int mcp_pinconf_get(struct pinctrl_dev *pctldev, unsigned int pin, status = (data & BIT(pin)) ? 1 : 0; break; default: - dev_err(mcp->dev, "Invalid config param %04x\n", param); return -ENOTSUPP; } @@ -293,7 +292,7 @@ static int mcp_pinconf_set(struct pinctrl_dev *pctldev, unsigned int pin, ret = mcp_set_bit(mcp, MCP_GPPU, pin, arg); break; default: - dev_err(mcp->dev, "Invalid config param %04x\n", param); + dev_dbg(mcp->dev, "Invalid config param %04x\n", param); return -ENOTSUPP; } }
It is expected that some of these operations won't work on each and every HW. Previously, even a simple `cat /sys/kernel/debug/pinctrl/spi1.1/pinconf-pins` caused excessive dmesg output. Signed-off-by: Jan Kundrát <jan.kundrat@cesnet.cz> Cc: Phil Reid <preid@electromag.com.au> Cc: Sebastian Reichel <sebastian.reichel@collabora.co.uk> Cc: Linus Walleij <linus.walleij@linaro.org> --- v2: In the set path, just downgrade to dev_dbg instead of removing the log altogether based on Phil's and Linus' feedback. --- drivers/pinctrl/pinctrl-mcp23s08.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)