diff mbox series

[2/4] gpiolib: export devprop_gpiochip_set_names()

Message ID 32d5f815885b93d8b806471bf1e214924a1d2372.1551966077.git.jan.kundrat@cesnet.cz
State New
Headers show
Series mcp23s08 fixes | expand

Commit Message

Jan Kundrát March 7, 2019, 1:30 p.m. UTC
This function is needed in mcp23s08. That driver is a special snowflake
because it supports several hardware chips as a single "GPIO chip" under
Linux.

Signed-off-by: Jan Kundrát <jan.kundrat@cesnet.cz>
Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: Mika Westerberg <mika.westerberg@linux.intel.com>
Cc: Phil Reid <preid@electromag.com.au>
---
 drivers/gpio/gpiolib-devprop.c | 2 ++
 drivers/gpio/gpiolib.h         | 3 ---
 include/linux/gpio/driver.h    | 3 +++
 3 files changed, 5 insertions(+), 3 deletions(-)

Comments

Mika Westerberg March 7, 2019, 3:04 p.m. UTC | #1
On Thu, Mar 07, 2019 at 02:30:13PM +0100, Jan Kundrát wrote:
> This function is needed in mcp23s08. That driver is a special snowflake
> because it supports several hardware chips as a single "GPIO chip" under
> Linux.
> 
> Signed-off-by: Jan Kundrát <jan.kundrat@cesnet.cz>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: Mika Westerberg <mika.westerberg@linux.intel.com>

Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Linus Walleij March 24, 2019, 3:49 a.m. UTC | #2
On Thu, Mar 7, 2019 at 2:57 PM Jan Kundrát <jan.kundrat@cesnet.cz> wrote:

> This function is needed in mcp23s08. That driver is a special snowflake
> because it supports several hardware chips as a single "GPIO chip" under
> Linux.
>
> Signed-off-by: Jan Kundrát <jan.kundrat@cesnet.cz>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: Mika Westerberg <mika.westerberg@linux.intel.com>
> Cc: Phil Reid <preid@electromag.com.au>

Patch applied with Mika's ACK.

Yours,
Linus Walleij
diff mbox series

Patch

diff --git a/drivers/gpio/gpiolib-devprop.c b/drivers/gpio/gpiolib-devprop.c
index dd517098ab95..0c6f97c09bd9 100644
--- a/drivers/gpio/gpiolib-devprop.c
+++ b/drivers/gpio/gpiolib-devprop.c
@@ -56,3 +56,5 @@  void devprop_gpiochip_set_names(struct gpio_chip *chip,
 
 	kfree(names);
 }
+
+EXPORT_SYMBOL_GPL(devprop_gpiochip_set_names)
diff --git a/drivers/gpio/gpiolib.h b/drivers/gpio/gpiolib.h
index bc57f0dc5953..0c512900752d 100644
--- a/drivers/gpio/gpiolib.h
+++ b/drivers/gpio/gpiolib.h
@@ -241,9 +241,6 @@  static inline int gpio_chip_hwgpio(const struct gpio_desc *desc)
 	return desc - &desc->gdev->descs[0];
 }
 
-void devprop_gpiochip_set_names(struct gpio_chip *chip,
-				const struct fwnode_handle *fwnode);
-
 /* With descriptor prefix */
 
 #define gpiod_emerg(desc, fmt, ...)					       \
diff --git a/include/linux/gpio/driver.h b/include/linux/gpio/driver.h
index 07cddbf45186..92a222646447 100644
--- a/include/linux/gpio/driver.h
+++ b/include/linux/gpio/driver.h
@@ -609,6 +609,9 @@  struct gpio_desc *gpiochip_request_own_desc(struct gpio_chip *chip, u16 hwnum,
 					    enum gpiod_flags flags);
 void gpiochip_free_own_desc(struct gpio_desc *desc);
 
+void devprop_gpiochip_set_names(struct gpio_chip *chip,
+				const struct fwnode_handle *fwnode);
+
 #else /* CONFIG_GPIOLIB */
 
 static inline struct gpio_chip *gpiod_to_chip(const struct gpio_desc *desc)