| Message ID | 20211117231614.758362-3-hdegoede@redhat.com |
|---|---|
| State | New |
| Headers | show |
| Series | [1/3] pinctrl: cherryview: Don't use pin/offset 0 to mark an interrupt-line as unused | expand |
On Thu, Nov 18, 2021 at 12:16:14AM +0100, Hans de Goede wrote: > Many Cherry Trail DSDTs have an extra INT33FF device with UID 5, > the intel_pinctrl_get_soc_data() call will fail for this extra > unknown UID, leading to the following error in dmesg: Yeah, this may be the "DSW" or Deep Sleep Well community that is typically not available for software to use at all. No idea why they expose it on some systems. > cherryview-pinctrl: probe of INT33FF:04 failed with error -61 > > Add a check for this extra UID and return -ENODEV for it to > silence this false-positive error message. > > Cc: Yauhen Kharuzhy <jekhor@gmail.com> > Signed-off-by: Hans de Goede <hdegoede@redhat.com> Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>
diff --git a/drivers/pinctrl/intel/pinctrl-cherryview.c b/drivers/pinctrl/intel/pinctrl-cherryview.c index 491b234812cd..ca6fe6115ecb 100644 --- a/drivers/pinctrl/intel/pinctrl-cherryview.c +++ b/drivers/pinctrl/intel/pinctrl-cherryview.c @@ -1686,6 +1686,10 @@ static int chv_pinctrl_probe(struct platform_device *pdev) acpi_status status; int i, ret, irq; + /* Cherry Trail DSDTs have an extra INT33FF device with UID 5, ignore */ + if (!strcmp(adev->pnp.unique_id, "5")) + return -ENODEV; + soc_data = intel_pinctrl_get_soc_data(pdev); if (IS_ERR(soc_data)) return PTR_ERR(soc_data);
Many Cherry Trail DSDTs have an extra INT33FF device with UID 5, the intel_pinctrl_get_soc_data() call will fail for this extra unknown UID, leading to the following error in dmesg: cherryview-pinctrl: probe of INT33FF:04 failed with error -61 Add a check for this extra UID and return -ENODEV for it to silence this false-positive error message. Cc: Yauhen Kharuzhy <jekhor@gmail.com> Signed-off-by: Hans de Goede <hdegoede@redhat.com> --- drivers/pinctrl/intel/pinctrl-cherryview.c | 4 ++++ 1 file changed, 4 insertions(+)