From patchwork Wed Nov 17 23:16:14 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hans de Goede X-Patchwork-Id: 1556431 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: bilbo.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=C5s2HC1V; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=linux-gpio-owner@vger.kernel.org; receiver=) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by bilbo.ozlabs.org (Postfix) with ESMTP id 4Hvf233ycyz9sPf for ; Thu, 18 Nov 2021 10:16:27 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231776AbhKQXT0 (ORCPT ); Wed, 17 Nov 2021 18:19:26 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:40106 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241523AbhKQXTZ (ORCPT ); Wed, 17 Nov 2021 18:19:25 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1637190985; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4L6fYkm3itlF64N4oeIyQNxJtyJbr/iAzdlnWwlNS3w=; b=C5s2HC1VN8ceXXzIU4WxAFUlpQpeBp1xhfcAw0K0aM+u9bbsp896D0tFZE11ncLAgHUf4d GCugkpZJd6oB6GznCX5FcDwtHKcoSA6847tk643PJAq9A2JtNDjeb9MafpcRksO0aPmU6b C1HRK+dsiCsPPJSdSjMzdsMTqGNZeZk= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-228-9UyRdRXPM3G1EqI8qLDZvA-1; Wed, 17 Nov 2021 18:16:22 -0500 X-MC-Unique: 9UyRdRXPM3G1EqI8qLDZvA-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 76F4A100C660; Wed, 17 Nov 2021 23:16:21 +0000 (UTC) Received: from x1.localdomain.com (unknown [10.39.192.15]) by smtp.corp.redhat.com (Postfix) with ESMTP id 05D2B10023B8; Wed, 17 Nov 2021 23:16:19 +0000 (UTC) From: Hans de Goede To: Mika Westerberg , Andy Shevchenko , Linus Walleij Cc: Hans de Goede , linux-gpio@vger.kernel.org, linux-acpi@vger.kernel.org, Yauhen Kharuzhy Subject: [PATCH 3/3] pinctrl: cherryview: Ignore INT33FF UID 5 ACPI device Date: Thu, 18 Nov 2021 00:16:14 +0100 Message-Id: <20211117231614.758362-3-hdegoede@redhat.com> In-Reply-To: <20211117231614.758362-1-hdegoede@redhat.com> References: <20211117231614.758362-1-hdegoede@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org Many Cherry Trail DSDTs have an extra INT33FF device with UID 5, the intel_pinctrl_get_soc_data() call will fail for this extra unknown UID, leading to the following error in dmesg: cherryview-pinctrl: probe of INT33FF:04 failed with error -61 Add a check for this extra UID and return -ENODEV for it to silence this false-positive error message. Cc: Yauhen Kharuzhy Signed-off-by: Hans de Goede Acked-by: Mika Westerberg --- drivers/pinctrl/intel/pinctrl-cherryview.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/pinctrl/intel/pinctrl-cherryview.c b/drivers/pinctrl/intel/pinctrl-cherryview.c index 491b234812cd..ca6fe6115ecb 100644 --- a/drivers/pinctrl/intel/pinctrl-cherryview.c +++ b/drivers/pinctrl/intel/pinctrl-cherryview.c @@ -1686,6 +1686,10 @@ static int chv_pinctrl_probe(struct platform_device *pdev) acpi_status status; int i, ret, irq; + /* Cherry Trail DSDTs have an extra INT33FF device with UID 5, ignore */ + if (!strcmp(adev->pnp.unique_id, "5")) + return -ENODEV; + soc_data = intel_pinctrl_get_soc_data(pdev); if (IS_ERR(soc_data)) return PTR_ERR(soc_data);