[v2,03/24] pinctrl: lynxpoint: Correct amount of pins

Message ID	20191209130926.86483-4-andriy.shevchenko@linux.intel.com
State	New
Headers	show Return-Path: <linux-gpio-owner@vger.kernel.org> From: Andy Shevchenko <andriy.shevchenko@linux.intel.com> To: Linus Walleij <linus.walleij@linaro.org>, Bartosz Golaszewski <bgolaszewski@baylibre.com>, linux-gpio@vger.kernel.org, Mika Westerberg <mika.westerberg@linux.intel.com> Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Subject: [PATCH v2 03/24] pinctrl: lynxpoint: Correct amount of pins Date: Mon, 9 Dec 2019 15:09:05 +0200 Message-Id: <20191209130926.86483-4-andriy.shevchenko@linux.intel.com> In-Reply-To: <20191209130926.86483-1-andriy.shevchenko@linux.intel.com> References: <20191209130926.86483-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk
Series	pinctrl: intel: Move Lynxpoint to pin control umbrella \| expand [v2,00/24] pinctrl: intel: Move Lynxpoint to pin control umbrella [v2,01/24] pinctrl: lynxpoint: Move GPIO driver to pin controller folder [v2,02/24] pinctrl: lynxpoint: Use raw_spinlock for locking [v2,03/24] pinctrl: lynxpoint: Correct amount of pins [v2,04/24] pinctrl: lynxpoint: Drop useless assignment [v2,05/24] pinctrl: lynxpoint: Use %pR to print IO resource [v2,06/24] pinctrl: lynxpoint: Use standard pattern for memory allocation [v2,07/24] pinctrl: lynxpoint: Assume 2 bits for mode selector [v2,08/24] pinctrl: lynxpoint: Relax GPIO request rules [v2,09/24] pinctrl: lynxpoint: Keep pointer to struct device instead of its container [v2,10/24] pinctrl: lynxpoint: Switch to memory mapped IO accessors [v2,11/24] pinctrl: lynxpoint: Convert unsigned to unsigned int [v2,12/24] pinctrl: lynxpoint: Extract lp_gpio_acpi_use() for future use [v2,13/24] pinctrl: lynxpoint: Move ->remove closer to ->probe() [v2,14/24] pinctrl: lynxpoint: Move lp_irq_type() closer to IRQ related routines [v2,15/24] pinctrl: lynxpoint: Move ownership check to IRQ chip [v2,16/24] pinctrl: lynxpoint: Implement ->irq_ack() callback [v2,17/24] pinctrl: lynxpoint: Implement intel_gpio_get_direction callback [v2,18/24] pinctrl: lynxpoint: Add pin control data structures [v2,19/24] pinctrl: lynxpoint: Reuse struct intel_pinctrl in the driver [v2,20/24] pinctrl: lynxpoint: Add pin control operations [v2,21/24] pinctrl: lynxpoint: Implement ->pin_dbg_show() [v2,22/24] pinctrl: lynxpoint: Add GPIO <-> pin mapping ranges via callback [v2,23/24] pinctrl: lynxpoint: Switch to pin control API [v2,24/24] pinctrl: lynxpoint: Update summary in the driver

Message ID

20191209130926.86483-4-andriy.shevchenko@linux.intel.com

State

New

Headers

From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Linus Walleij <linus.walleij@linaro.org>,
	Bartosz Golaszewski <bgolaszewski@baylibre.com>,
	linux-gpio@vger.kernel.org,
	Mika Westerberg <mika.westerberg@linux.intel.com>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Subject: [PATCH v2 03/24] pinctrl: lynxpoint: Correct amount of pins
Date: Mon,  9 Dec 2019 15:09:05 +0200
Message-Id: <20191209130926.86483-4-andriy.shevchenko@linux.intel.com>
In-Reply-To: <20191209130926.86483-1-andriy.shevchenko@linux.intel.com>
References: <20191209130926.86483-1-andriy.shevchenko@linux.intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Sender: linux-gpio-owner@vger.kernel.org
Precedence: bulk

Series

pinctrl: intel: Move Lynxpoint to pin control umbrella | expand

Commit Message

Andy Shevchenko Dec. 9, 2019, 1:09 p.m. UTC

When we count from 0 it's possible to get into off-by-one error.
That's what had happened to this driver. So, correct amount of pins
and related typos in the code.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 drivers/pinctrl/intel/pinctrl-lynxpoint.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/pinctrl/intel/pinctrl-lynxpoint.c b/drivers/pinctrl/intel/pinctrl-lynxpoint.c
index c30fd86846a7..162fc38c929d 100644
--- a/drivers/pinctrl/intel/pinctrl-lynxpoint.c
+++ b/drivers/pinctrl/intel/pinctrl-lynxpoint.c
@@ -18,9 +18,9 @@ 
 #include <linux/slab.h>
 #include <linux/types.h>
 
-/* LynxPoint chipset has support for 94 gpio pins */
+/* LynxPoint chipset has support for 95 GPIO pins */
 
-#define LP_NUM_GPIO	94
+#define LP_NUM_GPIO	95
 
 /* Bitmapped register offsets */
 #define LP_ACPI_OWNED	0x00 /* Bitmap, set by bios, 0: pin reserved for ACPI */
@@ -54,11 +54,11 @@  struct lp_gpio {
 /*
  * Lynxpoint gpios are controlled through both bitmapped registers and
  * per gpio specific registers. The bitmapped registers are in chunks of
- * 3 x 32bit registers to cover all 94 gpios
+ * 3 x 32bit registers to cover all 95 GPIOs
  *
  * per gpio specific registers consist of two 32bit registers per gpio
- * (LP_CONFIG1 and LP_CONFIG2), with 94 gpios there's a total of
- * 188 config registers.
+ * (LP_CONFIG1 and LP_CONFIG2), with 95 GPIOs there's a total of
+ * 190 config registers.
  *
  * A simplified view of the register layout look like this:
  *
@@ -67,7 +67,7 @@  struct lp_gpio {
  * LP_ACPI_OWNED[94:64] gpio ownerships for gpios 63-94
  * ...
  * LP_INT_ENABLE[31:0] ...
- * LP_INT_ENABLE[63:31] ...
+ * LP_INT_ENABLE[63:32] ...
  * LP_INT_ENABLE[94:64] ...
  * LP0_CONFIG1 (gpio 0) config1 reg for gpio 0 (per gpio registers)
  * LP0_CONFIG2 (gpio 0) config2 reg for gpio 0

[v2,03/24] pinctrl: lynxpoint: Correct amount of pins

Commit Message

Patch