[v2,21/24] pinctrl: lynxpoint: Implement ->pin_dbg_show()

Message ID	20191209130926.86483-22-andriy.shevchenko@linux.intel.com
State	New
Headers	show Return-Path: <linux-gpio-owner@vger.kernel.org> From: Andy Shevchenko <andriy.shevchenko@linux.intel.com> To: Linus Walleij <linus.walleij@linaro.org>, Bartosz Golaszewski <bgolaszewski@baylibre.com>, linux-gpio@vger.kernel.org, Mika Westerberg <mika.westerberg@linux.intel.com> Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Subject: [PATCH v2 21/24] pinctrl: lynxpoint: Implement ->pin_dbg_show() Date: Mon, 9 Dec 2019 15:09:23 +0200 Message-Id: <20191209130926.86483-22-andriy.shevchenko@linux.intel.com> In-Reply-To: <20191209130926.86483-1-andriy.shevchenko@linux.intel.com> References: <20191209130926.86483-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk
Series	pinctrl: intel: Move Lynxpoint to pin control umbrella \| expand [v2,00/24] pinctrl: intel: Move Lynxpoint to pin control umbrella [v2,01/24] pinctrl: lynxpoint: Move GPIO driver to pin controller folder [v2,02/24] pinctrl: lynxpoint: Use raw_spinlock for locking [v2,03/24] pinctrl: lynxpoint: Correct amount of pins [v2,04/24] pinctrl: lynxpoint: Drop useless assignment [v2,05/24] pinctrl: lynxpoint: Use %pR to print IO resource [v2,06/24] pinctrl: lynxpoint: Use standard pattern for memory allocation [v2,07/24] pinctrl: lynxpoint: Assume 2 bits for mode selector [v2,08/24] pinctrl: lynxpoint: Relax GPIO request rules [v2,09/24] pinctrl: lynxpoint: Keep pointer to struct device instead of its container [v2,10/24] pinctrl: lynxpoint: Switch to memory mapped IO accessors [v2,11/24] pinctrl: lynxpoint: Convert unsigned to unsigned int [v2,12/24] pinctrl: lynxpoint: Extract lp_gpio_acpi_use() for future use [v2,13/24] pinctrl: lynxpoint: Move ->remove closer to ->probe() [v2,14/24] pinctrl: lynxpoint: Move lp_irq_type() closer to IRQ related routines [v2,15/24] pinctrl: lynxpoint: Move ownership check to IRQ chip [v2,16/24] pinctrl: lynxpoint: Implement ->irq_ack() callback [v2,17/24] pinctrl: lynxpoint: Implement intel_gpio_get_direction callback [v2,18/24] pinctrl: lynxpoint: Add pin control data structures [v2,19/24] pinctrl: lynxpoint: Reuse struct intel_pinctrl in the driver [v2,20/24] pinctrl: lynxpoint: Add pin control operations [v2,21/24] pinctrl: lynxpoint: Implement ->pin_dbg_show() [v2,22/24] pinctrl: lynxpoint: Add GPIO <-> pin mapping ranges via callback [v2,23/24] pinctrl: lynxpoint: Switch to pin control API [v2,24/24] pinctrl: lynxpoint: Update summary in the driver

Message ID

20191209130926.86483-22-andriy.shevchenko@linux.intel.com

State

New

Headers

From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Linus Walleij <linus.walleij@linaro.org>,
	Bartosz Golaszewski <bgolaszewski@baylibre.com>,
	linux-gpio@vger.kernel.org,
	Mika Westerberg <mika.westerberg@linux.intel.com>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Subject: [PATCH v2 21/24] pinctrl: lynxpoint: Implement ->pin_dbg_show()
Date: Mon,  9 Dec 2019 15:09:23 +0200
Message-Id: <20191209130926.86483-22-andriy.shevchenko@linux.intel.com>
In-Reply-To: <20191209130926.86483-1-andriy.shevchenko@linux.intel.com>
References: <20191209130926.86483-1-andriy.shevchenko@linux.intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Sender: linux-gpio-owner@vger.kernel.org
Precedence: bulk

Series

pinctrl: intel: Move Lynxpoint to pin control umbrella | expand

Commit Message

Andy Shevchenko Dec. 9, 2019, 1:09 p.m. UTC

The introduced callback ->pin_dbg_show() is useful for debugging.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 drivers/pinctrl/intel/pinctrl-lynxpoint.c | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)

diff --git a/drivers/pinctrl/intel/pinctrl-lynxpoint.c b/drivers/pinctrl/intel/pinctrl-lynxpoint.c
index c209deff9efb..bfdd283d2c20 100644
--- a/drivers/pinctrl/intel/pinctrl-lynxpoint.c
+++ b/drivers/pinctrl/intel/pinctrl-lynxpoint.c
@@ -297,10 +297,33 @@  static int lp_get_group_pins(struct pinctrl_dev *pctldev,
 	return 0;
 }
 
+static void lp_pin_dbg_show(struct pinctrl_dev *pctldev, struct seq_file *s,
+			    unsigned int pin)
+{
+	struct intel_pinctrl *lg = pinctrl_dev_get_drvdata(pctldev);
+	void __iomem *reg = lp_gpio_reg(&lg->chip, pin, LP_CONFIG1);
+	void __iomem *conf2 = lp_gpio_reg(&lg->chip, pin, LP_CONFIG2);
+	u32 value, mode;
+
+	value = ioread32(reg);
+
+	mode = value & USE_SEL_MASK;
+	if (mode == USE_SEL_GPIO)
+		seq_puts(s, "GPIO ");
+	else
+		seq_printf(s, "mode %d ", mode);
+
+	seq_printf(s, "0x%08x 0x%08x", value, ioread32(conf2));
+
+	if (lp_gpio_acpi_use(lg, pin))
+		seq_puts(s, " [ACPI]");
+}
+
 static const struct pinctrl_ops lptlp_pinctrl_ops = {
 	.get_groups_count	= lp_get_groups_count,
 	.get_group_name		= lp_get_group_name,
 	.get_group_pins		= lp_get_group_pins,
+	.pin_dbg_show		= lp_pin_dbg_show,
 };
 
 static int lp_get_functions_count(struct pinctrl_dev *pctldev)

[v2,21/24] pinctrl: lynxpoint: Implement ->pin_dbg_show()

Commit Message

Patch