| Message ID | 20180802105318.19672-1-alexander.stein@systec-electronic.com |
|---|---|
| State | New |
| Headers | show |
| Series | [v2,1/1] pinctrl: baytrail: actually print the apparently misconfigured pin | expand |
On Thu, Aug 02, 2018 at 12:53:18PM +0200, Alexander Stein wrote: > For further investigation the actual result in interrupt status register > is needed. > > Signed-off-by: Alexander Stein <alexander.stein@systec-electronic.com> Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com> > --- > I just kept to INT_TS as this is the name used in the Atom datasheet, but > I don't care what is actually used. The driver uses INT_STAT which makes it more understandable than "IRQ TS" if someone needs to debug issues like this further. -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, Aug 2, 2018 at 12:53 PM Alexander Stein <alexander.stein@systec-electronic.com> wrote: > For further investigation the actual result in interrupt status register > is needed. > > Signed-off-by: Alexander Stein <alexander.stein@systec-electronic.com> Patch applied with Mika's ACK. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/pinctrl/intel/pinctrl-baytrail.c b/drivers/pinctrl/intel/pinctrl-baytrail.c index 6b52ea1440a6..1d8d394db680 100644 --- a/drivers/pinctrl/intel/pinctrl-baytrail.c +++ b/drivers/pinctrl/intel/pinctrl-baytrail.c @@ -1691,7 +1691,8 @@ static void byt_gpio_irq_init_hw(struct byt_gpio *vg) value = readl(reg); if (value) dev_err(&vg->pdev->dev, - "GPIO interrupt error, pins misconfigured\n"); + "GPIO interrupt error, pins misconfigured. INT_STAT%u: 0x%08x\n", + base / 32, value); } }
For further investigation the actual result in interrupt status register is needed. Signed-off-by: Alexander Stein <alexander.stein@systec-electronic.com> --- I just kept to INT_TS as this is the name used in the Atom datasheet, but I don't care what is actually used. Changes in v2: * Change INT TS to INT_STAT as wellas interrupt status drivers/pinctrl/intel/pinctrl-baytrail.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)