From patchwork Thu Aug 2 10:53:18 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexander Stein X-Patchwork-Id: 952673 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=linux-gpio-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=systec-electronic.com Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 41h6Tv2z38z9s3q for ; Thu, 2 Aug 2018 20:53:23 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726977AbeHBMn5 (ORCPT ); Thu, 2 Aug 2018 08:43:57 -0400 Received: from webbox1416.server-home.net ([77.236.96.61]:40443 "EHLO webbox1416.server-home.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726862AbeHBMn5 (ORCPT ); Thu, 2 Aug 2018 08:43:57 -0400 Received: from imapserver.systec-electronic.com (unknown [212.185.67.146]) by webbox1416.server-home.net (Postfix) with ESMTPA id 6D37627A530; Thu, 2 Aug 2018 12:53:21 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by imapserver.systec-electronic.com (Postfix) with ESMTP id 27E8D1A792A; Thu, 2 Aug 2018 12:53:21 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at imapserver.systec-electronic.com Received: from imapserver.systec-electronic.com ([127.0.0.1]) by localhost (imapserver.systec-electronic.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 52stVYjSWIn9; Thu, 2 Aug 2018 12:53:19 +0200 (CEST) Received: from ws-140106.systec.local (ws-140106.systec.local [192.168.10.92]) by imapserver.systec-electronic.com (Postfix) with ESMTP id 618B81A7929; Thu, 2 Aug 2018 12:53:19 +0200 (CEST) From: Alexander Stein To: Mika Westerberg , Heikki Krogerus Cc: Alexander Stein , Linus Walleij , linux-gpio@vger.kernel.org Subject: [PATCH v2 1/1] pinctrl: baytrail: actually print the apparently misconfigured pin Date: Thu, 2 Aug 2018 12:53:18 +0200 Message-Id: <20180802105318.19672-1-alexander.stein@systec-electronic.com> X-Mailer: git-send-email 2.16.4 Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org For further investigation the actual result in interrupt status register is needed. Signed-off-by: Alexander Stein Acked-by: Mika Westerberg --- I just kept to INT_TS as this is the name used in the Atom datasheet, but I don't care what is actually used. Changes in v2: * Change INT TS to INT_STAT as wellas interrupt status drivers/pinctrl/intel/pinctrl-baytrail.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/pinctrl/intel/pinctrl-baytrail.c b/drivers/pinctrl/intel/pinctrl-baytrail.c index 6b52ea1440a6..1d8d394db680 100644 --- a/drivers/pinctrl/intel/pinctrl-baytrail.c +++ b/drivers/pinctrl/intel/pinctrl-baytrail.c @@ -1691,7 +1691,8 @@ static void byt_gpio_irq_init_hw(struct byt_gpio *vg) value = readl(reg); if (value) dev_err(&vg->pdev->dev, - "GPIO interrupt error, pins misconfigured\n"); + "GPIO interrupt error, pins misconfigured. INT_STAT%u: 0x%08x\n", + base / 32, value); } }