diff mbox

[LEDE-DEV,2/2] ip17xx: correct aneg_done return value

Message ID 20170606222532.22450-3-ryazanov.s.a@gmail.com
State Accepted
Headers show

Commit Message

Sergey Ryazanov June 6, 2017, 10:25 p.m. UTC 
PHY core treats any positive return value as the auto-negotiation done
indication. Since we do not actually check any device register in this
callback then update it to return positive value with a neutral meaning
instead of the register flag to avoid  confusing for future readers.

Signed-off-by: Sergey Ryazanov <ryazanov.s.a@gmail.com>
---
 target/linux/generic/files/drivers/net/phy/ip17xx.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff mbox

Patch

diff --git a/target/linux/generic/files/drivers/net/phy/ip17xx.c b/target/linux/generic/files/drivers/net/phy/ip17xx.c
index 9eedfd4..85a9617 100644
--- a/target/linux/generic/files/drivers/net/phy/ip17xx.c
+++ b/target/linux/generic/files/drivers/net/phy/ip17xx.c
@@ -1334,7 +1334,7 @@  static int ip17xx_config_aneg(struct phy_device *pdev)
 
 static int ip17xx_aneg_done(struct phy_device *pdev)
 {
-	return BMSR_ANEGCOMPLETE;
+	return 1;	/* Return any positive value */
 }
 
 static int ip17xx_update_link(struct phy_device *pdev)