| Message ID | 1471935415-1263-1-git-send-email-ash.benz@bk.ru |
|---|---|
| State | Changes Requested |
| Headers | show |
On 2016-08-23 08:56, Ash Benz wrote: > Explicitly call /bin/echo instead of echo only. The shell built-in echo behaves differently and causes > incomplete .cflags generation on some systems. > > Signed-off-by: Ash Benz <ash.benz@bk.ru> There's no guarantee that /bin/echo is any better than the built-in echo (or that it even exists). Please use printf to make it more portable. - Felix
diff --git a/package/network/services/hostapd/patches/200-multicall.patch b/package/network/services/hostapd/patches/200-multicall.patch index 8b260c2..85ed077 100644 --- a/package/network/services/hostapd/patches/200-multicall.patch +++ b/package/network/services/hostapd/patches/200-multicall.patch @@ -54,10 +54,10 @@ endif +dump_cflags: -+ @echo -n $(CFLAGS) " " ++ @/bin/echo -n $(CFLAGS) " " + +dump_ldflags: -+ @echo -n $(LDFLAGS) $(LIBS) $(EXTRALIBS) " " ++ @/bin/echo -n $(LDFLAGS) $(LIBS) $(EXTRALIBS) " " + nt_password_hash: $(NOBJS) $(Q)$(CC) $(LDFLAGS) -o nt_password_hash $(NOBJS) $(LIBS_n) @@ -142,10 +142,10 @@ @$(E) " sed" $< +dump_cflags: -+ @echo -n $(CFLAGS) " " ++ @/bin/echo -n $(CFLAGS) " " + +dump_ldflags: -+ @echo -n $(LDFLAGS) $(LIBS) $(EXTRALIBS) " " ++ @/bin/echo -n $(LDFLAGS) $(LIBS) $(EXTRALIBS) " " + wpa_supplicant.exe: wpa_supplicant mv -f $< $@
Explicitly call /bin/echo instead of echo only. The shell built-in echo behaves differently and causes incomplete .cflags generation on some systems. Signed-off-by: Ash Benz <ash.benz@bk.ru> --- package/network/services/hostapd/patches/200-multicall.patch | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)