diff mbox

[LEDE-DEV] buildsystem: unify host and package configure

Message ID 1463657904-27149-1-git-send-email-dirkneukirchen@web.de
State Changes Requested
Headers show

Commit Message

Dirk Neukirchen May 19, 2016, 11:38 a.m. UTC
- package-defaults.mk and host-build.mk configure could behave
differently
- there is already _ARGS in place to hand over stuff

Signed-off-by: Dirk Neukirchen <dirkneukirchen@web.de>
---
 include/host-build.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Felix Fietkau May 19, 2016, 12:34 p.m. UTC | #1
On 2016-05-19 13:38, Dirk Neukirchen wrote:
> - package-defaults.mk and host-build.mk configure could behave
> differently
> - there is already _ARGS in place to hand over stuff
> 
> Signed-off-by: Dirk Neukirchen <dirkneukirchen@web.de>
This change breaks the tools/expat build in a weird way:

make[3]: Entering directory `/var/nbd/lede/build_dir/host/expat-2.1.0'
/bin/sh ./libtool --silent --mode=compile gcc -std=gnu99 -I./lib -I. -O2 -I/var/nbd/lede/staging_dir/host/include -I/var/nbd/lede/staging_dir/host/usr/include  -Wall -Wmissing-prototypes -Wstrict-prototypes -fexceptions  -I/var/nbd/lede/staging_dir/host/include -I/var/nbd/lede/staging_dir/host/usr/include  -DHAVE_EXPAT_CONFIG_H -o lib/xmlparse.lo -c lib/xmlparse.c
./libtool: 1569: ./libtool: preserve_args+= --silent: not found
./libtool: 1: eval: base_compile+= gcc: not found
./libtool: 1: eval: base_compile+= -std=gnu99: not found
./libtool: 1: eval: base_compile+= -I./lib: not found
./libtool: 1: eval: base_compile+= -I.: not found
./libtool: 1: eval: base_compile+= -O2: not found
./libtool: 1: eval: base_compile+= -I/var/nbd/lede/staging_dir/host/include: not found
./libtool: 1: eval: base_compile+= -I/var/nbd/lede/staging_dir/host/usr/include: not found
./libtool: 1: eval: base_compile+= -Wall: not found
./libtool: 1: eval: base_compile+= -Wmissing-prototypes: not found
./libtool: 1: eval: base_compile+= -Wstrict-prototypes: not found
./libtool: 1: eval: base_compile+= -fexceptions: not found
./libtool: 1: eval: base_compile+= -I/var/nbd/lede/staging_dir/host/include: not found
./libtool: 1: eval: base_compile+= -I/var/nbd/lede/staging_dir/host/usr/include: not found
./libtool: 1: eval: base_compile+= -DHAVE_EXPAT_CONFIG_H: not found
./libtool: 1: eval: base_compile+= -c: not found
./libtool: 1: eval: CC_quoted+= gcc: not found
./libtool: 1: eval: CC_quoted+= x86_64-linux-gnu-g++: not found
libtool: compile: you must specify a compilation command
libtool: compile: Try `libtool --help --mode=compile' for more information.
make[3]: *** [lib/xmlparse.lo] Error 1
make[3]: Leaving directory `/var/nbd/lede/build_dir/host/expat-2.1.0'
make[2]: *** [/var/nbd/lede/build_dir/host/expat-2.1.0/.built] Error 2

- Felix
diff mbox

Patch

diff --git a/include/host-build.mk b/include/host-build.mk
index 456b418..58678cf 100644
--- a/include/host-build.mk
+++ b/include/host-build.mk
@@ -83,9 +83,9 @@  define Host/Configure/Default
 	$(if $(HOST_CONFIGURE_PARALLEL),+)(cd $(HOST_BUILD_DIR)/$(3); \
 		if [ -x configure ]; then \
 			$(CP) $(SCRIPT_DIR)/config.{guess,sub} $(HOST_BUILD_DIR)/$(3)/ && \
+			$(HOST_CONFIGURE_VARS) \
 			$(2) \
 			$(HOST_CONFIGURE_CMD) \
-			$(HOST_CONFIGURE_VARS) \
 			$(HOST_CONFIGURE_ARGS) \
 			$(1); \
 		fi \