| Message ID | 1463206839-17079-1-git-send-email-ldpinney@gmail.com |
|---|---|
| State | Changes Requested |
| Headers | show |
On 16-05-14 02:20 AM, L. D. Pinney wrote: > + ___________ > + / /\ ██╗ ███████╗ ██████╗ ███████╗ > + / Linux / \ ██║ ██╔════╝ ██╔══██╗ ██╔════╝ Linux > + / Embedded / \ ██║ █████╗ ██║ ██║ █████╗ Embedded > + / / \ ██║ ██╔══╝ ██║ ██║ ██╔══╝ Development > +/__________/ LE \ ███████╗ ███████╗ ██████╔╝ ███████╗ Environment > +\ \ DE / ╚══════╝ ╚══════╝ ╚═════╝ ╚══════╝ > + \ Dev. \ / > + \ Env. \ / ---------------------------------------------------------- > + \ \ / Reboot (%C, %R) ♠ ♥ ♣ ♦ lede-project.org > + \__________\/ ---------------------------------------------------------- This doesn't look like 7-bit ASCII. Are you sure it renders properly everywhere? Regards, Daniel
The line with "... Reboot (%C, %R) ..." will fail in real use, as the %C and %R will be replaced with version strings. Currently there are short strings "HEAD" and "r222" that fit ok, but try applying "Designated Driver" and "r45678" and the line will overflow. The contents of that line should be left empty after the "(%C, %R)" placeholder to allow flexibility. Additionally, the card suit symbols look strange to me.
On 14 May 2016 at 08:20, L. D. Pinney <ldpinney@gmail.com> wrote:
> This patch provides a new banner for LEDE
git log is useful for getting a proper patch prefix. Try:
git log --oneline package/base-files/
diff --git a/package/base-files/files/etc/banner b/package/base-files/files/etc/banner index ae2f16f..7b19941 100644 --- a/package/base-files/files/etc/banner +++ b/package/base-files/files/etc/banner @@ -1,10 +1,11 @@ - _________ - / /\ _ ___ ___ ___ - / LE / \ | | | __| \| __| - / DE / \ | |__| _|| |) | _| - /________/ LE \ |____|___|___/|___| lede-project.org - \ \ DE / - \ LE \ / ----------------------------------------------------------- - \ DE \ / Reboot (%C, %R) - \________\/ ----------------------------------------------------------- - + ___________ + / /\ ██╗ ███████╗ ██████╗ ███████╗ + / Linux / \ ██║ ██╔════╝ ██╔══██╗ ██╔════╝ Linux + / Embedded / \ ██║ █████╗ ██║ ██║ █████╗ Embedded + / / \ ██║ ██╔══╝ ██║ ██║ ██╔══╝ Development +/__________/ LE \ ███████╗ ███████╗ ██████╔╝ ███████╗ Environment +\ \ DE / ╚══════╝ ╚══════╝ ╚═════╝ ╚══════╝ + \ Dev. \ / + \ Env. \ / ---------------------------------------------------------- + \ \ / Reboot (%C, %R) ♠ ♥ ♣ ♦ lede-project.org + \__________\/ ----------------------------------------------------------
This patch provides a new banner for LEDE Signed-off-by: L. D. Pinney <ldpinney@gmail.com> ---