| Message ID | 20190124074630.4192-1-masashi.honma@gmail.com |
|---|---|
| Headers | show |
| Series | Use python3 compatible codes for hwsim tests | expand |
Thank you Johanness ! I will reply to each of your comments. Now I recognize parallel-vm.py does not work both python2 and 3. This is my missing of test. I only tested by using vm-run.sh. I will drop the modification of parallel-vm.py. There is no influence to other patches. And now I am trying to fix the parallel-vm.py for python3. Though there is a problem. parallel-vm.py could not get results from VMs when python3. The results are like "START", "PASS", "SKIP". vm_read_stdout() could not get these strings. Fixing this may take a while. Masashi Honma.
Hi, > Now I recognize parallel-vm.py does not work both python2 and 3. FWIW, I'm not sure I see a need to keep this python2 compatible. This is a development thing, and there we should not have a problem to just require python3. I see that it's not *that* much more work to keep it working on python2, however, if the default remains python2 then people are only going to break python3 support in the future again. And trying to keep it working on python2 will have exactly the same problem - if python3 is the default then python2 will be broken quickly ... so I'd say we should just switch, but Jouni should decide I guess :) > And now I am trying to fix the parallel-vm.py for python3. > Though there is a problem. parallel-vm.py could not get results from > VMs when python3. The results are like "START", "PASS", "SKIP". > vm_read_stdout() could not get these strings. > Fixing this may take a while. That's odd. Good luck, and thank you very much for all this work! johannes
On Fri, Jan 25, 2019 at 02:14:52PM +0100, Johannes Berg wrote: > > Now I recognize parallel-vm.py does not work both python2 and 3. > > FWIW, I'm not sure I see a need to keep this python2 compatible. This is > a development thing, and there we should not have a problem to just > require python3. > > I see that it's not *that* much more work to keep it working on python2, > however, if the default remains python2 then people are only going to > break python3 support in the future again. > > And trying to keep it working on python2 will have exactly the same > problem - if python3 is the default then python2 will be broken quickly > ... so I'd say we should just switch, but Jouni should decide I guess :) Agreed. If it makes this any easier to manage, I would have no problems with moving all this from python2 to python3 (only) if everything continues to work after these changes. While I do not really like the way python language is updated without backwards compatibility, I obviously have python3 installed and can learn the new language requirements once needed ;-). The key requirement here really is that the test setup should be easy to use for anyone and if distros start strongly preferring python3 and potentially dropping python2 altogether, it is clear that things need to change here.
On 2019/01/26 2:54, Jouni Malinen wrote: > On Fri, Jan 25, 2019 at 02:14:52PM +0100, Johannes Berg wrote: >>> Now I recognize parallel-vm.py does not work both python2 and 3. >> >> FWIW, I'm not sure I see a need to keep this python2 compatible. This is >> a development thing, and there we should not have a problem to just >> require python3. >> >> I see that it's not *that* much more work to keep it working on python2, >> however, if the default remains python2 then people are only going to >> break python3 support in the future again. >> >> And trying to keep it working on python2 will have exactly the same >> problem - if python3 is the default then python2 will be broken quickly >> ... so I'd say we should just switch, but Jouni should decide I guess :) > > Agreed. If it makes this any easier to manage, I would have no problems > with moving all this from python2 to python3 (only) if everything > continues to work after these changes. While I do not really like the > way python language is updated without backwards compatibility, I > obviously have python3 installed and can learn the new language > requirements once needed ;-). The key requirement here really is that > the test setup should be easy to use for anyone and if distros start > strongly preferring python3 and potentially dropping python2 altogether, > it is clear that things need to change here. Thank you Johannes and Jouni ! Ok, from now on I will only test with python3. Masashi Honma.
On Sat, Jan 26, 2019 at 09:11:43AM +0900, Masashi Honma wrote: > On 2019/01/26 2:54, Jouni Malinen wrote: > >Agreed. If it makes this any easier to manage, I would have no problems > >with moving all this from python2 to python3 (only) if everything > >continues to work after these changes. > Ok, from now on I will only test with python3. Just to be clear on what I meant there with "everything continues to work": that applies after every single commit. In other words, each separate change needs to be compatible with python2 and python3 until we get to a point where one commit is ready to move everything remaining into python3-only. As an example, I'm planning on applying a subset of this patch series and things need to continue to work with such subset. It is going to be easier to get updated versions in with same policy of being able to pick a subset of the updated series and apply that instead of everything if there are open questions on some of the changes.
Thanks, patches 1-9, 14, 35, 39 applied. I dropped the other patches of the series from my queue due to open comments on them.
On 2019/01/26 20:26, Jouni Malinen wrote: > Just to be clear on what I meant there with "everything continues to > work": that applies after every single commit. In other words, each > separate change needs to be compatible with python2 and python3 until we > get to a point where one commit is ready to move everything remaining > into python3-only. As an example, I'm planning on applying a subset of > this patch series and things need to continue to work with such subset. > It is going to be easier to get updated versions in with same policy of > being able to pick a subset of the updated series and apply that instead > of everything if there are open questions on some of the changes. OK. I will keep the code works on both python 2 and 3 until the point and keep every single commit does not break all. Masashi Honma.
On 2019/01/26 23:34, Jouni Malinen wrote: > Thanks, patches 1-9, 14, 35, 39 applied. I dropped the other patches > of the series from my queue due to open comments on them. Thank you. Additionally please drop 02/50 also. Because of this patch parallel-vm.py could not run even though with python2. Masashi Honma.
On Sun, Jan 27, 2019 at 05:19:51AM +0900, Masashi Honma wrote: > On 2019/01/26 23:34, Jouni Malinen wrote: > >Thanks, patches 1-9, 14, 35, 39 applied. I dropped the other patches > >of the series from my queue due to open comments on them. > > Thank you. Additionally please drop 02/50 also. Because of this patch > parallel-vm.py could not run even though with python2. I already applied those, so this would be a request to revert the commit rather than drop the patch.. Anyway, parallel-vm.py works fine for me with python2 and the changes I mentioned to that patch, so I'm not sure why I'd revert that commit.
On 2019/01/27 19:13, Jouni Malinen wrote: > I already applied those, so this would be a request to revert the commit > rather than drop the patch.. Anyway, parallel-vm.py works fine for me > with python2 and the changes I mentioned to that patch, so I'm not sure > why I'd revert that commit. Sorry, I missed your previous comment. It works. Revert not required. Masashi Honma.