diff mbox

[v3] Implement LWG 2729 for pair.

Message ID CAFk2RUb_TDbXGrsqspMDmDy8FOfeLwsFvni1L=-Ky-q+jvko4g@mail.gmail.com
State New
Headers show

Commit Message

Ville Voutilainen Sept. 27, 2016, 12:38 a.m. UTC
On 27 September 2016 at 03:21, Ville Voutilainen
<ville.voutilainen@gmail.com> wrote:
> On 27 September 2016 at 03:16, Christophe Lyon
> <christophe.lyon@linaro.org> wrote:
>>   20_util/declval/requirements/1_neg.cc  (test for errors, line 2263)
>>   20_util/declval/requirements/1_neg.cc (test for excess errors)
>>   20_util/make_signed/requirements/typedefs_neg.cc  (test for errors, line 1928)
>>   20_util/make_signed/requirements/typedefs_neg.cc (test for excess errors)
>>   20_util/make_unsigned/requirements/typedefs_neg.cc  (test for
>> errors, line 1781)
>>   20_util/make_unsigned/requirements/typedefs_neg.cc  (test for
>> errors, line 1824)
>>   20_util/make_unsigned/requirements/typedefs_neg.cc (test for excess errors)
>>
>> Error messages include:
>> /aci-gcc-fsf/builds/gcc-fsf-gccsrc/obj-aarch64-none-linux-gnu/gcc3/aarch64-none-linux-gnu/libstdc++-v3/include/type_traits:2270:
>> error: static assertion failed: declval() must not be used!
>>
>> Is it just because the pattern in dg-error is *-*-* ?
>
>
> Argh, I'll take a look. These errors come from the testsuite expecting
> certain line numbers in certain
> library headers, and adding code to said headers shifts the error lines.

I have committed the attached patch as obvious. Pardons all around for
failing to run the full suite properly.
diff mbox

Patch

diff --git a/libstdc++-v3/testsuite/20_util/declval/requirements/1_neg.cc b/libstdc++-v3/testsuite/20_util/declval/requirements/1_neg.cc
index f2a0dbf..9989a79 100644
--- a/libstdc++-v3/testsuite/20_util/declval/requirements/1_neg.cc
+++ b/libstdc++-v3/testsuite/20_util/declval/requirements/1_neg.cc
@@ -19,7 +19,7 @@ 
 // with this library; see the file COPYING3.  If not see
 // <http://www.gnu.org/licenses/>.
 
-// { dg-error "static assertion failed" "" { target *-*-* } 2263 }
+// { dg-error "static assertion failed" "" { target *-*-* } 2270 }
 
 #include <utility>
 
diff --git a/libstdc++-v3/testsuite/20_util/make_signed/requirements/typedefs_neg.cc b/libstdc++-v3/testsuite/20_util/make_signed/requirements/typedefs_neg.cc
index 6914eb4..3a097c3 100644
--- a/libstdc++-v3/testsuite/20_util/make_signed/requirements/typedefs_neg.cc
+++ b/libstdc++-v3/testsuite/20_util/make_signed/requirements/typedefs_neg.cc
@@ -48,4 +48,4 @@  void test01()
 // { dg-error "required from here" "" { target *-*-* } 40 }
 // { dg-error "required from here" "" { target *-*-* } 42 }
 
-// { dg-error "invalid use of incomplete type" "" { target *-*-* } 1928 }
+// { dg-error "invalid use of incomplete type" "" { target *-*-* } 1935 }
diff --git a/libstdc++-v3/testsuite/20_util/make_unsigned/requirements/typedefs_neg.cc b/libstdc++-v3/testsuite/20_util/make_unsigned/requirements/typedefs_neg.cc
index 81ff92a..4e64166 100644
--- a/libstdc++-v3/testsuite/20_util/make_unsigned/requirements/typedefs_neg.cc
+++ b/libstdc++-v3/testsuite/20_util/make_unsigned/requirements/typedefs_neg.cc
@@ -48,5 +48,5 @@  void test01()
 // { dg-error "required from here" "" { target *-*-* } 40 }
 // { dg-error "required from here" "" { target *-*-* } 42 }
 
-// { dg-error "invalid use of incomplete type" "" { target *-*-* } 1824 }
-// { dg-error "declaration of" "" { target *-*-* } 1781 }
+// { dg-error "invalid use of incomplete type" "" { target *-*-* } 1831 }
+// { dg-error "declaration of" "" { target *-*-* } 1788 }