From patchwork Tue Sep 27 00:38:09 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ville Voutilainen X-Patchwork-Id: 675351 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3sjhlf4k5gz9s5g for ; Tue, 27 Sep 2016 10:38:38 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b=qptN9HjK; dkim-atps=neutral DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :mime-version:in-reply-to:references:from:date:message-id :subject:to:cc:content-type; q=dns; s=default; b=BABmFrCb+JnJiPq J2Y0jw2/2lHgbtVuNXQDjt7tIJC2enyE6chnvyz9jgUrQQMSD6mbiiDtDB6AfIHi IzDPNNMFYcNNOpOdZtLYeUTZnDZZ1/YuFnGk0+sUnBbPDU41yIU5bd00vmeG3rnV I4TyoxSbaMo6wx0Rbuh3YQWmEma8= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :mime-version:in-reply-to:references:from:date:message-id :subject:to:cc:content-type; s=default; bh=8j4G0ad7I1Sim3pGJibAR NqZWgE=; b=qptN9HjKsy7gnKUZb47iiyN+H+XkjYkCdgOOVfzpm3nnOf7wDERCa Rx0gWiZn03PpSSisU6gAoHk2+k48u5YpZoYn1pQB34pO5OZVoo4QX5/BY4g/wAS4 p18SkkYDYYyYtsOgCfsxVhxS43AltUpKjhztHUMljKIdV2ZxHE+3Qk= Received: (qmail 8269 invoked by alias); 27 Sep 2016 00:38:23 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 8239 invoked by uid 89); 27 Sep 2016 00:38:22 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL, BAYES_00, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, SPF_PASS autolearn=ham version=3.3.2 spammy=1935, argh X-Spam-User: qpsmtpd, 2 recipients X-HELO: mail-ua0-f193.google.com Received: from mail-ua0-f193.google.com (HELO mail-ua0-f193.google.com) (209.85.217.193) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 27 Sep 2016 00:38:12 +0000 Received: by mail-ua0-f193.google.com with SMTP id u68so199233uau.1; Mon, 26 Sep 2016 17:38:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=bbRiZ3DTG5tBQ6iLiG/gx8Jq77qN7BPbHDIuaFKlV7w=; b=TYyqItKepeoc6ZLyHxsoL3qieqwaDGRYQiLRY0wU0CPGEpGOLGuvmPsi57Jn2KiTAw BAt+guWg+pNvBdC7WBRmv3ek91HnxpbwzrssyfBzT1Up1/kymeL8Ji0yZxV9kUfNg9+R YK9qEJIRHzIjURPMGHghXqaFHLOVSquWqVid1LuSMy1Lsqe+Nk6L6tO6rAPCbaqP0rMJ 2tODAR/O9DFD2u0zZda4nWwP2uekRD6oaZLZYD5fJK8oudrF1ey/JjriOx3oX5Ww4MbM Izymqgi/PPNcOwCW6Yi1ibB39Djh4MAT89jt/zE3w4SWZOrE5Sz4DfeCiPzjQ2IhDZq+ Yuog== X-Gm-Message-State: AA6/9Rn9RhOuDajk3FRwIWFOQLJHvalBSOiFlkzWp85ggl/B5uTTd0v2MvrMwDWhzn4GDvrNRYFE2s5OtoZwlQ== X-Received: by 10.176.3.135 with SMTP id 7mr790533uau.12.1474936690748; Mon, 26 Sep 2016 17:38:10 -0700 (PDT) MIME-Version: 1.0 Received: by 10.103.104.193 with HTTP; Mon, 26 Sep 2016 17:38:09 -0700 (PDT) In-Reply-To: References: <20160921103350.GL17376@redhat.com> <20160926125410.GQ17376@redhat.com> From: Ville Voutilainen Date: Tue, 27 Sep 2016 03:38:09 +0300 Message-ID: Subject: Re: [v3 PATCH] Implement LWG 2729 for pair. To: Christophe Lyon Cc: Jonathan Wakely , "libstdc++" , "gcc-patches@gcc.gnu.org" On 27 September 2016 at 03:21, Ville Voutilainen wrote: > On 27 September 2016 at 03:16, Christophe Lyon > wrote: >> 20_util/declval/requirements/1_neg.cc (test for errors, line 2263) >> 20_util/declval/requirements/1_neg.cc (test for excess errors) >> 20_util/make_signed/requirements/typedefs_neg.cc (test for errors, line 1928) >> 20_util/make_signed/requirements/typedefs_neg.cc (test for excess errors) >> 20_util/make_unsigned/requirements/typedefs_neg.cc (test for >> errors, line 1781) >> 20_util/make_unsigned/requirements/typedefs_neg.cc (test for >> errors, line 1824) >> 20_util/make_unsigned/requirements/typedefs_neg.cc (test for excess errors) >> >> Error messages include: >> /aci-gcc-fsf/builds/gcc-fsf-gccsrc/obj-aarch64-none-linux-gnu/gcc3/aarch64-none-linux-gnu/libstdc++-v3/include/type_traits:2270: >> error: static assertion failed: declval() must not be used! >> >> Is it just because the pattern in dg-error is *-*-* ? > > > Argh, I'll take a look. These errors come from the testsuite expecting > certain line numbers in certain > library headers, and adding code to said headers shifts the error lines. I have committed the attached patch as obvious. Pardons all around for failing to run the full suite properly. diff --git a/libstdc++-v3/testsuite/20_util/declval/requirements/1_neg.cc b/libstdc++-v3/testsuite/20_util/declval/requirements/1_neg.cc index f2a0dbf..9989a79 100644 --- a/libstdc++-v3/testsuite/20_util/declval/requirements/1_neg.cc +++ b/libstdc++-v3/testsuite/20_util/declval/requirements/1_neg.cc @@ -19,7 +19,7 @@ // with this library; see the file COPYING3. If not see // . -// { dg-error "static assertion failed" "" { target *-*-* } 2263 } +// { dg-error "static assertion failed" "" { target *-*-* } 2270 } #include diff --git a/libstdc++-v3/testsuite/20_util/make_signed/requirements/typedefs_neg.cc b/libstdc++-v3/testsuite/20_util/make_signed/requirements/typedefs_neg.cc index 6914eb4..3a097c3 100644 --- a/libstdc++-v3/testsuite/20_util/make_signed/requirements/typedefs_neg.cc +++ b/libstdc++-v3/testsuite/20_util/make_signed/requirements/typedefs_neg.cc @@ -48,4 +48,4 @@ void test01() // { dg-error "required from here" "" { target *-*-* } 40 } // { dg-error "required from here" "" { target *-*-* } 42 } -// { dg-error "invalid use of incomplete type" "" { target *-*-* } 1928 } +// { dg-error "invalid use of incomplete type" "" { target *-*-* } 1935 } diff --git a/libstdc++-v3/testsuite/20_util/make_unsigned/requirements/typedefs_neg.cc b/libstdc++-v3/testsuite/20_util/make_unsigned/requirements/typedefs_neg.cc index 81ff92a..4e64166 100644 --- a/libstdc++-v3/testsuite/20_util/make_unsigned/requirements/typedefs_neg.cc +++ b/libstdc++-v3/testsuite/20_util/make_unsigned/requirements/typedefs_neg.cc @@ -48,5 +48,5 @@ void test01() // { dg-error "required from here" "" { target *-*-* } 40 } // { dg-error "required from here" "" { target *-*-* } 42 } -// { dg-error "invalid use of incomplete type" "" { target *-*-* } 1824 } -// { dg-error "declaration of" "" { target *-*-* } 1781 } +// { dg-error "invalid use of incomplete type" "" { target *-*-* } 1831 } +// { dg-error "declaration of" "" { target *-*-* } 1788 }