diff mbox

Recent go changes broke alpha bootstrap

Message ID CAFULd4YDSGuvyof-bTLAQBNHbF3OKy=w2rBCvY3Vyy+HGdN9_w@mail.gmail.com
State New
Headers show

Commit Message

Uros Bizjak Nov. 4, 2014, 6:29 p.m. UTC 
On Tue, Nov 4, 2014 at 12:20 PM, Uros Bizjak <ubizjak@gmail.com> wrote:

>>> Bitfields can really not be represented properly in Go (think about
>>> constructs like "struct { int : 1; int bf : 1; }"), I'd rather not
>>> try to represent them in a predictable way.  The patched code may
>>> or may not give them a name, and reserves the proper amount of
>>> padding where required in structs.  If a union begins with an
>>> anonymous bitfield (which makes no sense), that is ignored.  If a
>>> union begins with a named bitfield (possibly after unnamed ones),
>>> this may or may not be used as the (sole) element of the Go
>>> struct.
>>
>>
>> Thanks.  I committed your patch.
>
> I have checked that the patch fixes alpha bootstrap with libgo.

Also passes gcc.misc-tests/godump-1.c test.

2014-11-04  Uros Bizjak  <ubizjak@gmail.com>

    * gcc.misc-tests/godump-1.c (dg-skip-if): Add alpha*-*-*.

Tested on alphaev68-linux-gnu and committed to mainline SVN.

Uros.


 #include <stdint.h>
diff mbox

Patch

Index: gcc.misc-tests/godump-1.c
===================================================================
--- gcc.misc-tests/godump-1.c   (revision 217089)
+++ gcc.misc-tests/godump-1.c   (working copy)
@@ -2,7 +2,7 @@ 

 /* { dg-options "-c -fdump-go-spec=godump-1.out" } */
 /* { dg-do compile } */
-/* { dg-skip-if "not supported for target" { ! "s390*-*-* i?86-*-*
x86_64-*-*" } } */
+/* { dg-skip-if "not supported for target" { ! "alpha*-*-* s390*-*-*
i?86-*-* x86_64-*-*" } } */
 /* { dg-skip-if "not supported for target" { ! lp64 } } */