From patchwork Tue Nov 4 18:29:53 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Uros Bizjak X-Patchwork-Id: 406736 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id E64861400A0 for ; Wed, 5 Nov 2014 05:30:08 +1100 (AEDT) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :mime-version:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; q=dns; s=default; b=htS1b733zYzvsGdE+k xHfi1dUIq+nKaEFEYicoIkglsznrYyFpBM/L8PgEwYyyXzyX9VvhZ0CW6MX3ra3h zzVLdsAmciav/pRH3/+0D7etIEH/fSgtyevUUxdo7w+omak02SdOnbQoe9fJuQMW WdPYHpJIcUO3KVN56xWB1N/C8= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :mime-version:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; s=default; bh=j/mIywdRM3Tm6AUzE3exDaYQ 9WA=; b=LCKnIhaM3tHQbDClIUaSzElqGheYfaTRtlaQ+YG0/UCFQZEgluTcOyir xFvjf01KhHO6mv22Dy9ePdZgTSKnC1eFERbzn7fTcNfa0Pd5DylChe/kh0MC7P79 dL4VJUvlJQ/sCh2IuE/YIz/NVVyGXpWzdo74symfJ7/gcsYGcMY= Received: (qmail 8047 invoked by alias); 4 Nov 2014 18:30:01 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 8008 invoked by uid 89); 4 Nov 2014 18:30:01 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL, BAYES_00, FREEMAIL_FROM, RCVD_IN_DNSWL_LOW, SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-lb0-f180.google.com Received: from mail-lb0-f180.google.com (HELO mail-lb0-f180.google.com) (209.85.217.180) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Tue, 04 Nov 2014 18:29:59 +0000 Received: by mail-lb0-f180.google.com with SMTP id u10so3150495lbd.39 for ; Tue, 04 Nov 2014 10:29:53 -0800 (PST) MIME-Version: 1.0 X-Received: by 10.152.43.197 with SMTP id y5mr62241353lal.82.1415125793659; Tue, 04 Nov 2014 10:29:53 -0800 (PST) Received: by 10.152.8.103 with HTTP; Tue, 4 Nov 2014 10:29:53 -0800 (PST) In-Reply-To: References: <20141030124621.GA18230@linux.vnet.ibm.com> <20141103170240.GA11956@linux.vnet.ibm.com> Date: Tue, 4 Nov 2014 19:29:53 +0100 Message-ID: Subject: Re: Recent go changes broke alpha bootstrap From: Uros Bizjak To: gcc-patches Cc: Dominik Vogt , Ian Taylor On Tue, Nov 4, 2014 at 12:20 PM, Uros Bizjak wrote: >>> Bitfields can really not be represented properly in Go (think about >>> constructs like "struct { int : 1; int bf : 1; }"), I'd rather not >>> try to represent them in a predictable way. The patched code may >>> or may not give them a name, and reserves the proper amount of >>> padding where required in structs. If a union begins with an >>> anonymous bitfield (which makes no sense), that is ignored. If a >>> union begins with a named bitfield (possibly after unnamed ones), >>> this may or may not be used as the (sole) element of the Go >>> struct. >> >> >> Thanks. I committed your patch. > > I have checked that the patch fixes alpha bootstrap with libgo. Also passes gcc.misc-tests/godump-1.c test. 2014-11-04 Uros Bizjak * gcc.misc-tests/godump-1.c (dg-skip-if): Add alpha*-*-*. Tested on alphaev68-linux-gnu and committed to mainline SVN. Uros. #include Index: gcc.misc-tests/godump-1.c =================================================================== --- gcc.misc-tests/godump-1.c (revision 217089) +++ gcc.misc-tests/godump-1.c (working copy) @@ -2,7 +2,7 @@ /* { dg-options "-c -fdump-go-spec=godump-1.out" } */ /* { dg-do compile } */ -/* { dg-skip-if "not supported for target" { ! "s390*-*-* i?86-*-* x86_64-*-*" } } */ +/* { dg-skip-if "not supported for target" { ! "alpha*-*-* s390*-*-* i?86-*-* x86_64-*-*" } } */ /* { dg-skip-if "not supported for target" { ! lp64 } } */