diff mbox

[AArch64,committed] Fix some target attribute inlining tests for -fPIC

Message ID 55CDBB0E.7070808@arm.com
State New
Headers show

Commit Message

Kyrylo Tkachov Aug. 14, 2015, 9:55 a.m. UTC
Hi all,

Some of the new target attribute tests fail when testing with an explicit -fPIC:
         NA->FAIL: gcc.target/aarch64/target_attr_14.c scan-assembler-not bl.*bar
         NA->FAIL: gcc.target/aarch64/target_attr_5.c scan-assembler-not bl.*bar
         NA->FAIL: gcc.target/aarch64/target_attr_8.c scan-assembler-not bl.*bar

The fix for that is to add a static modifier to the function being inlined.
Committed as obvious with r226889.

Thanks,
Kyrill

2015-08-14  Kyrylo Tkachov  <kyrylo.tkachov@arm.com>

     * gcc.target/aarch64/target_attr_5.c: Add static modifier to bar.
     * gcc.target/aarch64/target_attr_8.c: Likewise.
     * gcc.target/aarch64/target_attr_14.c: Likewise.
diff mbox

Patch

diff --git a/gcc/testsuite/gcc.target/aarch64/target_attr_14.c b/gcc/testsuite/gcc.target/aarch64/target_attr_14.c
index a4e481d..916b5a6 100644
--- a/gcc/testsuite/gcc.target/aarch64/target_attr_14.c
+++ b/gcc/testsuite/gcc.target/aarch64/target_attr_14.c
@@ -4,7 +4,7 @@ 
 /* Inlining non-strict-align functions into strict-align
    functions is allowed.  */
 
-int
+static int
 bar (int a)
 {
   return a - 6;
diff --git a/gcc/testsuite/gcc.target/aarch64/target_attr_5.c b/gcc/testsuite/gcc.target/aarch64/target_attr_5.c
index 4fc0709..9eac06e 100644
--- a/gcc/testsuite/gcc.target/aarch64/target_attr_5.c
+++ b/gcc/testsuite/gcc.target/aarch64/target_attr_5.c
@@ -4,7 +4,7 @@ 
 /* Make sure that bar is inlined into bam.  */
 
 __attribute__ ((target ("arch=armv8-a+nocrc")))
-int
+static int
 bar (int a)
 {
   return a - 6;
diff --git a/gcc/testsuite/gcc.target/aarch64/target_attr_8.c b/gcc/testsuite/gcc.target/aarch64/target_attr_8.c
index 32d173c..00ebd8c 100644
--- a/gcc/testsuite/gcc.target/aarch64/target_attr_8.c
+++ b/gcc/testsuite/gcc.target/aarch64/target_attr_8.c
@@ -5,7 +5,7 @@ 
    Inlining should be allowed.  */
 
 __attribute__ ((target ("arch=armv8-a+nocrc")))
-int
+static int
 bar (int a)
 {
   return a - 6;