From patchwork Fri Aug 14 09:55:26 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kyrylo Tkachov X-Patchwork-Id: 507329 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 7AF4D140187 for ; Fri, 14 Aug 2015 19:55:42 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b=ilnHuj5p; dkim-atps=neutral DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :message-id:date:from:mime-version:to:subject:content-type; q= dns; s=default; b=xdwSHFMiUt89HdQpEuqU+PEJSW32koYoihBk6Nz0daFi3N ZzHCV3cYOc9+JR1NueZ2eo1h/oUMhOVFO6aafwODUWLgLYSL/IwBC4DS4jOrtY5U z2OE4aDntfhzftu0QFrcMbFPzGUaeDmnCdtpYWUlVzDHiVa0f/uqJ/uzuN6ns= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :message-id:date:from:mime-version:to:subject:content-type; s= default; bh=hz4E41vlvWPDv/IVYF6vmmpmc0c=; b=ilnHuj5pua9SrtlAl6Zh 4MGzpGXrrZrzfnifPP1TqwQOn5P/uEjjOcPebl8SCoAHlC1hnucI+6B8qcR52P4O IB/0a0rkzbSWJrejj9xhZetm903kkx851lI5Ouk5cpKd4IgKy01VBxKq+uJPcKSI mpHwRAYEq/P5Xkr3HZaUtSE= Received: (qmail 101160 invoked by alias); 14 Aug 2015 09:55:34 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 100423 invoked by uid 89); 14 Aug 2015 09:55:34 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL, BAYES_00, SPF_PASS autolearn=ham version=3.3.2 X-HELO: eu-smtp-delivery-143.mimecast.com Received: from eu-smtp-delivery-143.mimecast.com (HELO eu-smtp-delivery-143.mimecast.com) (146.101.78.143) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 14 Aug 2015 09:55:33 +0000 Received: from cam-owa1.Emea.Arm.com (fw-tnat.cambridge.arm.com [217.140.96.140]) by eu-smtp-1.mimecast.com with ESMTP id uk-mta-9-Hkosz_q2Tb2Cy_URlx4hGg-1; Fri, 14 Aug 2015 10:55:27 +0100 Received: from [10.2.207.50] ([10.1.2.79]) by cam-owa1.Emea.Arm.com with Microsoft SMTPSVC(6.0.3790.3959); Fri, 14 Aug 2015 10:55:27 +0100 Message-ID: <55CDBB0E.7070808@arm.com> Date: Fri, 14 Aug 2015 10:55:26 +0100 From: Kyrill Tkachov User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-Version: 1.0 To: GCC Patches Subject: [PATCH][AArch64][committed] Fix some target attribute inlining tests for -fPIC X-MC-Unique: Hkosz_q2Tb2Cy_URlx4hGg-1 X-IsSubscribed: yes Hi all, Some of the new target attribute tests fail when testing with an explicit -fPIC: NA->FAIL: gcc.target/aarch64/target_attr_14.c scan-assembler-not bl.*bar NA->FAIL: gcc.target/aarch64/target_attr_5.c scan-assembler-not bl.*bar NA->FAIL: gcc.target/aarch64/target_attr_8.c scan-assembler-not bl.*bar The fix for that is to add a static modifier to the function being inlined. Committed as obvious with r226889. Thanks, Kyrill 2015-08-14 Kyrylo Tkachov * gcc.target/aarch64/target_attr_5.c: Add static modifier to bar. * gcc.target/aarch64/target_attr_8.c: Likewise. * gcc.target/aarch64/target_attr_14.c: Likewise. diff --git a/gcc/testsuite/gcc.target/aarch64/target_attr_14.c b/gcc/testsuite/gcc.target/aarch64/target_attr_14.c index a4e481d..916b5a6 100644 --- a/gcc/testsuite/gcc.target/aarch64/target_attr_14.c +++ b/gcc/testsuite/gcc.target/aarch64/target_attr_14.c @@ -4,7 +4,7 @@ /* Inlining non-strict-align functions into strict-align functions is allowed. */ -int +static int bar (int a) { return a - 6; diff --git a/gcc/testsuite/gcc.target/aarch64/target_attr_5.c b/gcc/testsuite/gcc.target/aarch64/target_attr_5.c index 4fc0709..9eac06e 100644 --- a/gcc/testsuite/gcc.target/aarch64/target_attr_5.c +++ b/gcc/testsuite/gcc.target/aarch64/target_attr_5.c @@ -4,7 +4,7 @@ /* Make sure that bar is inlined into bam. */ __attribute__ ((target ("arch=armv8-a+nocrc"))) -int +static int bar (int a) { return a - 6; diff --git a/gcc/testsuite/gcc.target/aarch64/target_attr_8.c b/gcc/testsuite/gcc.target/aarch64/target_attr_8.c index 32d173c..00ebd8c 100644 --- a/gcc/testsuite/gcc.target/aarch64/target_attr_8.c +++ b/gcc/testsuite/gcc.target/aarch64/target_attr_8.c @@ -5,7 +5,7 @@ Inlining should be allowed. */ __attribute__ ((target ("arch=armv8-a+nocrc"))) -int +static int bar (int a) { return a - 6;