| Message ID | 20240516090922.1477786-1-christoph.muellner@vrull.eu |
|---|---|
| State | New |
| Headers | show |
| Series | RISC-V: testsuite: Drop march-string in cmpmemsi/cpymemsi tests | expand |
LGTM On Thu, May 16, 2024 at 5:09 PM Christoph Müllner <christoph.muellner@vrull.eu> wrote: > > The tests cmpmemsi-1.c and cpymemsi-1.c are execution ("dg-do run") > tests, which does not have any restrictions for the enabled extensions. > Further, no other listed options are required. > Let's drop the options, so that the test can also be executed on > non-f and non-d targets. However, we need to set options to the > defaults without '-ansi', because the included test file uses the > 'asm' keyword, which is not part of ANSI C. > > gcc/testsuite/ChangeLog: > > * gcc.target/riscv/cmpmemsi-1.c: Drop options. > * gcc.target/riscv/cpymemsi-1.c: Likewise. > > Signed-off-by: Christoph Müllner <christoph.muellner@vrull.eu> > --- > gcc/testsuite/gcc.target/riscv/cmpmemsi-1.c | 3 +-- > gcc/testsuite/gcc.target/riscv/cpymemsi-1.c | 4 +--- > 2 files changed, 2 insertions(+), 5 deletions(-) > > diff --git a/gcc/testsuite/gcc.target/riscv/cmpmemsi-1.c b/gcc/testsuite/gcc.target/riscv/cmpmemsi-1.c > index d7e0bc47407..698f27d89fb 100644 > --- a/gcc/testsuite/gcc.target/riscv/cmpmemsi-1.c > +++ b/gcc/testsuite/gcc.target/riscv/cmpmemsi-1.c > @@ -1,6 +1,5 @@ > /* { dg-do run } */ > -/* { dg-options "-march=rv32gc_zbb -save-temps -g0 -fno-lto" { target { rv32 } } } */ > -/* { dg-options "-march=rv64gc_zbb -save-temps -g0 -fno-lto" { target { rv64 } } } */ > +/* { dg-options "-pedantic-errors" } */ > /* { dg-timeout-factor 2 } */ > > #include "../../gcc.dg/memcmp-1.c" > diff --git a/gcc/testsuite/gcc.target/riscv/cpymemsi-1.c b/gcc/testsuite/gcc.target/riscv/cpymemsi-1.c > index 983b564ccaf..30e9f119bed 100644 > --- a/gcc/testsuite/gcc.target/riscv/cpymemsi-1.c > +++ b/gcc/testsuite/gcc.target/riscv/cpymemsi-1.c > @@ -1,7 +1,5 @@ > /* { dg-do run } */ > -/* { dg-options "-march=rv32gc -save-temps -g0 -fno-lto" { target { rv32 } } } */ > -/* { dg-options "-march=rv64gc -save-temps -g0 -fno-lto" { target { rv64 } } } */ > -/* { dg-additional-options "-DRUN_FRACTION=11" { target simulator } } */ > +/* { dg-options "-pedantic-errors" } */ > /* { dg-timeout-factor 2 } */ > > #include "../../gcc.dg/memcmp-1.c" > -- > 2.44.0 >
diff --git a/gcc/testsuite/gcc.target/riscv/cmpmemsi-1.c b/gcc/testsuite/gcc.target/riscv/cmpmemsi-1.c index d7e0bc47407..698f27d89fb 100644 --- a/gcc/testsuite/gcc.target/riscv/cmpmemsi-1.c +++ b/gcc/testsuite/gcc.target/riscv/cmpmemsi-1.c @@ -1,6 +1,5 @@ /* { dg-do run } */ -/* { dg-options "-march=rv32gc_zbb -save-temps -g0 -fno-lto" { target { rv32 } } } */ -/* { dg-options "-march=rv64gc_zbb -save-temps -g0 -fno-lto" { target { rv64 } } } */ +/* { dg-options "-pedantic-errors" } */ /* { dg-timeout-factor 2 } */ #include "../../gcc.dg/memcmp-1.c" diff --git a/gcc/testsuite/gcc.target/riscv/cpymemsi-1.c b/gcc/testsuite/gcc.target/riscv/cpymemsi-1.c index 983b564ccaf..30e9f119bed 100644 --- a/gcc/testsuite/gcc.target/riscv/cpymemsi-1.c +++ b/gcc/testsuite/gcc.target/riscv/cpymemsi-1.c @@ -1,7 +1,5 @@ /* { dg-do run } */ -/* { dg-options "-march=rv32gc -save-temps -g0 -fno-lto" { target { rv32 } } } */ -/* { dg-options "-march=rv64gc -save-temps -g0 -fno-lto" { target { rv64 } } } */ -/* { dg-additional-options "-DRUN_FRACTION=11" { target simulator } } */ +/* { dg-options "-pedantic-errors" } */ /* { dg-timeout-factor 2 } */ #include "../../gcc.dg/memcmp-1.c"
The tests cmpmemsi-1.c and cpymemsi-1.c are execution ("dg-do run") tests, which does not have any restrictions for the enabled extensions. Further, no other listed options are required. Let's drop the options, so that the test can also be executed on non-f and non-d targets. However, we need to set options to the defaults without '-ansi', because the included test file uses the 'asm' keyword, which is not part of ANSI C. gcc/testsuite/ChangeLog: * gcc.target/riscv/cmpmemsi-1.c: Drop options. * gcc.target/riscv/cpymemsi-1.c: Likewise. Signed-off-by: Christoph Müllner <christoph.muellner@vrull.eu> --- gcc/testsuite/gcc.target/riscv/cmpmemsi-1.c | 3 +-- gcc/testsuite/gcc.target/riscv/cpymemsi-1.c | 4 +--- 2 files changed, 2 insertions(+), 5 deletions(-)