diff mbox series

middle-end/105165 - sorry instead of ICE for _Complex asm goto

Message ID 20220406124439.B089F13A8E@imap2.suse-dmz.suse.de
State New
Headers show
Series middle-end/105165 - sorry instead of ICE for _Complex asm goto | expand

Commit Message

Richard Biener April 6, 2022, 12:44 p.m. UTC 
Complex lowering cannot currently deal with asm gotos with _Complex
output operands.  Emit a sorry instead of ICEing, those should not
appear in practice.

Bootstrapped and tested on x86_64-unknown-linux-gnu.

OK for trunk and branch?

Thanks,
Richard.

2022-04-06  Richard Biener  <rguenther@suse.de>

	PR middle-end/105165
	* tree-complex.cc (expand_complex_asm): Sorry for asm goto
	_Complex outputs.

	* gcc.dg/pr105165.c: New testcase.
---
 gcc/testsuite/gcc.dg/pr105165.c | 13 +++++++++++++
 gcc/tree-complex.cc             | 16 ++++++++++++++++
 2 files changed, 29 insertions(+)
 create mode 100644 gcc/testsuite/gcc.dg/pr105165.c

Comments

Jeff Law April 6, 2022, 3:20 p.m. UTC | #1 
On 4/6/2022 6:44 AM, Richard Biener via Gcc-patches wrote:
> Complex lowering cannot currently deal with asm gotos with _Complex
> output operands.  Emit a sorry instead of ICEing, those should not
> appear in practice.
>
> Bootstrapped and tested on x86_64-unknown-linux-gnu.
>
> OK for trunk and branch?
>
> Thanks,
> Richard.
>
> 2022-04-06  Richard Biener  <rguenther@suse.de>
>
> 	PR middle-end/105165
> 	* tree-complex.cc (expand_complex_asm): Sorry for asm goto
> 	_Complex outputs.
>
> 	* gcc.dg/pr105165.c: New testcase.
LGTM.
jeff
diff mbox series

Patch

diff --git a/gcc/testsuite/gcc.dg/pr105165.c b/gcc/testsuite/gcc.dg/pr105165.c
new file mode 100644
index 00000000000..055a10528b5
--- /dev/null
+++ b/gcc/testsuite/gcc.dg/pr105165.c
@@ -0,0 +1,13 @@ 
+/* { dg-do compile } */
+/* { dg-options "-O" } */
+
+unsigned int _Complex a0;
+unsigned int _Complex
+foo (unsigned int _Complex a1, unsigned int _Complex a2)
+{
+  unsigned int _Complex x;
+  asm goto ("" : "=r" (x) : : : lab); /* { dg-message "sorry, unimplemented" } */
+  a0 = x;
+ lab:
+  return x + a1 + a2 + 1;
+}
diff --git a/gcc/tree-complex.cc b/gcc/tree-complex.cc
index 8f03b236094..42db96a132b 100644
--- a/gcc/tree-complex.cc
+++ b/gcc/tree-complex.cc
@@ -41,6 +41,7 @@  along with GCC; see the file COPYING3.  If not see
 #include "cfgloop.h"
 #include "cfganal.h"
 #include "gimple-fold.h"
+#include "diagnostic-core.h"
 
 
 /* For each complex ssa name, a lattice value.  We're interested in finding
@@ -1614,6 +1615,7 @@  expand_complex_asm (gimple_stmt_iterator *gsi)
 {
   gasm *stmt = as_a <gasm *> (gsi_stmt (*gsi));
   unsigned int i;
+  bool diagnosed_p = false;
 
   for (i = 0; i < gimple_asm_noutputs (stmt); ++i)
     {
@@ -1622,6 +1624,20 @@  expand_complex_asm (gimple_stmt_iterator *gsi)
       if (TREE_CODE (op) == SSA_NAME
 	  && TREE_CODE (TREE_TYPE (op)) == COMPLEX_TYPE)
 	{
+	  if (gimple_asm_nlabels (stmt) > 0)
+	    {
+	      if (!diagnosed_p)
+		{
+		  sorry_at (gimple_location (stmt),
+			    "%<asm goto%> with complex typed outputs");
+		  diagnosed_p = true;
+		}
+	      /* Make sure to not ICE later, see PR105165.  */
+	      tree zero = build_zero_cst (TREE_TYPE (TREE_TYPE (op)));
+	      set_component_ssa_name (op, false, zero);
+	      set_component_ssa_name (op, true, zero);
+	      continue;
+	    }
 	  tree type = TREE_TYPE (op);
 	  tree inner_type = TREE_TYPE (type);
 	  tree r = build1 (REALPART_EXPR, inner_type, op);